5b22d2c400
g10: Fix possible null dereference.
...
* g10/armor.c (armor_filter): Access ->d in the internal loop.
--
Cherry-picked master commit of:
802a2aa300
2019-05-14 11:24:35 +09:00
0ce94a9698
g10, sm, dirmngr, common: Add comment for fall through.
...
* common/b64dec.c (b64dec_proc): Comment to clarify.
* dirmngr/cdblib.c (cdb_make_put): Use same pattern to clarify.
* dirmngr/dirmngr-client.c (read_pem_certificate): Likewise.
* dirmngr/ks-engine-hkp.c (ks_hkp_get): Likewise.
* g10/armor.c (unarmor_pump): Likewise.
* g10/gpg.c (main): Likewise.
* g10/import.c (read_block): Likewise.
* g10/keygen.c (make_backsig): Likewise.
* g10/pkclist.c (check_signatures_trust): Likewise.
* sm/gpgsm.c (main): Likewise.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
2017-05-10 11:13:12 +09:00
70aca95d68
Remove -I option to common.
...
* dirmngr/Makefile.am (AM_CPPFLAGS): Remove -I$(top_srcdir)/common.
* g10/Makefile.am (AM_CPPFLAGS): Ditto.
* g13/Makefile.am (AM_CPPFLAGS): Ditto.
* kbx/Makefile.am (AM_CPPFLAGS): Ditto.
* scd/Makefile.am (AM_CPPFLAGS): Ditto.
* sm/Makefile.am (AM_CPPFLAGS): Ditto.
* tools/Makefile.am (AM_CPPFLAGS): Ditto.
* Throughout: Follow the change.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
2017-03-07 20:25:54 +09:00
24cf0606b4
Clean up word replication.
...
--
This fixes extra word repetitions (like "the the" or "is is") in the
code and docs.
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
2017-02-21 13:11:46 -05:00
522f74f7e3
Improve some comments.
2016-11-29 14:56:00 +01:00
4d7dc432b5
Change all http://www.gnu.org in license notices to https://
...
--
2016-11-05 12:02:19 +01:00
0d67241e31
Fix more spelling
...
* NEWS, acinclude.m4, agent/command-ssh.c, agent/command.c,
agent/gpg-agent.c, agent/keyformat.txt, agent/protect-tool.c,
common/asshelp.c, common/b64enc.c, common/recsel.c, doc/DETAILS,
doc/HACKING, doc/Notes, doc/TRANSLATE, doc/dirmngr.texi,
doc/faq.org, doc/gpg-agent.texi, doc/gpg.texi, doc/gpgsm.texi,
doc/instguide.texi, g10/armor.c, g10/gpg.c, g10/keyedit.c,
g10/mainproc.c, g10/pkclist.c, g10/tofu.c, g13/sh-cmd.c,
g13/sh-dmcrypt.c, kbx/keybox-init.c, m4/pkg.m4, sm/call-dirmngr.c,
sm/gpgsm.c, tests/Makefile.am, tests/gpgscm/Manual.txt,
tests/gpgscm/scheme.c, tests/openpgp/gpgv-forged-keyring.scm,
tests/openpgp/multisig.test, tests/openpgp/verify.scm,
tests/pkits/README, tools/applygnupgdefaults,
tools/gpg-connect-agent.c, tools/mime-maker.c, tools/mime-parser.c:
minor spelling cleanup.
Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
2016-09-17 16:00:37 +09:00
5d1a9c4dc8
gpg: Fix possible out-of-bounds read in is_armored.
...
* g10/armor.c (check_input): Call is_armored only if LEN >= 2.
(unarmor_pump): Use a 2 byte buffer for is_armored.
--
Fixes-commit: 605276ef8c
2016-07-05 18:49:06 +02:00
a6b87981f7
g10: Fix out-of-bounds read.
...
* g10/armor.c (use_armor_filter): We need two bytes for 'is_armored'.
Signed-off-by: Justus Winter <justus@g10code.com>
2016-07-05 12:38:15 +02:00
64bfeafa52
gpg: Remove all assert.h and s/assert/log_assert/.
...
Signed-off-by: Werner Koch <wk@gnupg.org>
2016-04-29 11:05:24 +02:00
605276ef8c
gpg: More robustly detect valid non-armored OpenPGP messages.
...
* g10/armor.c (is_armored): More robustly detect valid non-armored
OpenPGP messages.
--
Signed-off-by: Neal H. Walfield <neal@g10code.com>
2016-03-02 20:36:18 +01:00
2f02ed75a9
gpg: Make ASCII armor decoding more robust to encoding errors.
...
* g10/armor.c (radix64_read): If the = is followed by the string "3D",
check if the following four characters are valid radix 64 and are
followed by a new line. If so, warn and ignore the '3D'.
--
Signed-off-by: Neal H. Walfield <neal@g10code.com>
GnuPG-bug-id: 2250
2016-02-16 13:09:32 +01:00
3f52c7da39
common: Fix iobuf API of filter function for alignment.
...
* common/iobuf.h (IOBUFCTRL_DESC): Change the call semantics.
* common/iobuf.c (iobuf_desc): Add the second argument DESC.
(print_chain, iobuf_close, do_open, iobuf_sockopen, iobuf_ioctl)
(iobuf_push_filter2, pop_filter, iobuf_write_temp): Change calls
of iobuf_desc.
(file_filter, file_es_filter, sock_filter, block_filter): Fill the
description.
* common/t-iobuf.c (every_other_filter, double_filter): Likewise.
* g10/armor.c, g10/cipher.c, g10/compress-bz2.c, g10/compress.c,
g10/decrypt-data.c, g10/encrypt.c, g10/mdfilter.c, g10/progress.c,
g10/textfilter.c: Likewise.
--
Newer GCC warns against possible alignment difference of pointers.
This change can silence those warnings.
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
2016-01-12 10:32:20 +09:00
008aa6e6d4
gpg: Fix warnings about useless assignments.
...
* g10/armor.c (parse_hash_header): Remove duplicate var assignment.
* g10/getkey.c (cache_user_id): Ditto.
* g10/keygen.c (ask_curve): Ditto. This also fixes a small memory
leak.
* g10/keygen.c (proc_parameter_file): Remove useless assignment or
pointer increment.
(generate_keypair): Ditto.
* g10/getkey.c (finish_lookup, lookup): Ditto.
* g10/card-util.c (change_pin): Ditto.
* g10/gpg.c (main) <aVerify>: Ditto.
* g10/import.c (import): Ditto.
(print_import_check): Ditto
* g10/keyring.c (do_copy): Ditto.
* g10/tdbio.c (tdbio_read_record): Ditto.
* g10/trustdb.c (tdb_update_ownertrust): Ditto.
(update_validity): Ditto.
* g10/server.c (cmd_passwd): Remove useless call to skip_options.
--
Signed-off-by: Werner Koch <wk@gnupg.org>
2016-01-07 19:09:16 +01:00
11142e0ad7
gpg: Replace remaining old error code macros by GPG_ERR_.
...
* g10/gpg.h (g10_errstr): Remove macro and change all occurrences by
gpg_strerror.
(G10ERR_): Remove all macros and change all occurrences by their
GPG_ERR_ counterparts.
Signed-off-by: Werner Koch <wk@gnupg.org>
2015-01-22 12:06:11 +01:00
e30cb8f617
gpg: Remove PGP-2 related cruft.
...
* g10/armor.c (parse_hash_header,carmor_filter): Ignore MD5 in hash
header.
(fake_packet): Remove pgp-2 workaround for white space stripping.
* g10/filter.h (armor_filter_context_t): Remove field pgp2mode.
* g10/options.h (opt): Remove field pgp2_workarounds.
* g10/gpg.c (main): Do not set this field.
* g10/gpgv.c (main): Ditto.
* g10/mainproc.c (proc_encrypted): Use SHA-1 as fallback s2k hash
algo. Using MD5 here is useless.
(proc_plaintext): Remove PGP-2 related woraround
(proc_tree): Remove another workaround but keep the one for PGP-5.
--
The removed code was either not anymore used or its use would have
caused an error message later anyway.
Signed-off-by: Werner Koch <wk@gnupg.org>
2014-11-13 12:01:42 +01:00
e951782e93
gpg: Change armor Version header to emit only the major version.
...
* g10/options.h (opt): Rename field no_version to emit_version.
* g10/gpg.c (main): Init opt.emit_vesion to 1. Change --emit-version
to bump up opt.emit_version.
* g10/armor.c (armor_filter): Implement different --emit-version
values.
--
GnuPG-bug-id: 1572
Signed-off-by: Werner Koch <wk@gnupg.org>
2013-11-27 09:20:02 +01:00
cc9a0b69b6
Make use of the *_NAME etc macros.
...
Replace hardwired strings at many places with new macros from config.h
and use the new strusage macro replacement feature.
* common/asshelp.c (lock_spawning) [W32]: Change the names of the spawn
sentinels.
* agent/command.c (cmd_import_key): Use asprintf to create the prompt.
2013-11-18 14:09:47 +01:00
ea41f5b4c1
Fix faulty gcc warnings
2011-03-03 12:40:54 +01:00
b008274afd
Nuked almost all trailing white space.
...
We better do this once and for all instead of cluttering all future
commits with diffs of trailing white spaces. In the majority of cases
blank or single lines are affected and thus this change won't disturb
a git blame too much. For future commits the pre-commit scripts
checks that this won't happen again.
2011-02-04 12:57:53 +01:00
bbe388b5db
Add unfinished gpgtar.
...
Collected changes and ports of bug fixes from stable.
2010-06-07 13:33:02 +00:00
fb2ba98963
Finished the bulk of changes to use estream in most places instead of
...
stdio.
2010-03-15 11:15:45 +00:00
55ba204bfa
Started to implement the audit log feature.
...
Pass PINENTRY_USER_DATA and XAUTHORITY to Pinentry.
Improved support for the quality bar.
Minor internal restructuring.
Translation fixes.
2007-11-19 16:03:50 +00:00
cd2d9288aa
Ported changes from 1.4.
...
Add copyright notices.
2007-10-25 09:06:21 +00:00
93d3811abc
Changed to GPLv3.
...
Removed intl/.
2007-07-04 19:49:40 +00:00
0173cd5a98
Fixes for CVE-2006-6235
2006-12-06 10:16:50 +00:00
4b48bcacc9
Fix for bug 537
2006-10-02 11:54:35 +00:00
fbe4ac37f6
g10/ does build again.
2006-05-23 16:19:43 +00:00
00ffc478de
Merged recent changes from 1.4
2006-04-28 14:31:29 +00:00
29b23dea97
Merged with gpg 1.4.3 code.
...
The gpg part does not yet build.
2006-04-19 11:26:11 +00:00
4c66e94ff9
Merged most of David Shaw's changes in 1.3 since 2003-06-03.
2003-09-23 17:48:33 +00:00
c0c2c58054
Finished the bulk of changes for gnupg 1.9. This included switching
...
to libgcrypt functions, using shared error codes from libgpg-error,
replacing the old functions we used to have in ../util by those in
../jnlib and ../common, renaming the malloc functions and a couple of
types. Note, that not all changes are listed below becuause they are
too similar and done at far too many places. As of today the code
builds using the current libgcrypt from CVS but it is very unlikely
that it actually works.
2003-06-18 19:56:13 +00:00
7250331472
This commit was manufactured by cvs2svn to create branch
...
'GNUPG-1-9-BRANCH'.
2003-06-05 07:14:21 +00:00
82a17c9fb3
This commit was manufactured by cvs2svn to create branch
...
'GNUPG-1-9-BRANCH'.
2002-10-19 07:55:27 +00:00
3f51f7db3d
Update head to match stable 1.0
2002-06-29 13:46:34 +00:00
92cd255508
See ChangeLog: Fri Jul 14 19:38:23 CEST 2000 Werner Koch
2000-07-14 17:34:53 +00:00
baa30ad117
See ChangeLog: Thu Jan 27 18:00:44 CET 2000 Werner Koch
2000-01-27 16:50:45 +00:00
0070faa0ff
See ChangeLog: Mon Jan 24 13:04:28 CET 2000 Werner Koch
2000-01-24 11:55:49 +00:00
ed0b0e09d3
See ChangeLog: Fri Dec 31 12:48:31 CET 1999 Werner Koch
1999-12-31 11:44:29 +00:00
4555c0be94
See ChangeLog: Wed Dec 8 21:58:32 CET 1999 Werner Koch
1999-12-08 21:03:03 +00:00
2694bceb45
See ChangeLog: Fri Nov 19 17:15:20 CET 1999 Werner Koch
1999-11-19 16:11:37 +00:00
77d6309e21
See ChangeLog: Thu May 20 14:04:08 CEST 1999 Werner Koch
1999-05-20 12:11:41 +00:00
88d44edc56
./BUGS
1999-04-05 20:11:52 +00:00
e5521243bc
See ChangeLog: Sat Mar 20 13:59:47 CET 1999 Werner Koch
1999-03-20 13:01:11 +00:00
8d255ff264
See ChangeLog: Wed Mar 17 13:09:03 CET 1999 Werner Koch
1999-03-17 12:13:04 +00:00
c27c7416d5
See ChangeLog: Tue Mar 2 10:38:42 CET 1999 Werner Koch
1999-03-02 09:41:49 +00:00
694099b9af
See ChangeLog: Fri Feb 26 17:55:41 CET 1999 Werner Koch
1999-02-26 16:59:48 +00:00
a4ff45f634
See ChangeLog: Fri Feb 19 15:49:15 CET 1999 Werner Koch
1999-02-19 14:54:00 +00:00
e1a1b3fc90
See ChangeLog: Tue Feb 16 14:10:02 CET 1999 Werner Koch
1999-02-16 13:16:33 +00:00
9a4f506a18
See ChangeLog: Wed Feb 10 17:15:39 CET 1999 Werner Koch
1999-02-10 16:22:40 +00:00
NIIBE Yutaka