MeiliSearch/.github/ISSUE_TEMPLATE/sprint_issue.md
2024-04-05 18:40:28 +02:00

2.5 KiB

name about title labels assignees
New sprint issue ⚠️ Should only be used by the engine team ⚠️ missing usage in PRD, impacts docs

Related product team resources: PRD (internal only) Related product discussion:

Motivation

Usage

TODO

Reminders when modifying the Setting API

  • Ensure the new setting route is at least tested by the test_setting_routes macro
  • Ensure Analytics are fully implemented
  • Ensure the dump serializing is consistent with the /settings route serializing, e.g., enums case can be different (camelCase in route and PascalCase in the dump)

Special cases when adding a setting for an experimental feature

  • ⚠️ API stability: The setting does not appear on the main settings route when the feature has never been enabled (e.g. mark it Unset when returned from the index in this situation. See an example)
  • The setting cannot be set when the feature is disabled, either by the main settings route or the subroute (see validate_settings function)
  • If possible, the setting is reset when the feature is disabled (hard if it requires reindexing)

Impacted teams