27 Commits

Author	SHA1	Message	Date
Tamo	2af9481804	Implements the experimental contains filter operator«	2024-07-17 11:13:37 +02:00
redistay	182cb42953	chore: fix some typos in conments ... Signed-off-by: redistay <wujunjing@outlook.com>	2024-04-02 19:37:55 +08:00
Clément Renault	0dbf1a16ff	Make clippy happy	2023-11-23 14:11:38 +01:00
Kerollmops	03d0f628bd	Use the unescaper crate to unescape any char sequence	2023-09-06 13:59:45 +02:00
Kerollmops	ea78060916	Fix tests that were supposed to escape characters	2023-09-06 13:59:45 +02:00
bors[bot]	414b3fae89	Merge #3571 ... 3571: Introduce two filters to select documents with `null` and empty fields r=irevoire a=Kerollmops # Pull Request ## Related issue This PR implements the `X IS NULL`, `X IS NOT NULL`, `X IS EMPTY`, `X IS NOT EMPTY` filters that [this comment](https://github.com/meilisearch/product/discussions/539#discussioncomment-5115884) is describing in a very detailed manner. ## What does this PR do? ### `IS NULL` and `IS NOT NULL` This PR will be exposed as a prototype for now. Below is the copy/pasted version of a spec that defines this filter. - `IS NULL` matches fields that `EXISTS` AND `= IS NULL` - `IS NOT NULL` matches fields that `NOT EXISTS` OR `!= IS NULL` 1. `{"name": "A", "price": null}` 2. `{"name": "A", "price": 10}` 3. `{"name": "A"}` `price IS NULL` would match 1 `price IS NOT NULL` or `NOT price IS NULL` would match 2,3 `price EXISTS` would match 1, 2 `price NOT EXISTS` or `NOT price EXISTS` would match 3 common query : `(price EXISTS) AND (price IS NOT NULL)` would match 2 ### `IS EMPTY` and `IS NOT EMPTY` - `IS EMPTY` matches Array `[]`, Object `{}`, or String `""` fields that `EXISTS` and are empty - `IS NOT EMPTY` matches fields that `NOT EXISTS` OR are not empty. 1. `{"name": "A", "tags": null}` 2. `{"name": "A", "tags": [null]}` 3. `{"name": "A", "tags": []}` 4. `{"name": "A", "tags": ["hello","world"]}` 5. `{"name": "A", "tags": [""]}` 6. `{"name": "A"}` 7. `{"name": "A", "tags": {}}` 8. `{"name": "A", "tags": {"t1":"v1"}}` 9. `{"name": "A", "tags": {"t1":""}}` 10. `{"name": "A", "tags": ""}` `tags IS EMPTY` would match 3,7,10 `tags IS NOT EMPTY` or `NOT tags IS EMPTY` would match 1,2,4,5,6,8,9 `tags IS NULL` would match 1 `tags IS NOT NULL` or `NOT tags IS NULL` would match 2,3,4,5,6,7,8,9,10 `tags EXISTS` would match 1,2,3,4,5,7,8,9,10 `tags NOT EXISTS` or `NOT tags EXISTS` would match 6 common query : `(tags EXISTS) AND (tags IS NOT NULL) AND (tags IS NOT EMPTY)` would match 2,4,5,8,9 ## What should the reviewer do? - Check that I tested the filters - Check that I deleted the ids of the documents when deleting documents Co-authored-by: Clément Renault <clement@meilisearch.com> Co-authored-by: Kerollmops <clement@meilisearch.com>	2023-04-27 13:14:00 +00:00
Filip Bachul	77cf5b3787	handle _geoDistance(x,y,z) filter error	2023-04-03 20:18:26 +02:00
Filip Bachul	3acc5bbb15	handle _geo(x,y,z) filter error	2023-04-03 20:18:26 +02:00
Clément Renault	ea016d97af	Implementing an IS EMPTY filter	2023-03-15 14:12:34 +01:00
Clément Renault	030263caa3	Change the IS NULL filter syntax to use the IS keyword	2023-03-14 10:31:04 +01:00
Kerollmops	c25779afba	Specify that the NULL keyword is a keyword too	2023-03-13 17:40:34 +01:00
Guillaume Mourier	2d66fdc8e9	Apply review comments	2023-02-02 12:34:51 +01:00
Guillaume Mourier	b297b5deb0	cargo fmt	2023-02-02 12:34:49 +01:00
Guillaume Mourier	b078477d80	Add error handling and earth lap collision with bounding box	2023-02-02 12:17:38 +01:00
unvalley	c7322f704c	Fix cargo clippy errors ... Dont apply clippy for tests for now Fix clippy warnings of filter-parser package parent 8352febd646ec4bcf56a44161e5c4dce0e55111f author unvalley <38400669+unvalley@users.noreply.github.com> 1666325847 +0900 committer unvalley <kirohi.code@gmail.com> 1666791316 +0900 Update .github/workflows/rust.yml Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> Allow clippy lint too_many_argments Allow clippy lint needless_collect Allow clippy lint too_many_arguments and type_complexity Fix for clippy warnings comparison_chains Fix for clippy warnings vec_init_then_push Allow clippy lint should_implement_trait Allow clippy lint drop_non_drop Fix lifetime clipy warnings in filter-paprser Execute cargo fmt Fix clippy remaining warnings Fix clippy remaining warnings again and allow lint on each place	2022-10-27 01:04:23 +09:00
Loïc Lecrenier	497f9817a2	Use snapshot testing for the filter parser	2022-08-17 17:35:01 +02:00
Loïc Lecrenier	238a7be58d	Fix filter parser handling of keywords and surrounding spaces ... Now the following fragments are allowed: AND(field = AND'field' = AND"field" =	2022-08-17 16:53:40 +02:00
Loïc Lecrenier	b09a8f1b91	Filters: add explicit error message when using a keyword as value	2022-08-17 16:07:00 +02:00
Loïc Lecrenier	4ecfb95d0c	Improve syntax errors for IN filter	2022-08-17 12:28:33 +02:00
Loïc Lecrenier	ea0642c32d	Make filter parser more strict regarding spacing around operators ... OR, AND, NOT, TO must now be followed by spaces	2022-07-19 10:07:33 +02:00
Loïc Lecrenier	a5c9162250	Improve parser for NOT EXISTS filter ... Allow multiple spaces between NOT and EXISTS	2022-07-19 10:07:33 +02:00
Tamo	0fcde35a20	Update filter-parser/src/value.rs ... Co-authored-by: Clément Renault <clement@meilisearch.com>	2022-01-10 15:53:44 +01:00
Tamo	3c7ea1d298	Apply code suggestions ... Co-authored-by: Clément Renault <clement@meilisearch.com>	2022-01-10 15:19:21 +01:00
Tamo	02a21fd309	Handle the escapes of quote in the filters	2022-01-04 04:04:10 +01:00
Irevoire	7c3017734a	re-ignore the ! symbol when generating a good error message	2021-11-09 17:08:04 +01:00
Irevoire	519d6b2bf3	remove the ! syntax for the not	2021-11-09 16:47:54 +01:00
Tamo	f28600031d	Rename the filter_parser crate into filter-parser ... Co-authored-by: Clément Renault <clement@meilisearch.com>	2021-11-09 16:41:10 +01:00