Turn to references

This commit is contained in:
Mubelotix 2025-06-26 12:11:43 +02:00
parent 29f6eeff8f
commit 0f6dd133b2
No known key found for this signature in database
GPG Key ID: 0406DF6C3A69B942
4 changed files with 9 additions and 9 deletions

View File

@ -579,7 +579,7 @@ fn import_dump(
}, },
|indexing_step| tracing::trace!("update: {:?}", indexing_step), |indexing_step| tracing::trace!("update: {:?}", indexing_step),
|| false, || false,
embedder_stats, &embedder_stats,
)?; )?;
let builder = builder.with_embedders(embedders); let builder = builder.with_embedders(embedders);

View File

@ -50,7 +50,7 @@ pub(crate) fn data_from_obkv_documents(
settings_diff: Arc<InnerIndexSettingsDiff>, settings_diff: Arc<InnerIndexSettingsDiff>,
max_positions_per_attributes: Option<u32>, max_positions_per_attributes: Option<u32>,
possible_embedding_mistakes: Arc<PossibleEmbeddingMistakes>, possible_embedding_mistakes: Arc<PossibleEmbeddingMistakes>,
embedder_stats: Arc<EmbedderStats>, // Cant change embedder_stats: &Arc<EmbedderStats>,
) -> Result<()> { ) -> Result<()> {
let (original_pipeline_result, flattened_pipeline_result): (Result<_>, Result<_>) = rayon::join( let (original_pipeline_result, flattened_pipeline_result): (Result<_>, Result<_>) = rayon::join(
|| { || {
@ -234,7 +234,7 @@ fn send_original_documents_data(
embedders_configs: Arc<Vec<IndexEmbeddingConfig>>, embedders_configs: Arc<Vec<IndexEmbeddingConfig>>,
settings_diff: Arc<InnerIndexSettingsDiff>, settings_diff: Arc<InnerIndexSettingsDiff>,
possible_embedding_mistakes: Arc<PossibleEmbeddingMistakes>, possible_embedding_mistakes: Arc<PossibleEmbeddingMistakes>,
embedder_stats: Arc<EmbedderStats>, // Cant change embedder_stats: Arc<EmbedderStats>,
) -> Result<()> { ) -> Result<()> {
let original_documents_chunk = let original_documents_chunk =
original_documents_chunk.and_then(|c| unsafe { as_cloneable_grenad(&c) })?; original_documents_chunk.and_then(|c| unsafe { as_cloneable_grenad(&c) })?;

View File

@ -81,7 +81,7 @@ pub struct IndexDocuments<'t, 'i, 'a, FP, FA> {
added_documents: u64, added_documents: u64,
deleted_documents: u64, deleted_documents: u64,
embedders: EmbeddingConfigs, embedders: EmbeddingConfigs,
embedder_stats: Arc<EmbedderStats>, // Cant change embedder_stats: &'t Arc<EmbedderStats>,
} }
#[derive(Default, Debug, Clone)] #[derive(Default, Debug, Clone)]
@ -104,7 +104,7 @@ where
config: IndexDocumentsConfig, config: IndexDocumentsConfig,
progress: FP, progress: FP,
should_abort: FA, should_abort: FA,
embedder_stats: Arc<EmbedderStats>, // Cant change embedder_stats: &'t Arc<EmbedderStats>,
) -> Result<IndexDocuments<'t, 'i, 'a, FP, FA>> { ) -> Result<IndexDocuments<'t, 'i, 'a, FP, FA>> {
let transform = Some(Transform::new( let transform = Some(Transform::new(
wtxn, wtxn,
@ -331,7 +331,7 @@ where
settings_diff_cloned, settings_diff_cloned,
max_positions_per_attributes, max_positions_per_attributes,
Arc::new(possible_embedding_mistakes), Arc::new(possible_embedding_mistakes),
embedder_stats.clone() &embedder_stats
) )
}); });

View File

@ -475,7 +475,7 @@ impl<'a, 't, 'i> Settings<'a, 't, 'i> {
progress_callback: &FP, progress_callback: &FP,
should_abort: &FA, should_abort: &FA,
settings_diff: InnerIndexSettingsDiff, settings_diff: InnerIndexSettingsDiff,
embedder_stats: Arc<EmbedderStats>, // Cant change embedder_stats: &Arc<EmbedderStats>, // Cant change
) -> Result<()> ) -> Result<()>
where where
FP: Fn(UpdateIndexingStep) + Sync, FP: Fn(UpdateIndexingStep) + Sync,
@ -507,7 +507,7 @@ impl<'a, 't, 'i> Settings<'a, 't, 'i> {
IndexDocumentsConfig::default(), IndexDocumentsConfig::default(),
&progress_callback, &progress_callback,
&should_abort, &should_abort,
embedder_stats, &embedder_stats,
)?; )?;
indexing_builder.execute_raw(output)?; indexing_builder.execute_raw(output)?;
@ -1421,7 +1421,7 @@ impl<'a, 't, 'i> Settings<'a, 't, 'i> {
); );
if inner_settings_diff.any_reindexing_needed() { if inner_settings_diff.any_reindexing_needed() {
self.reindex(&progress_callback, &should_abort, inner_settings_diff, embedder_stats)?; self.reindex(&progress_callback, &should_abort, inner_settings_diff, &embedder_stats)?;
} }
Ok(()) Ok(())