diff --git a/crates/meilisearch/src/lib.rs b/crates/meilisearch/src/lib.rs index 5acfb4bc9..c902f4e60 100644 --- a/crates/meilisearch/src/lib.rs +++ b/crates/meilisearch/src/lib.rs @@ -579,7 +579,7 @@ fn import_dump( }, |indexing_step| tracing::trace!("update: {:?}", indexing_step), || false, - embedder_stats, + &embedder_stats, )?; let builder = builder.with_embedders(embedders); diff --git a/crates/milli/src/update/index_documents/extract/mod.rs b/crates/milli/src/update/index_documents/extract/mod.rs index 3af665c67..9c1971356 100644 --- a/crates/milli/src/update/index_documents/extract/mod.rs +++ b/crates/milli/src/update/index_documents/extract/mod.rs @@ -50,7 +50,7 @@ pub(crate) fn data_from_obkv_documents( settings_diff: Arc, max_positions_per_attributes: Option, possible_embedding_mistakes: Arc, - embedder_stats: Arc, // Cant change + embedder_stats: &Arc, ) -> Result<()> { let (original_pipeline_result, flattened_pipeline_result): (Result<_>, Result<_>) = rayon::join( || { @@ -234,7 +234,7 @@ fn send_original_documents_data( embedders_configs: Arc>, settings_diff: Arc, possible_embedding_mistakes: Arc, - embedder_stats: Arc, // Cant change + embedder_stats: Arc, ) -> Result<()> { let original_documents_chunk = original_documents_chunk.and_then(|c| unsafe { as_cloneable_grenad(&c) })?; diff --git a/crates/milli/src/update/index_documents/mod.rs b/crates/milli/src/update/index_documents/mod.rs index 2bddf1b17..6e56ad155 100644 --- a/crates/milli/src/update/index_documents/mod.rs +++ b/crates/milli/src/update/index_documents/mod.rs @@ -81,7 +81,7 @@ pub struct IndexDocuments<'t, 'i, 'a, FP, FA> { added_documents: u64, deleted_documents: u64, embedders: EmbeddingConfigs, - embedder_stats: Arc, // Cant change + embedder_stats: &'t Arc, } #[derive(Default, Debug, Clone)] @@ -104,7 +104,7 @@ where config: IndexDocumentsConfig, progress: FP, should_abort: FA, - embedder_stats: Arc, // Cant change + embedder_stats: &'t Arc, ) -> Result> { let transform = Some(Transform::new( wtxn, @@ -331,7 +331,7 @@ where settings_diff_cloned, max_positions_per_attributes, Arc::new(possible_embedding_mistakes), - embedder_stats.clone() + &embedder_stats ) }); diff --git a/crates/milli/src/update/settings.rs b/crates/milli/src/update/settings.rs index 71cedf456..06c2d0cc2 100644 --- a/crates/milli/src/update/settings.rs +++ b/crates/milli/src/update/settings.rs @@ -475,7 +475,7 @@ impl<'a, 't, 'i> Settings<'a, 't, 'i> { progress_callback: &FP, should_abort: &FA, settings_diff: InnerIndexSettingsDiff, - embedder_stats: Arc, // Cant change + embedder_stats: &Arc, // Cant change ) -> Result<()> where FP: Fn(UpdateIndexingStep) + Sync, @@ -507,7 +507,7 @@ impl<'a, 't, 'i> Settings<'a, 't, 'i> { IndexDocumentsConfig::default(), &progress_callback, &should_abort, - embedder_stats, + &embedder_stats, )?; indexing_builder.execute_raw(output)?; @@ -1421,7 +1421,7 @@ impl<'a, 't, 'i> Settings<'a, 't, 'i> { ); if inner_settings_diff.any_reindexing_needed() { - self.reindex(&progress_callback, &should_abort, inner_settings_diff, embedder_stats)?; + self.reindex(&progress_callback, &should_abort, inner_settings_diff, &embedder_stats)?; } Ok(())