security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00
Code Activity
gnupg/g10
History
Werner Koch 983f7b2acb
gpg: Fix out-of-bound read in subpacket enumeration 
* g10/parse-packet.c (enum_sig_subpkt): Check buflen before reading
the type octet.  Print diagnostic.
--

If the final subpacket has only a length header evaluating to zero and
missing the type octet, a read could happen right behind the buffer.
Valgrind detected this.  Fix is obvious.  Note that the further
parsing of the subpacket is still okay because it always checks the
length.  Note further that --list-packets uses a different code path
and already reported an error.

Reported-by: Philippe Antoine

He provided a test file copied below.  Running "gpg -v --verify" on it
triggered the bug.

-----BEGIN PGP ARMORED FILE-----
Comment: Use "gpg --dearmor" for unpacking

kA0DAAoBov87N383R0QBrQJhYgZsb2wucHlaqTVWYnl0ZXMgPSBbMHg1LCAweDY0
LCAweDRjLCAweGM0LCAweDMsIDB4MCwgMHg0LCAweDAsIDB4YWMsIDB4YSwgMHhj
MSwgMHhjMSwgMHgyLCAweDEsIDB4MiwgMHg3LCAweDQwLCAweDIsIDB4MiwgMHgy
LCAweDIsIDB4MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAweDJkLCAweGRkLCAweDIs
IDB4MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAweDIsIDB4
MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAweDIsIDB4NzcsIDB4ODcsIDB4MiwgMHgy
LCAweDIsIDB4MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAw
eDIsIDB4MiwgMHgyLCAweDIsIDB4MiwgMHg3NywgMHg4NywgMHgyLCAweDIsIDB4
MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAweDIsIDB4MiwgMHgyLCAweDIsIDB4Miwg
MHgyLCAweDIsIDB4MiwgMHgyLCAweDc3LCAweDg3LCAweDIsIDB4MiwgMHgyLCAw
eDIsIDB4MiwgMHgyLCAweDIsIDB4MCwgMHhhZF0KCmZvciBpIGluIHJhbmdlKGxl
bihieXRlcykpOgogICAgaWYgaSUxNiA9PSAwOgogICAgICAgIHByaW50CiAgICAg
ICAgcHJpbnQgIiUwNngiICUgaSwKICAgIHByaW50ICIlMDJ4ICIgJSBieXRlc1tp
XSwKiQJNBAABCgAeFiEEU+Y3aLjDLA3x+9Epov87N383R0QFAlqpNVYAAAoJEKL/
Ozd/N0dElccP/jBAcFHyeMl7kop71Q7/5NPu3DNULmdUzOZPle8PVjNURT4PSELF
qpJ8bd9PAsO4ZkUGwssY4Kfb1iG5cR/a8ADknNd0Cj9/QA2KMVNmgYtReuttAjvn
hQRm2VY0tvDCVAPI/z8OnV/NpOcbk8kSwE+shLsP7EwqL5MJNMXKqzm1uRxGNYxr
8TNuECo3DO64O2NZLkMDXqq6lg+lSxvDtXKxzKXgVC+GMtOE56lDwxWLqr39f9Ae
Pn0q2fVBKhJfpUODeEbYSYUp2hhmMUIJL/ths9MvyRZ9Z/bHCseFPT58Pgx6g+MP
q+iHnVZEIVb38XG+rTYW9hvctkRZP/azhpa7eO8JAZuFNeBGr4IGapwzFPvQSF4B
wBXBu0+PPrV9VJVe98P4nw2xcuJmkn6mgZhRVYSqDIhY64bSTgQxb/pdtGwrTjtL
WoUKVI+joLRPnDmwexH9+QJCB+uA6RsN/LqsQfDseyr40Z6dHJRqWGgP3ll6iZgw
WF768uiIDJD8d4fegVnkpcH98Hm0I/dKsMR1MGV/sBxYC8mAOcOWwSPNGDqPlwwR
eWPdr1O6CoYEWwiZMicSe0b5TsjB5nkAWMy7c9RyhtMJzCQ/hFpycpj0A0Zs+OGa
eJQMZZV0s8AQZ04JzoX0zRpe0RcTyJn3Tr6QGbVi9tr+QdKHFuDMUqoX
=qYZP
-----END PGP ARMORED FILE-----

Signed-off-by: Werner Koch <wk@gnupg.org>
2018-03-21 19:43:33 +01:00
..
all-tests.scm
tests: Make it possible to run all tests using our infrastructure.
2017-05-11 18:12:37 +02:00
armor.c
g10, sm, dirmngr, common: Add comment for fall through.
2017-05-10 11:13:12 +09:00
build-packet.c
doc: Comment fixes and one trailing comma fix.
2017-07-20 18:13:40 +02:00
call-agent.c
gpg: Fix regression in last --card-status patch
2018-03-01 19:10:10 +01:00
call-agent.h
gpg: Print the keygrip with --card-status
2018-03-01 19:03:23 +01:00
call-dirmngr.c
gpg: Add option '--disable-dirmngr'.
2017-08-08 11:43:22 +02:00
call-dirmngr.h
gpg: Store key origin info for new DANE and WKD retrieved keys.
2017-07-24 20:09:52 +02:00
card-util.c
scd: Better user interaction for factory-reset.
2018-03-16 11:27:33 +09:00
ChangeLog-2011
Spelling: correct spelling of "passphrase".
2016-11-02 12:53:58 +01:00
cipher.c
gpg: Print a warning for too much data encrypted with 3DES et al.
2017-12-13 13:02:34 +01:00
compress-bz2.c
g10,tools: Fix bzlib.h include order.
2017-04-11 13:52:19 +09:00
compress.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
cpr.c
gpg: Fix memory leaking for long inputs via --command-fd.
2017-11-22 20:54:47 +01:00
dearmor.c
Revert "g10: Always save standard revocation certificate in file."
2017-08-01 19:08:16 +02:00
decrypt-data.c
gpg,sm: String changes for compliance diagnostics.
2017-07-28 17:46:43 +02:00
decrypt.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
dek.h
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
delkey.c
gpg: Pass CTRL to many more functions.
2017-03-31 20:07:20 +02:00
distsigkey.gpg
build: Update distsigkey.gpg
2017-11-22 20:54:47 +01:00
ecdh.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
encrypt.c
Revert "g10: Always save standard revocation certificate in file."
2017-08-01 19:08:16 +02:00
exec.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
exec.h
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
export.c
gpg: Return an error from hexfingerprint on malloc error.
2017-12-13 10:52:34 +01:00
filter.h
gpg: Print a warning for too much data encrypted with 3DES et al.
2017-12-13 13:02:34 +01:00
free-packet.c
gpg: Fix possible double free of the card serialno.
2017-07-21 17:49:10 +02:00
getkey.c
g10: Select a secret key by checking availability under gpg-agent.
2018-02-22 10:42:42 +01:00
gpg-w32info.rc
w32: Add manifest to gpg.
2015-02-04 09:15:34 +01:00
gpg.c
gpgconf: Swap "auto-key-retrieve" and "no-auto-key-retrieve".
2017-08-23 16:45:20 +02:00
gpg.h
gpg: Fix build on Windows.
2018-03-08 14:08:51 +09:00
gpg.w32-manifest.in
w32: Add manifest to gpg.
2015-02-04 09:15:34 +01:00
gpgcompose.c
gpg: Avoid output to the tty during import.
2017-07-27 11:38:57 +02:00
gpgsql.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
gpgsql.h
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
gpgv.c
gpgv: Initialize compliance checker.
2017-09-13 09:18:15 +02:00
helptext.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
import.c
gpg: Print sec/sbb with --import-option import-show or show-only.
2017-10-19 17:12:36 +02:00
kbnode.c
gpg: Extend free_packet to handle a packet parser context.
2017-03-29 12:08:31 +02:00
key-check.c
gpg: Avoid superfluous sig check info during import.
2017-10-24 21:11:38 +02:00
key-check.h
gpg: Avoid output to the tty during import.
2017-07-27 11:38:57 +02:00
keydb.c
gpg: Don't let gpg return failure on an invalid packet in a keyblock.
2018-02-22 14:23:01 +01:00
keydb.h
gpg: Keep a lock during the read-update/insert cycle in import.
2017-10-19 15:02:28 +02:00
keyedit.c
gpg: Fix reversed messages for --only-sign-text-ids.
2018-02-15 14:22:06 +09:00
keyedit.h
gpg: Avoid output to the tty during import.
2017-07-27 11:38:57 +02:00
keygen.c
gpg: Fix the use of future-default with --quick-add-key.
2018-01-18 13:39:19 +01:00
keyid.c
gpg: Return an error from hexfingerprint on malloc error.
2017-12-13 10:52:34 +01:00
keylist.c
gpg: Avoid output to the tty during import.
2017-07-27 11:38:57 +02:00
keyring.c
gpg: Don't let gpg return failure on an invalid packet in a keyblock.
2018-02-22 14:23:01 +01:00
keyring.h
gpg: Pass CTRL to many more functions.
2017-03-31 20:07:20 +02:00
keyserver-internal.h
gpg: Pass key origin values to import functions.
2017-07-13 18:29:01 +02:00
keyserver.c
gpg: Extend --key-origin to take an optional URL arg.
2017-07-24 21:10:58 +02:00
main.h
gpg: Simplify keydb handling of the main import function.
2017-10-19 15:00:05 +02:00
mainproc.c
gpg: Print all keys with --decrypt --list-only.
2018-01-08 09:30:31 +01:00
Makefile.am
tofu: Compare squares instead of square roots.
2017-07-10 18:09:42 +02:00
mdfilter.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
migrate.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
misc.c
gpg: Fix build on Windows.
2018-03-08 14:08:51 +09:00
openfile.c
Revert "g10: Always save standard revocation certificate in file."
2017-08-01 19:08:16 +02:00
options.h
gpg: Add option '--disable-dirmngr'.
2017-08-08 11:43:22 +02:00
packet.h
doc: Comment fixes and one trailing comma fix.
2017-07-20 18:13:40 +02:00
parse-packet.c
gpg: Fix out-of-bound read in subpacket enumeration
2018-03-21 19:43:33 +01:00
passphrase.c
gpg: Pass CTRL to many more functions.
2017-03-31 20:07:20 +02:00
photoid.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
photoid.h
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
pkclist.c
gpg: Simplify default_recipient().
2017-12-13 11:03:06 +01:00
pkglue.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
pkglue.h
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
plaintext.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
progress.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
pubkey-enc.c
gpg,sm: Error out on compliance mismatch while decrypting.
2017-08-01 08:41:47 +02:00
pubring.asc
Update copyright notices for 2017.
2017-01-23 19:16:55 +01:00
revoke.c
gpg: Return an error from hexfingerprint on malloc error.
2017-12-13 10:52:34 +01:00
rmd160.c
Clean up word replication.
2017-02-21 13:11:46 -05:00
rmd160.h
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
seckey-cert.c
More change for common.
2017-03-07 20:32:09 +09:00
server.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
seskey.c
Spelling fixes in docs and comments.
2017-04-28 10:06:33 +09:00
sig-check.c
gpg: Fix memory leak in sig-check.
2017-08-24 20:26:19 +02:00
sign.c
Revert "g10: Always save standard revocation certificate in file."
2017-08-01 19:08:16 +02:00
skclist.c
g10: Fix default-key selection for signing, possibly by card.
2017-05-22 09:27:36 +09:00
t-keydb-get-keyblock.c
gpg: Fix actual leak and possible leaks in the packet parser.
2017-03-30 16:01:52 +02:00
t-keydb-get-keyblock.gpg
gpg: Correctly handle keyblocks followed by legacy keys.
2015-11-17 14:53:03 +01:00
t-keydb-keyring.kbx
g10: Add test for keydb as well as new testing infrastructure.
2015-09-02 15:08:57 +02:00
t-keydb.c
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
t-rmd160.c
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00
t-stutter-data.asc
gpg: Add a new test.
2016-03-08 14:08:49 +01:00
t-stutter.c
g10: Stop compiler warning for t-stutter.
2017-05-10 11:13:03 +09:00
tdbdump.c
gpg: Pass CTRL to many more functions.
2017-03-31 20:07:20 +02:00
tdbio.c
Spelling fixes in docs and comments.
2017-04-28 10:06:33 +09:00
tdbio.h
gpg: Pass CTRL to many more functions.
2017-03-31 20:07:20 +02:00
test-stubs.c
gpg: Pass CTRL to many more functions.
2017-03-31 20:07:20 +02:00
test.c
tests: Locate resources and scripts relative to top source dir.
2017-04-24 14:14:05 +02:00
textfilter.c
Remove -I option to common.
2017-03-07 20:25:54 +09:00
tofu.c
gpg: Return an error from hexfingerprint on malloc error.
2017-12-13 10:52:34 +01:00
tofu.h
g10: Remove dead code.
2016-12-06 12:16:56 +01:00
trust.c
gpg: Workaround for junk after --trusted-key.
2017-09-28 14:10:12 +02:00
trustdb.c
g10: Fix regexp sanitization.
2017-12-04 19:26:49 +09:00
trustdb.h
gpg: Pass CTRL to many more functions.
2017-03-31 20:07:20 +02:00
verify.c
Spelling fixes in docs and comments.
2017-04-28 10:06:33 +09:00
zlib-riscos.h
Change all http://www.gnu.org in license notices to https://
2016-11-05 12:02:19 +01:00