security-and-privacy/gnupg
security-and-privacy
/
gnupg
mirror of git://git.gnupg.org/gnupg.git
1
0
Fork 0
Code Activity
gnupg/scd
History
NIIBE Yutaka 682da55aa9 fix wLangId in ccid-driver.c 
This is not a part of pin pad support series of mine.

As I found the bug while I am preparing the patches, I report this.

As CCID protocol is little endian, wLangId of US English = 0x0409
is represented as two bytes of 0x09 then 0x04.

It is really confusing that the code like following is floating
around:
	pin_verify -> wLangId = HOST_TO_CCID_16(0x0904);

But, it is 0x0409 (not 0x0904).  It is defined in the documentation:

    http://www.usb.org/developers/docs/USB_LANGIDs.pdf

and origin of this table is Microsoft.  We can see it at:

    http://msdn.microsoft.com/en-us/library/bb165625%28VS.80%29.aspx

Yes, it would be better not to hard-code 0x0409.  It would be better
to try current locale of the user, or to use the first entry of string
descriptor.  I don't have time to implement such a thing...
 		2011-03-02 16:52:27 +01:00
..
ChangeLog Lock scdaemon to CCID if once found. 2011-02-23 10:15:34 +01:00
Makefile.am Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
apdu.c Lock scdaemon to CCID if once found. 2011-02-23 10:15:34 +01:00
apdu.h Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app-common.h Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app-dinsig.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app-geldkarte.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app-help.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app-nks.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app-openpgp.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app-p15.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
app.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
atr.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
atr.h Changed to GPLv3. 2007-07-04 19:49:40 +00:00
card-common.h Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
card-dinsig.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
card-p15.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
card.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
ccid-driver.c fix wLangId in ccid-driver.c 2011-03-02 16:52:27 +01:00
ccid-driver.h Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
command.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
iso7816.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
iso7816.h Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
pcsc-wrapper.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
sc-copykeys.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
scdaemon.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
scdaemon.h Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00