security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-09-22 15:11:41 +02:00
Code Activity

gpg: default to --no-auto-key-retrieve.

Browse Source 
* g10/gpg.c (main): remove KEYSERVER_AUTO_KEY_RETRIEVE from the
default keyserver options.
* doc/gpg.texi: document this change.
--

This is a partial reversion of
7e1fe791d1.  Werner and i discussed it
earlier today, and came to the conclusion that:

 * the risk of metadata leakage represented by a default
   --auto-key-retrieve, both in e-mail (as a "web bug") and in other
   contexts where GnuPG is used to verified signatures, is quite high.

 * the advantages of --auto-key-retrieve (in terms of signature
   verification) can sometimes be achieved in other ways, such as when
   a signed message includes a copy of its own key.

 * when those other ways are not useful, a graphical, user-facing
   application can still offer the user the opportunity to choose to
   fetch the key; or it can apply its own policy about when to set
   --auto-key-retrieve, without needing to affect the defaults.

Note that --auto-key-retrieve is specifically about signature
verification.  Decisions about how and whether to look up a key during
message encryption are governed by --auto-key-locate.  This change
does not touch the --auto-key-locate default of "local,wkd".  The user
deliberately asking gpg to encrypt to an e-mail address is a different
scenario than having an incoming e-mail trigger a potentially unique
network request.

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
This commit is contained in:
Daniel Kahn Gillmor 2017-08-11 02:26:52 -04:00
parent 2d6832aa83
commit e6f84116ab
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/gpg.texi
View File

@ -1792,7 +1792,7 @@ list. The default is "local,wkd".
@opindex no-auto-key-retrieve @opindex no-auto-key-retrieve
These options enable or disable the automatic retrieving of keys from These options enable or disable the automatic retrieving of keys from
a keyserver when verifying signatures made by keys that are not on the a keyserver when verifying signatures made by keys that are not on the
local keyring. The default is @option{--auto-key-retrieve}. local keyring. The default is @option{--no-auto-key-retrieve}.
If the method "wkd" is included in the list of methods given to If the method "wkd" is included in the list of methods given to
@option{auto-key-locate}, the signer's user ID is part of the @option{auto-key-locate}, the signer's user ID is part of the

3
g10/gpg.c
View File

@ -2366,8 +2366,7 @@ main (int argc, char **argv)
opt.keyserver_options.import_options = (IMPORT_REPAIR_KEYS opt.keyserver_options.import_options = (IMPORT_REPAIR_KEYS
| IMPORT_REPAIR_PKS_SUBKEY_BUG); | IMPORT_REPAIR_PKS_SUBKEY_BUG);
opt.keyserver_options.export_options = EXPORT_ATTRIBUTES; opt.keyserver_options.export_options = EXPORT_ATTRIBUTES;
opt.keyserver_options.options = (KEYSERVER_HONOR_PKA_RECORD opt.keyserver_options.options = KEYSERVER_HONOR_PKA_RECORD;
| KEYSERVER_AUTO_KEY_RETRIEVE);
opt.verify_options = (LIST_SHOW_UID_VALIDITY opt.verify_options = (LIST_SHOW_UID_VALIDITY
| VERIFY_SHOW_POLICY_URLS | VERIFY_SHOW_POLICY_URLS
| VERIFY_SHOW_STD_NOTATIONS | VERIFY_SHOW_STD_NOTATIONS