MeiliSearch

mirror of https://github.com/meilisearch/MeiliSearch synced 2024-12-25 14:10:06 +01:00

History

meili-bors[bot] a616a1d37b

4389: Stabilize scoreDetails r=dureuill a=dureuill

# Pull Request

## Related issue
Fixes #4359

## What does this PR do?

### User standpoint

- Users no longer need to enable the `scoreDetails` experimental feature to use `showRankingScoreDetails` in search queries.
- ⚠️ **Breaking change**: sending an object containing the key `"scoreDetails"` to the `/experimental-features` route is now an error. However, importing a dump of a database where that feature was enabled completes successfully.

### Implementation standpoint
- remove `scoreDetails` from the experimental features
- remove check on the experimental feature `scoreDetails` before accepting `showRankingScoreDetails`
- remove `scoreDetails` from the accepted fields in the `/experimental-features` route
- fix tests accordingly

## Manual tests

1. exported a dump with the `scoreDetails` feature enabled on `main`
    - tried to import the dump after the changes in this PR
    - the dump imported successfully
2. tried to make a search with `showRankingScoreDetails: true`
    - the ranking score details are displayed
    - an automated test case also exists and passes
3. tried to enable the `scoreDetails` in `/experimental-features`
    - get error message 
      ```
       Unknown field `scoreDetails`: expected one of `vectorStore`, `metrics`, `exportPuffinReports`
      ```

Co-authored-by: Louis Dureuil <louis@meilisearch.com>

2024-02-08 10:40:00 +00:00

deserr

Deserialize semantic ratio

2023-12-14 16:08:42 +01:00

compression.rs

Compress the snapshot in a tarball

2022-10-27 11:35:15 +02:00

document_formats.rs

removed unnecessary borrow call

2023-08-10 08:41:25 +02:00

error.rs

Don't accept dimensions of 0 (ever) or dimensions greater than the default dimensions of the model