marin postma
74bb748a4e
bump milli to 0.6.0
2021-06-23 18:40:19 +02:00
bors[bot]
8638c9ab77
Merge #232
...
232: Fix payload size limit r=MarinPostma a=MarinPostma
Fix #223
This was due to the fact that Payload ignores the limit payload size limit. I fixed it by implementing my own `Payload` extractor that checks that the size of the payload is not too large.
I also refactored the `create_app` a bit.
Co-authored-by: marin postma <postma.marin@protonmail.com>
2021-06-23 16:06:08 +00:00
bors[bot]
b676b10cfe
Merge #238
...
238: Fix settings subroutes get r=MarinPostma a=MarinPostma
Fix #225
Co-authored-by: marin postma <postma.marin@protonmail.com>
2021-06-23 15:45:50 +00:00
marin postma
f68c257452
move flush in write_to_file function
2021-06-23 16:49:25 +02:00
marin postma
880fc069bd
remove dbg
2021-06-23 16:49:25 +02:00
marin postma
a838238a63
move payload to own module
2021-06-23 16:49:25 +02:00
marin postma
834995b130
clippy + fmt
2021-06-23 16:49:23 +02:00
marin postma
b000ae7614
remove file if write to update file fails
2021-06-23 16:48:33 +02:00
marin postma
f62779671b
change error message for payload size limit
2021-06-23 16:48:33 +02:00
marin postma
4b292c6e9b
add payload limit to app config
2021-06-23 16:48:33 +02:00
marin postma
1c13100948
implement custom payload
2021-06-23 16:48:31 +02:00
marin postma
71226feb74
refactor create_app macro
2021-06-23 16:47:15 +02:00
bors[bot]
3175f09989
Merge #235
...
235: Fix dump not found error r=MarinPostma a=MarinPostma
fix #233
Co-authored-by: marin postma <postma.marin@protonmail.com>
2021-06-23 14:21:07 +00:00
marin postma
322d6b8cfe
fix serialization bug in settings
2021-06-23 15:25:56 +02:00
marin postma
da36a6b5cd
fix not found error
2021-06-23 15:06:36 +02:00
bors[bot]
f2b2ca6d55
Merge #227
...
227: improve mini dashboard routing r=MarinPostma a=MarinPostma
The dependency we use to statically serve the mini-dashboard used globing to serve the mini-dashboard files. This caused all unfound routes to be caught by the "/" serving the dashboard assets. This fix makes it so that the assets have a dedicated route, and any unfound route is caught by the default service and return a 404.
Co-authored-by: marin postma <postma.marin@protonmail.com>
2021-06-23 13:01:40 +00:00
Clémentine Urquizar
ec3140a29e
Fix clippy
2021-06-23 11:23:57 +02:00
Clémentine Urquizar
00b0a00fc5
Add exhaustiveFacetsCount
2021-06-23 11:05:30 +02:00
Clémentine Urquizar
6d24a4744f
Roll back facetsDistribution
2021-06-23 10:04:01 +02:00
marin postma
b1a5ef0aab
improve mini dashboard routing
2021-06-22 21:49:05 +02:00
marin postma
3456a78552
refactor formatter
...
share the analyzer instance between the formatter and the
compute_matches function
2021-06-22 18:28:20 +02:00
marin postma
eb3d63691a
add tests
2021-06-22 18:12:53 +02:00
marin postma
c4ee937635
optimize fromat string
2021-06-22 18:12:53 +02:00
marin postma
f6d1fb7ac2
fmt
2021-06-22 18:12:53 +02:00
marin postma
97ef4a6c22
implement matches
2021-06-22 18:12:52 +02:00
bors[bot]
db7215eaa9
Merge #213
...
213: Implement all the CLI options r=MarinPostma a=irevoire
closes #206
And I looked into #204 , I fixed some default values and tried to test as many options as possible, and I think the cli is already mostly working.
If someone knows any issues about it, I would like to hear more 🙂
Co-authored-by: Tamo <tamo@meilisearch.com>
2021-06-22 15:04:05 +00:00
bors[bot]
4b37a4a415
Merge #211 #218
...
211: fix index deletion race condition r=MarinPostma a=MarinPostma
Make update store block if the currently processing update is from an index we are trying to delete. This ensure that no write to the index can occur after it has been deleted.
218: Update milli version to v0.5.0 r=MarinPostma a=curquiza
Co-authored-by: marin postma <postma.marin@protonmail.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-22 14:36:34 +00:00
marin postma
caa231aebe
fix race condition
2021-06-22 16:09:07 +02:00
marin postma
9cc31c2258
fix get search crop len
2021-06-22 16:01:40 +02:00
Clémentine Urquizar
2e3d85c31a
Update milli version to v0.5.0
2021-06-22 15:57:46 +02:00
bors[bot]
25af262e79
Merge #210
...
210: Error handling r=MarinPostma a=MarinPostma
This pr implements the error handling for meilisearch.
Rather than grouping errors by types, this implementation groups them by scope, each scope enclosing errors from a scope further down, or new errors within this scope. This makes the tracking of the origins of errors easier , and error handling easier at the module level.
All errors that are eventually returned to the user implement the `Into<ResponseError>` trait. `ReponseError` in turn implements the `ErrorCode` trait from `meilisearch-error`.
Some new errors have been introduced with the new engine for which we haven't defined error codes yet. It has been decided with @gmourier that those would return the `internal-error` code until the correct error code is specified.
Co-authored-by: marin postma <postma.marin@protonmail.com>
2021-06-22 13:21:33 +00:00
marin postma
d0ef1ef174
change errors codes
2021-06-22 11:58:01 +02:00
marin postma
9092d35a3c
fix payload error handler
2021-06-21 21:51:38 +02:00
marin postma
2bdaa70f31
invalid update payload returns bad_request
2021-06-21 18:56:22 +02:00
marin postma
f91a3bc6ab
set error content type to json
2021-06-21 18:48:05 +02:00
marin postma
1e4592dd7e
enable errors in updates
2021-06-21 18:42:47 +02:00
Tamo
76727455ca
ignore all the options related to the indexer
2021-06-21 18:13:00 +02:00
Tamo
2097554c09
fix the cli
2021-06-21 16:34:49 +02:00
marin postma
56686dee40
review changes
2021-06-21 13:57:32 +02:00
marin postma
763ee521be
fix rebase errors
2021-06-21 12:11:09 +02:00
marin postma
fa573dabf0
fmt
2021-06-21 12:11:09 +02:00
marin postma
abdf642d68
integrate milli errors
2021-06-21 12:11:08 +02:00
marin postma
0dfd1b74c8
fix tests
2021-06-21 12:11:08 +02:00
marin postma
0d3fb5ee0d
factorize internal error macro
2021-06-21 12:11:08 +02:00
marin postma
02277ec2cf
reintroduce anyhow
2021-06-21 12:11:06 +02:00
marin
8fc12b1526
Update meilisearch-http/src/index/search.rs
...
Co-authored-by: Clément Renault <clement@meilisearch.com>
2021-06-21 11:06:06 +02:00
marin postma
439db1aae0
enable response error for search routes
2021-06-21 11:00:14 +02:00
marin postma
8afbb9c462
enable response error for documents routes
2021-06-21 10:59:41 +02:00
marin postma
5c52a1393f
enable response error for settings routes
2021-06-21 10:59:41 +02:00
marin postma
112cd1787c
change error message for uuid resolver
2021-06-21 10:59:40 +02:00
marin postma
d1550670a8
enable response error for index routes
2021-06-21 10:59:40 +02:00
marin postma
58f9974be4
remove anyhow refs & implement missing errors
2021-06-21 10:59:38 +02:00
marin postma
3a2e7d3c3b
optimize cropping
2021-06-20 16:59:31 +02:00
bors[bot]
c1b6f0e833
Merge #183
...
183: Add cropping and update `_formatted` behavior r=curquiza a=MarinPostma
TODO:
- [x] Solves #5
- [x] Solves #203
- [x] integrate the new milli highlight (according to the query words)
Co-authored-by: Marin Postma <postma.marin@protonmail.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-18 11:18:37 +00:00
Clémentine Urquizar
5d8a21b0de
Fix clippy errors
2021-06-17 18:51:07 +02:00
Clémentine Urquizar
623b71e81e
Fix clippy errors
2021-06-17 18:02:25 +02:00
Clémentine Urquizar
c5c7e76805
Update meilisearch-http/src/index/search.rs
...
Co-authored-by: marin <postma.marin@protonmail.com>
2021-06-17 18:00:02 +02:00
Clémentine Urquizar
e4b3d35ed8
Fix clippy errors
2021-06-17 17:03:43 +02:00
Clémentine Urquizar
33e55bd82e
Refactor the crop
2021-06-17 16:59:01 +02:00
Clémentine Urquizar
9543ab4db6
Use mut instead of returning the hashmap
2021-06-17 13:51:27 +02:00
Clémentine Urquizar
97909ce56e
Use BTreeMap and remove ids_in_formatted
2021-06-16 19:30:06 +02:00
bors[bot]
2f2484e186
Merge #212
...
212: bump milli to 0.4.0 r=MarinPostma a=MarinPostma
Co-authored-by: marin postma <postma.marin@protonmail.com>
2021-06-16 15:42:34 +00:00
bors[bot]
2062b10b79
Merge #209
...
209: Integrate amplitude r=MarinPostma a=irevoire
And merge the sentry and amplitude usage under one “Enable analytics” flag
closes #180
Co-authored-by: Tamo <tamo@meilisearch.com>
Co-authored-by: Irevoire <tamo@meilisearch.com>
2021-06-16 15:25:31 +00:00
Clémentine Urquizar
a0b022afee
Add Cow
2021-06-16 17:25:02 +02:00
marin postma
5a47cef9a8
bump milli to 0.4.0
2021-06-16 17:15:56 +02:00
Clémentine Urquizar
9538790b33
Decompose into two functions
2021-06-16 17:13:21 +02:00
Tamo
4e2568fd6e
disable amplitude on debug build
2021-06-16 17:12:49 +02:00
Clémentine Urquizar
dc5a3d4a62
Use BTreeSet instead of HashSet
2021-06-16 16:20:10 +02:00
Clémentine Urquizar
7b02fdaddc
Rename functions
2021-06-16 14:23:08 +02:00
Irevoire
c0d169e79e
Apply suggestions from code review
...
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-16 11:12:46 +02:00
Clémentine Urquizar
9840b5c7fb
Refacto
2021-06-15 18:44:56 +02:00
Clémentine Urquizar
1ef061d92b
Fix clippy errors
2021-06-15 17:40:45 +02:00
Clémentine Urquizar
79a1212ebe
Do intersection with displayed ids instead of checking in loop
2021-06-15 17:40:45 +02:00
Clémentine Urquizar
8d0269fcc4
Create function to create fomatted_options
2021-06-15 17:40:45 +02:00
Clémentine Urquizar
5e656bb58a
Rename parse_facets into parse_filter
2021-06-15 17:40:45 +02:00
Clémentine Urquizar
d9c0190497
Redo to_retrieve_ids
2021-06-15 17:40:45 +02:00
Clémentine Urquizar
5dffe566fd
Remove useless comments
2021-06-15 17:40:45 +02:00
Clémentine Urquizar
b769877183
Make it compatible with the new milli highlighting
2021-06-15 17:40:44 +02:00
Clémentine Urquizar
446b66b0fe
Fix cargo clippy error
2021-06-15 17:40:44 +02:00
Clémentine Urquizar
d0ec081e49
Refacto
2021-06-15 17:40:44 +02:00
Clémentine Urquizar
65130d9ee7
Change crop_length type from Option(usize) to usize
2021-06-15 17:40:44 +02:00
Clémentine Urquizar
638009fb2b
Rename highlighter variable into formatter
2021-06-15 17:40:44 +02:00
Clémentine Urquizar
7f84f59472
Reorganize imports
2021-06-15 17:40:44 +02:00
Clémentine Urquizar
4f8c771bb5
Add new line
2021-06-15 17:40:43 +02:00
Clémentine Urquizar
9e69f33f3c
Fix clippy errors
2021-06-15 17:40:43 +02:00
Clémentine Urquizar
0da8fa115e
Add custom croplength for attributes to crop
2021-06-15 17:40:43 +02:00
Clémentine Urquizar
811bc2f421
Around to previous word
2021-06-15 17:40:43 +02:00
Clémentine Urquizar
caaf8d3f40
Fix tests
2021-06-15 17:40:43 +02:00
Marin Postma
7473cc6e27
implement crop around
2021-06-15 17:40:43 +02:00
Marin Postma
56c9633c53
simple crop before
2021-06-15 17:40:43 +02:00
Clémentine Urquizar
93002e734c
Fix tests
2021-06-15 17:40:42 +02:00
Clémentine Urquizar
60f6d1c373
First version of highlight after refacto
2021-06-15 17:40:42 +02:00
Clémentine Urquizar
a03d9d496e
Fix compilation errors
2021-06-15 17:40:42 +02:00
Marin Postma
7904637893
crop skeleton
2021-06-15 17:40:42 +02:00
Tamo
def1596eaf
Integrate amplitude
...
And merge the sentry and amplitude usage under one “Enable analytics”
flag
2021-06-15 15:36:30 +02:00
marin postma
a780cff8fd
fix clippy warning
2021-06-14 14:53:47 +02:00
Tamo
7cb2dcbdf8
add a comment
2021-06-14 14:47:53 +02:00
Tamo
f068d7f978
makes clippy happy
2021-06-14 14:47:53 +02:00
Tamo
18d4d6097a
implements the synonyms in transplant
2021-06-14 14:47:51 +02:00
bors[bot]
b119bb4ab0
Merge #197
...
197: Update milli (v0.3.1) with filterable attributes r=MarinPostma a=curquiza
Fixes #187 and #70
Also fixes #195
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
2021-06-14 12:19:42 +00:00
bors[bot]
d65b5db97f
Merge #144 #173
...
144: Concurrent update run loop (refactor) r=MarinPostma a=MarinPostma
This PR allows multiple request to the update store to be performed concurently (i.e, one can list updates while an updates in being written to the update store).
173: Convert UpdateStatus to legacy meilisearch format r=MarinPostma a=MarinPostma
Returns the update statuses with the same format as legacy meilisearch.
The number of documents in a document addition/deletion is not known before processing, so it is only returned when the update is `processed`.
close #78
associated milli PR: https://github.com/meilisearch/milli/pull/178
Co-authored-by: marin postma <postma.marin@protonmail.com>
Co-authored-by: Marin Postma <postma.marin@protonmail.com>
2021-06-14 11:30:44 +00:00
Clémentine Urquizar
d4be4d80db
Fix after rebase
2021-06-14 13:27:18 +02:00
Clémentine Urquizar
88bf867a3e
Rename attributes for faceting into filterable attributes
2021-06-14 13:20:43 +02:00
Clémentine Urquizar
aa04124bfc
Add changes according to milli update
2021-06-14 13:20:37 +02:00
Marin Postma
11c81ab4cb
fix tests
2021-06-14 11:17:49 +02:00
marin postma
0f767e3743
conccurrent update run loop
2021-06-14 10:57:14 +02:00
bors[bot]
1e659bb17b
Merge #194
...
194: Bump sentry version r=MarinPostma a=irevoire
closes #102
Co-authored-by: tamo <tamo@meilisearch.com>
2021-06-14 08:34:04 +00:00
Marin Postma
e8bd5ea4e0
convert UpdateStatus to legacy meilisearch format
2021-06-14 10:21:57 +02:00
bors[bot]
d765397c82
Merge #179
...
179: Enable filter paramater during search r=MarinPostma a=MarinPostma
This pr makes the necessary changes to transplant in accordance with the specification on filters.
More precisely, it:
- Removes the `filters` parameter
- Renames `facetFilters` to `filter`
- Allows either a string or an array to be passed to the filter param.
It doesn't allow the mixed syntax, that needs to be handled by milli.
close #81
close #140
Co-authored-by: Marin Postma <postma.marin@protonmail.com>
2021-06-14 08:11:30 +00:00
mpostma
3ef0830c5d
review changes
2021-06-10 16:11:52 +02:00
mpostma
eb7616ca0f
remove dbg
2021-06-10 16:03:48 +02:00
Irevoire
20e1caef47
makes clippy happy
2021-06-10 16:03:48 +02:00
Irevoire
99551fc21b
fix encoding bug
2021-06-10 16:03:48 +02:00
mpostma
2716c1aebb
fix update store lock
2021-06-09 16:19:45 +02:00
mpostma
1a65eed724
fix index creation bug
2021-06-09 11:52:36 +02:00
marin postma
75c0718691
fix update loop infinite loop
2021-06-02 17:29:50 +02:00
Tamo
2d7785ae0c
remove the dump_batch_size option from the CLI
2021-06-01 20:42:06 +02:00
Tamo
d0552e765e
forbid deserialization of Setting<Checked>
2021-06-01 20:41:45 +02:00
marin
df6ba0e824
Apply suggestions from code review
...
Co-authored-by: Irevoire <tamo@meilisearch.com>
2021-06-01 11:18:37 +02:00
Marin Postma
6609f9e3be
review edits
2021-05-31 18:41:37 +02:00
Marin Postma
1c4f0b2ccf
clippy, fmt & tests
2021-05-31 16:03:39 +02:00
Marin Postma
10fc870684
improve dump info reports
2021-05-31 15:49:04 +02:00
tamo
dffbaca63b
bump sentry version
2021-05-31 13:59:31 +02:00
Marin Postma
b3c8f0e1f6
fix empty index error
2021-05-31 10:58:51 +02:00
Marin Postma
bc5a5e37ea
fix dump v1
2021-05-31 10:42:31 +02:00
Marin Postma
33c6c4f0ee
add timestamos to dump info
2021-05-30 15:55:17 +02:00
Marin Postma
39c16c0fe4
fix dump import
2021-05-30 12:35:17 +02:00
Marin Postma
1cb64caae4
dump content is now only uuid
2021-05-29 00:08:17 +02:00
Marin Postma
b258f4f394
fix dump import
2021-05-27 14:30:20 +02:00
Marin Postma
c47369839b
dump meta
2021-05-27 10:51:19 +02:00
Marin Postma
b924e897f1
load index dump
2021-05-27 10:27:47 +02:00
Marin Postma
e818c33fec
implement load uuid_resolver
2021-05-26 20:42:09 +02:00
Marin Postma
9278a6fe59
integrate in dump actor
2021-05-25 18:14:11 +02:00
Marin Postma
3593ebb8aa
dump updates
2021-05-25 16:44:58 +02:00
Marin Postma
464639aa0f
udpate actor error improvements
2021-05-25 16:44:58 +02:00
Marin Postma
4acbe8e473
implement index dump
2021-05-25 16:44:58 +02:00
Marin Postma
7ad553670f
index error handling
2021-05-25 16:44:58 +02:00
Marin Postma
2185fb8367
dump uuid resolver
2021-05-25 16:44:54 +02:00
tamo
89846d1656
improve panic message
2021-05-25 15:47:57 +02:00
tamo
1a6dcec83a
crash when the actor have no inbox
2021-05-25 15:23:13 +02:00
tamo
991d8e1ec6
fix the error printing
2021-05-25 10:48:57 +02:00
tamo
49a0e8aa19
use a RwLock instead of a Mutex
2021-05-24 18:19:34 +02:00
tamo
912f0286b3
remove the dump_inner trickery
2021-05-24 18:06:20 +02:00
tamo
dcf29e1081
fix the error handling in case there is a panic while creating a dump
2021-05-24 17:33:42 +02:00
tamo
529f7962f4
handle parallel requests for the dump actor
2021-05-24 15:42:12 +02:00
tamo
8a11c6c429
Implements the legacy behaviour of the dump
...
When asked if a dump exists we check if it's the current dump, and if
it's not then we check on the filesystem for any file matching our
`uid.dump`
2021-05-24 12:35:46 +02:00
tamo
4cbf866821
merge with main
2021-05-12 18:12:37 +02:00
tamo
e0e23636c6
fix the serializer + reformat the file
2021-05-12 17:04:24 +02:00
Marin Postma
295f496e8a
atomic index dump load
2021-05-12 16:21:37 +02:00
tamo
6d837e3e07
the route to create a dump must return a 202
2021-05-11 17:34:34 +02:00
