Commit Graph

37 Commits

Author SHA1 Message Date
Matthias Wright 754f48a4fb Improves ranking rules error message 2022-05-20 21:25:43 +02:00
Tamo 484a9ddb27
Simplify the error creation with thiserror and a smol friendly macro 2022-05-04 17:24:00 +02:00
many 7b3bac46a0
Change Attribute and Ranking rules errors 2021-11-04 13:19:32 +01:00
many 3599df77f0
Change some error messages 2021-10-27 19:33:01 +02:00
Irevoire 218f0a6661
Apply suggestions from code review
Co-authored-by: Clément Renault <clement@meilisearch.com>
2021-09-22 17:00:27 +02:00
Tamo 1e5e3d57e2
auto convert AscDescError into CriterionError 2021-09-22 16:37:41 +02:00
Tamo 023446ecf3
create a smaller and easier to maintain CriterionError type 2021-09-22 16:37:41 +02:00
Tamo 86e272856a
create an asc_desc error type that is never supposed to be returned to the end user 2021-09-22 16:37:41 +02:00
Tamo 257e621d40
create an asc_desc module 2021-09-22 16:37:41 +02:00
Tamo 113a061bee
fix the error handling on the criterion side 2021-09-22 15:09:07 +02:00
Tamo 78b0bce9a1
fix the returned error when asc desc fails to be parsed 2021-09-22 11:37:05 +02:00
Irevoire 0d104a0fce
Update milli/src/criterion.rs
Co-authored-by: Clément Renault <clement@meilisearch.com>
2021-09-20 18:13:17 +02:00
Tamo f4b8e5675d
move the reserved keyword logic for the criterion and sort + add test 2021-09-20 17:21:02 +02:00
Irevoire a84f3a8b31
Apply suggestions from code review
Co-authored-by: Clément Renault <clement@meilisearch.com>
2021-09-09 15:09:35 +02:00
Tamo c81ff22c5b
delete the invalid criterion name error in favor of invalid ranking rule name 2021-09-08 19:17:00 +02:00
Tamo bd4c248292
improve the error handling in general and introduce the concept of reserved keywords 2021-09-08 18:24:09 +02:00
Tamo dc84ecc40b
fix a bug 2021-09-08 18:24:09 +02:00
Tamo 4820ac71a6
allow spaces in a geoRadius 2021-09-08 18:24:09 +02:00
Tamo 13c78e5aa2
Implement the _geoPoint in the sortable 2021-09-08 18:24:09 +02:00
Tamo 932998f5cc
let the caller decide if they want to return an invalidSortName or an
invalidCriterionName error
2021-09-08 16:17:31 +02:00
Kerollmops e2cefc9b4f
Move the sort ranking rule before the exactness ranking rule 2021-09-07 16:41:33 +02:00
Clément Renault 89d0758713
Revert "Revert "Sort at query time"" 2021-08-24 11:55:16 +02:00
Clémentine Urquizar 922f9fd4d5
Revert "Sort at query time" 2021-08-20 18:09:17 +02:00
Kerollmops 1b7f6ea1e7
Return a new error when the sort criteria is not sortable 2021-08-18 15:04:07 +02:00
Kerollmops 687cd2e205
Introduce the new Sort criterion and AscDesc enum 2021-08-18 15:04:07 +02:00
Kerollmops 5b88df508e
Use the new Asc/Desc syntax everywhere 2021-08-17 14:15:22 +02:00
Kerollmops fcedff95e8
Change the Asc/Desc criterion syntax to use a colon (:) 2021-08-17 14:03:21 +02:00
Tamo 9716fb3b36
format the whole project 2021-06-16 18:33:33 +02:00
Kerollmops 312c2d1d8e
Use the Error enum everywhere in the project 2021-06-14 16:58:38 +02:00
Kerollmops 82df524e09
Make sure that we register the field when setting criteria 2021-06-08 18:14:33 +02:00
Kerollmops b0c0490e85
Make sure that we can add a Asc/Desc field without it being filterable 2021-06-02 16:24:58 +02:00
Clément Renault bd7b285bae
Split the update side to use the number and the strings facet databases 2021-05-25 11:30:00 +02:00
tamo 0a4bde1f2f
update the default ordering of the criterion 2021-04-01 19:45:31 +02:00
Alexey Shekhirin 2cb32edaa9 fix(criterion): compile asc/desc regex only once
use once_cell instead of lazy_static

reorder imports
2021-03-30 16:07:14 +03:00
mpostma e3095be85c
Remove Debug use in Display impl 2021-03-08 12:09:09 +01:00
mpostma 9e1eb25232
implement display for criterion
Update milli/src/criterion.rs

Co-authored-by: Clément Renault <clement@meilisearch.com>
2021-03-08 11:00:30 +01:00
Clément Renault e8639517da
Change the project to become a workspace with milli as a default-member 2021-02-12 16:15:09 +01:00