Fix clippy warnings

This commit is contained in:
ManyTheFish 2022-07-28 15:33:54 +02:00
parent 58d2aad309
commit e6f03f82df
3 changed files with 9 additions and 3 deletions

View File

@ -30,7 +30,7 @@ pub fn setup_meilisearch(opt: &Opt) -> anyhow::Result<MeiliSearch> {
let mut meilisearch = MeiliSearch::builder();
// disable autobatching?
let _ = AUTOBATCHING_ENABLED.store(
AUTOBATCHING_ENABLED.store(
opt.scheduler_options.disable_auto_batching,
std::sync::atomic::Ordering::Relaxed,
);

View File

@ -11,7 +11,7 @@ pub enum DumpError {
#[error("An internal error has occurred. `{0}`.")]
Internal(Box<dyn std::error::Error + Send + Sync + 'static>),
#[error("{0}")]
IndexResolver(#[from] IndexResolverError),
IndexResolver(Box<IndexResolverError>),
}
internal_error!(
@ -26,6 +26,12 @@ internal_error!(
TaskError
);
impl From<IndexResolverError> for DumpError {
fn from(e: IndexResolverError) -> Self {
Self::IndexResolver(Box::new(e))
}
}
impl ErrorCode for DumpError {
fn error_code(&self) -> Code {
match self {

View File

@ -484,7 +484,7 @@ fn make_batch(tasks: &mut TaskQueue, config: &SchedulerConfig) -> Processing {
match list.peek() {
Some(pending) if pending.kind == kind => {
// We always need to process at least one task for the scheduler to make progress.
if config.disable_auto_batching && task_list.len() > 0 {
if config.disable_auto_batching && !task_list.is_empty() {
break;
}
let pending = list.pop().unwrap();