Merge #298

298: Rename the search benchmarks r=Kerollmops a=irevoire

And fix a bug. As always, I was not closing the env.

Co-authored-by: Tamo <tamo@meilisearch.com>

.github/workflows/benchmarks.yml

@@ -4,9 +4,9 @@ on:
   workflow_dispatch:
     inputs:
       dataset_name:
-        description: 'The name of the dataset used to benchmark (songs, wiki or indexing)'
+        description: 'The name of the dataset used to benchmark (search_songs, search_wiki or indexing)'
         required: false
-        default: 'songs'
+        default: 'search_songs'
 
 env:
   HOME: "/home/runner" # The actions-rs/toolchain@v1 can fail we have no $HOME defined

benchmarks/Cargo.toml

@@ -22,11 +22,11 @@ convert_case = "0.4"
 reqwest = { version = "0.11.3", features = ["blocking", "rustls-tls"], default-features = false }
 
 [[bench]]
-name = "songs"
+name = "search_songs"
 harness = false
 
 [[bench]]
-name = "wiki"
+name = "search_wiki"
 harness = false
 
 [[bench]]

benchmarks/benches/utils.rs

@@ -115,5 +115,7 @@ pub fn run_benches(c: &mut criterion::Criterion, confs: &[Conf]) {
             });
         }
         group.finish();
+
+        index.prepare_for_closing().wait();
     }
 }