searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-07-03 11:57:07 +02:00
Code Issues Releases Wiki Activity

Delete a task's persisted data when appropriate

Browse source
This commit is contained in:
Loïc Lecrenier 2022-10-18 15:04:14 +02:00 • committed by Clément Renault
parent 7308ccd530
commit baeb168b6e
No known key found for this signature in database
GPG key ID: 92ADA4E935E71FA4
19 changed files with 116 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

23
index-scheduler/src/lib.rs
View file

@ -381,7 +381,7 @@ impl IndexScheduler {
match wtxn.commit() {
Ok(()) => (),
_e @ Err(_) => {
todo!("remove the data associated with the task");
self.delete_persisted_task_data(&task)?;
// _e?;
}
}
@ -577,8 +577,8 @@ impl IndexScheduler {
for mut task in tasks {
task.started_at = Some(started_at);
task.finished_at = Some(finished_at);
// TODO the info field should've been set by the process_batch function
self.update_task(&mut wtxn, &task)?;
self.delete_persisted_task_data(&task)?;
}
log::info!("A batch of tasks was successfully completed.");
}
@ -606,6 +606,25 @@ impl IndexScheduler {
Ok(processed_tasks)
}
pub(crate) fn delete_persisted_task_data(&self, task: &Task) -> Result<()> {
match &task.kind {
KindWithContent::DocumentImport { content_file, .. } => {
self.delete_update_file(*content_file)
}
KindWithContent::DocumentDeletion { .. }
| KindWithContent::DocumentClear { .. }
| KindWithContent::Settings { .. }
| KindWithContent::IndexDeletion { .. }
| KindWithContent::IndexCreation { .. }
| KindWithContent::IndexUpdate { .. }
| KindWithContent::IndexSwap { .. }
| KindWithContent::CancelTask { .. }
| KindWithContent::TaskDeletion { .. }
| KindWithContent::DumpExport { .. }
| KindWithContent::Snapshot => Ok(()),
}
}
}
#[cfg(test)]