searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2024-12-01 17:15:46 +01:00
Code Issues Releases Wiki Activity

exact_attributes: Add TODOs and additional check after review

Browse Source
This commit is contained in:
Louis Dureuil 2023-04-06 15:59:00 +02:00 committed by Louis Dureuil
parent 618c54915d
commit ab09dc0167
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
milli/src/search/new/exact_attribute.rs
View File

@ -166,6 +166,9 @@ impl State {
) )
.unwrap_or_default(); .unwrap_or_default();
candidates &= word_position_docids; candidates &= word_position_docids;
if candidates.is_empty() {
return Ok(State::Empty(query_graph.clone()));
}
} }
} }
@ -197,11 +200,15 @@ impl State {
)?; )?;
intersection &= &candidates; intersection &= &candidates;
if !intersection.is_empty() { if !intersection.is_empty() {
// TODO: although not really worth it in terms of performance,
// if would be good to put this in cache for the sake of consistency
let candidates_with_exact_word_count = ctx let candidates_with_exact_word_count = ctx
.index .index
.field_id_word_count_docids .field_id_word_count_docids
.get(ctx.txn, &(fid, exact_term_position_ids.len() as u8))? .get(ctx.txn, &(fid, exact_term_position_ids.len() as u8))?
.unwrap_or_default(); .unwrap_or_default();
// TODO: consider if we must store the candidates as arrays, or if there is a way to perform the union
// here.
candidates_per_attribute.push(FieldCandidates { candidates_per_attribute.push(FieldCandidates {
start_with_exact: intersection, start_with_exact: intersection,
exact_word_count: candidates_with_exact_word_count, exact_word_count: candidates_with_exact_word_count,