fix for review

meilisearch-core/src/serde/deserializer.rs

@@ -54,7 +54,7 @@ pub struct Deserializer<'a> {
     pub reader: &'a heed::RoTxn<MainT>,
     pub documents_fields: DocumentsFields,
     pub schema: &'a Schema,
-    pub attributes: Option<&'a HashSet<FieldId>>,
+    pub fields: Option<&'a HashSet<FieldId>>,
 }
 
 impl<'de, 'a, 'b> de::Deserializer<'de> for &'b mut Deserializer<'a> {
@@ -92,9 +92,9 @@ impl<'de, 'a, 'b> de::Deserializer<'de> for &'b mut Deserializer<'a> {
                     }
                 };
 
-                let is_displayed = self.schema.id_is_displayed(attr);
-                if is_displayed && self.attributes.map_or(true, |f| f.contains(&attr)) {
-                    if let Some(attribute_name) = self.schema.get_name(attr) {
+                let is_displayed = self.schema.is_displayed(attr);
+                if is_displayed && self.fields.map_or(true, |f| f.contains(&attr)) {
+                    if let Some(attribute_name) = self.schema.name(attr) {
                         let cursor = Cursor::new(value.to_owned());
                         let ioread = SerdeJsonIoRead::new(cursor);
                         let value = Value(SerdeJsonDeserializer::new(ioread));

meilisearch-core/src/serde/extract_document_id.rs

@@ -2,7 +2,7 @@ use std::hash::{Hash, Hasher};
 
 use crate::DocumentId;
 use serde::{ser, Serialize};
-use serde_json::Value;
+use serde_json::{Value, Number};
 use siphasher::sip::SipHasher;
 
 use super::{ConvertToString, SerializerError};
@@ -18,18 +18,27 @@ where
     document.serialize(serializer)
 }
 
+fn validate_number(value: &Number) -> Option<String> {
+    if value.is_f64() {
+        return None
+    }
+    return Some(value.to_string())
+}
+
+fn validate_string(value: &String) -> Option<String> {
+    if value.chars().all(|x| x.is_ascii_alphanumeric() || x == '-' || x == '_') {
+        Some(value.to_string())
+    } else {
+        None
+    }
+}
+
 pub fn value_to_string(value: &Value) -> Option<String> {
     match value {
         Value::Null => None,
         Value::Bool(_) => None,
-        Value::Number(value) => Some(value.to_string()),
-        Value::String(value) => {
-            if value.chars().all(|x| x.is_ascii_alphanumeric() || x == '-' || x == '_') {
-                Some(value.to_string())
-            } else {
-                None
-            }
-        },
+        Value::Number(value) => validate_number(value),
+        Value::String(value) => validate_string(value),
         Value::Array(_) => None,
         Value::Object(_) => None,
     }

meilisearch-core/src/serde/indexer.rs

@@ -1,4 +1,4 @@
-use meilisearch_schema::{IndexedPos};
+use meilisearch_schema::IndexedPos;
 use serde::ser;
 use serde::Serialize;
 

meilisearch-core/src/serde/mod.rs

@@ -57,7 +57,7 @@ impl fmt::Display for SerializerError {
                 f.write_str("serialized document does not have an id according to the schema")
             }
             SerializerError::InvalidDocumentIdType => {
-                f.write_str("document identifier can only be of type number or string (A-Z, a-z, 0-9, -_)")
+                f.write_str("documents identifiers can be of type integer or string only composed of alphanumeric characters, hyphens (-) and underscores (_).")
             }
             SerializerError::Zlmdb(e) => write!(f, "heed related error: {}", e),
             SerializerError::SerdeJson(e) => write!(f, "serde json error: {}", e),

meilisearch-core/src/serde/serializer.rs

@@ -305,7 +305,7 @@ pub fn serialize_value<'a, T: ?Sized>(
 where
     T: ser::Serialize,
 {
-    let field_id = schema.get_or_create(attribute.clone())?;
+    let field_id = schema.get_or_create(&attribute)?;
 
     serialize_value_with_id(
         txn,
@@ -337,7 +337,7 @@ where
     let serialized = serde_json::to_vec(value)?;
     document_store.put_document_field(txn, document_id, field_id, &serialized)?;
 
-    if let Some(indexed_pos) = schema.id_is_indexed(field_id) {
+    if let Some(indexed_pos) = schema.is_indexed(field_id) {
         let indexer = Indexer {
             pos: *indexed_pos,
             indexer,
@@ -353,7 +353,7 @@ where
         }
     }
 
-    if schema.id_is_ranked(field_id) {
+    if schema.is_ranked(field_id) {
         let number = value.serialize(ConvertToNumber)?;
         ranked_map.insert(document_id, field_id, number);
     }