searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-07-04 12:27:13 +02:00
Code Issues Releases Wiki Activity

Remove Embed::process_embeddings and have it be an inherent function of the type that uses it

Browse source
This commit is contained in:
Louis Dureuil 2025-07-03 10:02:16 +02:00
parent 549dc985b8
commit a06cb1bfd6
No known key found for this signature in database
3 changed files with 4 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/milli/src/update/index_documents/extract/extract_vector_points.rs
View file

@ -1300,12 +1300,4 @@ impl<'doc> OnEmbed<'doc> for WriteGrenadOnEmbed<'_> {
crate::Error::UserError(crate::UserError::DocumentEmbeddingError(msg)) crate::Error::UserError(crate::UserError::DocumentEmbeddingError(msg))
} }
} }
fn process_embeddings(
&mut self,
_metadata: crate::vector::session::Metadata<'doc>,
_embeddings: Vec<Embedding>,
) {
unimplemented!("unused")
}
} }

9
crates/milli/src/update/new/extract/vectors/mod.rs
View file

@ -452,6 +452,10 @@ impl OnEmbeddingDocumentUpdates<'_, '_> {
fn clear_vectors(&self, docid: DocumentId) { fn clear_vectors(&self, docid: DocumentId) {
self.sender.set_vectors(docid, self.embedder_id, vec![]).unwrap(); self.sender.set_vectors(docid, self.embedder_id, vec![]).unwrap();
} }
fn process_embeddings(&mut self, metadata: Metadata<'_>, embeddings: Vec<Embedding>) {
self.sender.set_vectors(metadata.docid, self.embedder_id, embeddings).unwrap();
}
} }
impl<'doc> OnEmbed<'doc> for OnEmbeddingDocumentUpdates<'doc, '_> { impl<'doc> OnEmbed<'doc> for OnEmbeddingDocumentUpdates<'doc, '_> {
@ -469,11 +473,6 @@ impl<'doc> OnEmbed<'doc> for OnEmbeddingDocumentUpdates<'doc, '_> {
) )
.unwrap(); .unwrap();
} }
fn process_embeddings(&mut self, metadata: Metadata<'doc>, embeddings: Vec<Embedding>) {
self.sender.set_vectors(metadata.docid, self.embedder_id, embeddings).unwrap();
}
fn process_embedding_error( fn process_embedding_error(
&mut self, &mut self,
error: crate::vector::hf::EmbedError, error: crate::vector::hf::EmbedError,

2
crates/milli/src/vector/session.rs
View file

@ -30,8 +30,6 @@ pub trait OnEmbed<'doc> {
unused_vectors_distribution: &Self::ErrorMetadata, unused_vectors_distribution: &Self::ErrorMetadata,
metadata: &[Metadata<'doc>], metadata: &[Metadata<'doc>],
) -> crate::Error; ) -> crate::Error;
fn process_embeddings(&mut self, metadata: Metadata<'doc>, embeddings: Vec<Embedding>);
} }
pub struct EmbedSession<'doc, C, I> { pub struct EmbedSession<'doc, C, I> {