searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2024-12-11 22:06:30 +01:00
Code Issues Releases Wiki Activity

Add new error message

Browse Source
This commit is contained in:
ManyTheFish 2024-12-04 11:15:29 +01:00
parent 054622bd16
commit 953a82ca04
3 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/meilisearch-types/src/error.rs
View File

@ -279,6 +279,7 @@ InvalidSearchPage , InvalidRequest , BAD_REQUEST ;
InvalidSearchQ , InvalidRequest , BAD_REQUEST ; InvalidSearchQ , InvalidRequest , BAD_REQUEST ;
InvalidFacetSearchQuery , InvalidRequest , BAD_REQUEST ; InvalidFacetSearchQuery , InvalidRequest , BAD_REQUEST ;
InvalidFacetSearchName , InvalidRequest , BAD_REQUEST ; InvalidFacetSearchName , InvalidRequest , BAD_REQUEST ;
InvalidFacetSearchDisabled , InvalidRequest , BAD_REQUEST ;
InvalidSearchVector , InvalidRequest , BAD_REQUEST ; InvalidSearchVector , InvalidRequest , BAD_REQUEST ;
InvalidSearchShowMatchesPosition , InvalidRequest , BAD_REQUEST ; InvalidSearchShowMatchesPosition , InvalidRequest , BAD_REQUEST ;
InvalidSearchShowRankingScore , InvalidRequest , BAD_REQUEST ; InvalidSearchShowRankingScore , InvalidRequest , BAD_REQUEST ;

7
crates/meilisearch/src/search/mod.rs
View File

@ -1407,6 +1407,13 @@ pub fn perform_facet_search(
None => TimeBudget::default(), None => TimeBudget::default(),
}; };
if !index.facet_search(&rtxn)? {
return Err(ResponseError::from_msg(
"The facet search is disabled for this index".to_string(),
Code::InvalidFacetSearchDisabled,
));
}
// In the faceted search context, we want to use the intersection between the locales provided by the user // In the faceted search context, we want to use the intersection between the locales provided by the user
// and the locales of the facet string. // and the locales of the facet string.
// If the facet string is not localized, we **ignore** the locales provided by the user because the facet data has no locale. // If the facet string is not localized, we **ignore** the locales provided by the user because the facet data has no locale.

22
crates/meilisearch/tests/search/facet_search.rs
View File

@ -221,8 +221,15 @@ async fn add_documents_and_deactivate_facet_search() {
let (response, code) = let (response, code) =
index.facet_search(json!({"facetName": "genres", "facetQuery": "a"})).await; index.facet_search(json!({"facetName": "genres", "facetQuery": "a"})).await;
assert_eq!(code, 200, "{}", response); assert_eq!(code, 400, "{}", response);
assert_eq!(dbg!(response)["facetHits"].as_array().unwrap().len(), 0); snapshot!(response, @r###"
{
"message": "Facet search is disabled for this index",
"code": "invalid_search_disabled_facet_search",
"type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#invalid_search_disabled_facet_search"
}
"###);
} }
#[actix_rt::test] #[actix_rt::test]
@ -245,8 +252,15 @@ async fn deactivate_facet_search_and_add_documents() {
let (response, code) = let (response, code) =
index.facet_search(json!({"facetName": "genres", "facetQuery": "a"})).await; index.facet_search(json!({"facetName": "genres", "facetQuery": "a"})).await;
assert_eq!(code, 200, "{}", response); assert_eq!(code, 400, "{}", response);
assert_eq!(dbg!(response)["facetHits"].as_array().unwrap().len(), 0); snapshot!(response, @r###"
{
"message": "Facet search is disabled for this index",
"code": "invalid_search_disabled_facet_search",
"type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#invalid_search_disabled_facet_search"
}
"###);
} }
#[actix_rt::test] #[actix_rt::test]