searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2024-06-01 10:28:02 +02:00
Code Issues Releases Wiki Activity

Check the filter max depth limit and reject the invalid ones

Browse Source
This commit is contained in:
Clément Renault 2021-12-07 16:32:48 +01:00
parent 49c2db9485
commit 90f49eab6d
No known key found for this signature in database
GPG Key ID: 92ADA4E935E71FA4
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
milli/src/search/facet/filter.rs
View File

@ -15,6 +15,9 @@ use crate::heed_codec::facet::{
};
use crate::{distance_between_two_points, CboRoaringBitmapCodec, FieldId, Index, Result};
/// The maximum number of filters the filter AST can process.
const MAX_FILTER_DEPTH: usize = 1000;
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct Filter<'a> {
condition: FilterCondition<'a>,
@ -27,6 +30,7 @@ enum FilterError<'a> {
BadGeoLat(f64),
BadGeoLng(f64),
Reserved(&'a str),
TooDeep,
InternalError,
}
impl<'a> std::error::Error for FilterError<'a> {}
@ -40,6 +44,10 @@ impl<'a> Display for FilterError<'a> {
attribute,
filterable,
),
Self::TooDeep => write!(f,
"Too many filter conditions, can't process more than {} filters.",
MAX_FILTER_DEPTH
),
Self::Reserved(keyword) => write!(
f,
"`{}` is a reserved keyword and thus can't be used as a filter expression.",
@ -108,6 +116,10 @@ impl<'a> Filter<'a> {
}
}
if let Some(token) = ands.as_ref().and_then(|fc| fc.token_at_depth(MAX_FILTER_DEPTH)) {
return Err(token.as_external_error(FilterError::TooDeep).into());
}
Ok(ands.map(|ands| Self { condition: ands }))
}