searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-02-14 14:33:27 +01:00
Code Issues Releases Wiki Activity

update the version file atomically

Browse Source
This commit is contained in:
Tamo 2025-02-06 18:23:28 +01:00
parent 8c5856007c
commit 7f82d33597
No known key found for this signature in database
GPG Key ID: 20CD8020AFA88D69
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
crates/meilisearch-types/src/versioning.rs
View File

@ -1,8 +1,9 @@
use std::fs::{self, File}; use std::fs;
use std::io::{self, ErrorKind, Write}; use std::io::{ErrorKind, Write};
use std::path::Path; use std::path::Path;
use milli::heed; use milli::heed;
use tempfile::NamedTempFile;
/// The name of the file that contains the version of the database. /// The name of the file that contains the version of the database.
pub const VERSION_FILE_NAME: &str = "VERSION"; pub const VERSION_FILE_NAME: &str = "VERSION";
@ -12,7 +13,7 @@ pub static VERSION_MINOR: &str = env!("CARGO_PKG_VERSION_MINOR");
pub static VERSION_PATCH: &str = env!("CARGO_PKG_VERSION_PATCH"); pub static VERSION_PATCH: &str = env!("CARGO_PKG_VERSION_PATCH");
/// Persists the version of the current Meilisearch binary to a VERSION file /// Persists the version of the current Meilisearch binary to a VERSION file
pub fn create_current_version_file(db_path: &Path) -> io::Result<()> { pub fn create_current_version_file(db_path: &Path) -> anyhow::Result<()> {
create_version_file(db_path, VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH) create_version_file(db_path, VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH)
} }
@ -21,12 +22,14 @@ pub fn create_version_file(
major: &str, major: &str,
minor: &str, minor: &str,
patch: &str, patch: &str,
) -> io::Result<()> { ) -> anyhow::Result<()> {
let version_path = db_path.join(VERSION_FILE_NAME); let version_path = db_path.join(VERSION_FILE_NAME);
let mut file = File::create(&version_path)?; // In order to persist the file later we must create it in the `data.ms` and not in `/tmp`
let mut file = NamedTempFile::new_in(db_path)?;
file.write_all(format!("{}.{}.{}", major, minor, patch).as_bytes())?; file.write_all(format!("{}.{}.{}", major, minor, patch).as_bytes())?;
file.flush()?; file.flush()?;
file.sync_all() file.persist(version_path)?;
Ok(())
} }
pub fn get_version(db_path: &Path) -> Result<(u32, u32, u32), VersionFileError> { pub fn get_version(db_path: &Path) -> Result<(u32, u32, u32), VersionFileError> {
@ -36,7 +39,7 @@ pub fn get_version(db_path: &Path) -> Result<(u32, u32, u32), VersionFileError>
Ok(version) => parse_version(&version), Ok(version) => parse_version(&version),
Err(error) => match error.kind() { Err(error) => match error.kind() {
ErrorKind::NotFound => Err(VersionFileError::MissingVersionFile), ErrorKind::NotFound => Err(VersionFileError::MissingVersionFile),
_ => Err(error.into()), _ => Err(anyhow::Error::from(error).into()),
}, },
} }
} }
@ -91,5 +94,5 @@ pub enum VersionFileError {
ErrorWhileModifyingTheDatabase(#[from] heed::Error), ErrorWhileModifyingTheDatabase(#[from] heed::Error),
#[error(transparent)] #[error(transparent)]
IoError(#[from] std::io::Error), AnyhowError(#[from] anyhow::Error),
} }