searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-01-10 05:24:32 +01:00
Code Issues Releases Wiki Activity

Check valid_facet_value as part of a filter of the iterator

Browse Source
This commit is contained in:
Louis Dureuil 2025-01-08 16:25:44 +01:00
parent 6a577254fa
commit 7ec7200378
No known key found for this signature in database
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/milli/src/update/facet/new_incremental.rs
View File

@ -91,8 +91,12 @@ impl FacetsUpdateIncrementalInner {
FacetGroupKey { field_id: self.field_id, level: parent_level, left_bound: &[] }; FacetGroupKey { field_id: self.field_id, level: parent_level, left_bound: &[] };
let mut last_parent: Option<Box<[u8]>> = None; let mut last_parent: Option<Box<[u8]>> = None;
let mut child_it = let mut child_it = changed_children
changed_children.drain(..).filter(|child| valid_facet_value(&child.facet_value)); // drain all changed children
.drain(..)
// keep only children whose value is valid in the LMDB sense
.filter(|child| valid_facet_value(&child.facet_value));
// `while let` rather than `for` because we advance `child_it` inside of the loop
'current_level: while let Some(child) = child_it.next() { 'current_level: while let Some(child) = child_it.next() {
if let Some(last_parent) = &last_parent { if let Some(last_parent) = &last_parent {
if &child.facet_value >= last_parent { if &child.facet_value >= last_parent {