searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-07-03 20:07:09 +02:00
Code Issues Releases Wiki Activity

Fix typos in comments and messages

Browse source
This commit is contained in:
ManyTheFish 2025-03-11 15:22:00 +01:00
parent 6d52c6e711
commit 7072fe9780
8 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/milli/src/search/facet/facet_distribution.rs
View file

@ -350,7 +350,7 @@ impl<'a> FacetDistribution<'a> {
Ok(distribution)
}
/// Select a field if it is faceted and in the facets.
/// Select a field if it is filterable and in the facets.
fn select_field(
&self,
name: &str,
@ -372,7 +372,7 @@ impl<'a> FacetDistribution<'a> {
}
}
/// Check if the fields in the facets are valid faceted fields.
/// Check if the fields in the facets are valid filterable fields.
fn check_faceted_fields(
&self,
filterable_attributes_rules: &[FilterableAttributesRule],

14
crates/milli/src/search/facet/filter.rs
View file

@ -82,7 +82,7 @@ impl<'a> Display for FilterError<'a> {
if filterable_patterns.is_empty() {
write!(f, " This index does not have configured filterable attributes.")
} else {
write!(f, " Available filterable attributes patterns are: ")?;
write!(f, " Available filterable attribute patterns are: ")?;
let mut filterables_list =
filterable_patterns.iter().map(AsRef::as_ref).collect::<Vec<&str>>();
filterables_list.sort_unstable();
@ -911,42 +911,42 @@ mod tests {
let filter = Filter::from_str("_geoRadius(-100, 150, 10)").unwrap().unwrap();
let error = filter.evaluate(&rtxn, &index).unwrap_err();
snapshot!(error.to_string(), @r###"
Attribute `_geo` is not filterable. Available filterable attributes patterns are: `title`.
Attribute `_geo` is not filterable. Available filterable attribute patterns are: `title`.
12:16 _geoRadius(-100, 150, 10)
"###);
let filter = Filter::from_str("_geoBoundingBox([42, 150], [30, 10])").unwrap().unwrap();
let error = filter.evaluate(&rtxn, &index).unwrap_err();
snapshot!(error.to_string(), @r###"
Attribute `_geo` is not filterable. Available filterable attributes patterns are: `title`.
Attribute `_geo` is not filterable. Available filterable attribute patterns are: `title`.
18:20 _geoBoundingBox([42, 150], [30, 10])
"###);
let filter = Filter::from_str("name = 12").unwrap().unwrap();
let error = filter.evaluate(&rtxn, &index).unwrap_err();
snapshot!(error.to_string(), @r###"
Attribute `name` is not filterable. Available filterable attributes patterns are: `title`.
Attribute `name` is not filterable. Available filterable attribute patterns are: `title`.
1:5 name = 12
"###);
let filter = Filter::from_str("title = \"test\" AND name = 12").unwrap().unwrap();
let error = filter.evaluate(&rtxn, &index).unwrap_err();
snapshot!(error.to_string(), @r###"
Attribute `name` is not filterable. Available filterable attributes patterns are: `title`.
Attribute `name` is not filterable. Available filterable attribute patterns are: `title`.
20:24 title = "test" AND name = 12
"###);
let filter = Filter::from_str("title = \"test\" AND name IN [12]").unwrap().unwrap();
let error = filter.evaluate(&rtxn, &index).unwrap_err();
snapshot!(error.to_string(), @r###"
Attribute `name` is not filterable. Available filterable attributes patterns are: `title`.
Attribute `name` is not filterable. Available filterable attribute patterns are: `title`.
20:24 title = "test" AND name IN [12]
"###);
let filter = Filter::from_str("title = \"test\" AND name != 12").unwrap().unwrap();
let error = filter.evaluate(&rtxn, &index).unwrap_err();
snapshot!(error.to_string(), @r###"
Attribute `name` is not filterable. Available filterable attributes patterns are: `title`.
Attribute `name` is not filterable. Available filterable attribute patterns are: `title`.
20:24 title = "test" AND name != 12
"###);
}