searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-07-04 04:17:10 +02:00
Code Issues Releases Wiki Activity

Old dump import indexer: fix the case where going from Generated to Generated

Browse source
This commit is contained in:
Louis Dureuil 2025-07-03 09:58:41 +02:00
parent 428463e45c
commit 549dc985b8
No known key found for this signature in database
1 changed files with 31 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

62
crates/milli/src/update/index_documents/extract/extract_vector_points.rs
View file

@ -726,6 +726,35 @@ fn extract_vector_document_diff(
}
let has_fragments = !runtime.fragments().is_empty();
if has_fragments {
let mut fragment_diff = Vec::new();
let old_fields_ids_map = old_fields_ids_map.as_fields_ids_map();
let new_fields_ids_map = new_fields_ids_map.as_fields_ids_map();
let old_document = crate::update::new::document::KvDelAddDocument::new(
obkv,
DelAdd::Deletion,
old_fields_ids_map,
);
let new_document = crate::update::new::document::KvDelAddDocument::new(
obkv,
DelAdd::Addition,
new_fields_ids_map,
);
for new in runtime.fragments() {
let name = &new.name;
let fragment =
RequestFragmentExtractor::new(new, doc_alloc).ignore_errors();
let diff = fragment
.diff_documents(&old_document, &new_document, &())
.expect("ignoring errors so this cannot fail");
fragment_diff.push((name.clone(), diff));
}
VectorStateDelta::UpdateGeneratedFromFragments(fragment_diff)
} else {
let prompt = &runtime.document_template;
// Don't give up if the old prompt was failing
let old_prompt = Some(&prompt).map(|p| {
@ -741,38 +770,9 @@ fn extract_vector_document_diff(
);
VectorStateDelta::NowGenerated(new_prompt)
} else {
let mut fragment_diff = Vec::new();
let old_fields_ids_map = old_fields_ids_map.as_fields_ids_map();
let new_fields_ids_map = new_fields_ids_map.as_fields_ids_map();
let old_document = crate::update::new::document::KvDelAddDocument::new(
obkv,
DelAdd::Deletion,
old_fields_ids_map,
);
let new_document = crate::update::new::document::KvDelAddDocument::new(
obkv,
DelAdd::Addition,
new_fields_ids_map,
);
for new in runtime.fragments() {
let name = &new.name;
let fragment =
RequestFragmentExtractor::new(new, doc_alloc).ignore_errors();
let diff = fragment
.diff_documents(&old_document, &new_document, &())
.expect("ignoring errors so this cannot fail");
fragment_diff.push((name.clone(), diff));
}
VectorStateDelta::UpdateGeneratedFromFragments(fragment_diff)
tracing::trace!("⏭️ Prompt unmodified, skipping");
VectorStateDelta::NoChange
}
} else {
tracing::trace!("⏭️ Prompt unmodified, skipping");
VectorStateDelta::NoChange
}
} else {
VectorStateDelta::NowRemoved