Update following reviews

This commit is contained in:
Clémentine Urquizar 2021-06-01 16:37:57 +02:00 committed by Tamo
parent bc4f4ee829
commit 3c91a9a551
No known key found for this signature in database
GPG key ID: 20CD8020AFA88D69
3 changed files with 24 additions and 18 deletions

View file

@ -2,7 +2,7 @@
# Requirements:
# - critcmp. See: https://github.com/BurntSushi/critcmp
# - wget
# - curl
# Usage
# $ bash compare.sh json_file1 json_file1
@ -17,13 +17,6 @@ if [[ "$?" -ne 0 ]]; then
exit 1
fi
# Checking that wget is installed
command -v wget > /dev/null 2>&1
if [[ "$?" -ne 0 ]]; then
echo 'You must install wget to make this script working.'
exit 1
fi
if [[ $# -ne 2 ]]
then
echo 'Need 2 arguments.'
@ -43,9 +36,9 @@ file1_local_path="/tmp/$file1"
file2_local_path="/tmp/$file2"
if [[ ! -f "$file1_local_path" ]]; then
wget "$file1_s3_url" -O "$file1_local_path"
curl "$file1_s3_url" -O "$file1_local_path"
if [[ "$?" -ne 0 ]]; then
echo 'wget command failed. Check your configuration'
echo 'curl command failed. Check your configuration'
exit 1
fi
else
@ -53,9 +46,9 @@ else
fi
if [[ ! -f "$file2_local_path" ]]; then
wget "$file2_s3_url" -O "$file2_local_path"
curl "$file2_s3_url" -O "$file2_local_path"
if [[ "$?" -ne 0 ]]; then
echo 'wget command failed. Check your configuration'
echo 'curl command failed. Check your configuration'
exit 1
fi
else