searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2025-07-03 20:07:09 +02:00
Code Issues Releases Wiki Activity

Update following reviews

Browse source
This commit is contained in:
Clémentine Urquizar 2021-06-01 16:37:57 +02:00 • committed by Tamo
parent bc4f4ee829
commit 3c91a9a551
No known key found for this signature in database
GPG key ID: 20CD8020AFA88D69
3 changed files with 24 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

11
benchmarks/README.md
View file

@ -52,8 +52,12 @@ To trigger the benchmark workflow:
This GitHub workflow will run the benchmarks and push the `critcmp` report to a DigitalOcean Space (= S3).
The name of the uploaded file is displayed in the workflow.
_[More about critcmp](https://github.com/BurntSushi/critcmp)._
💡 To compare the just-uploaded benchmark with another one, check out the [next section](#comparison-between-benchmarks).
### On your machine
To run all the benchmarks (~4h):
@ -85,13 +89,14 @@ The benchmark reports we push are generated with `critcmp`. Thus, we use `critcm
We provide a script to download and display the comparison report.
Requirements:
- [`s3cmd`](https://github.com/s3tools/s3cmd) and being logged to the DigitalOcean Space "milli-benchmarks". See the [DigitalOcean guide](https://docs.digitalocean.com/products/spaces/resources/s3cmd/)
- `grep`
- `curl`
- [`critcmp`](https://github.com/BurntSushi/critcmp)
List the available file in the DO Space:
```bash
s3cmd ls s3://milli-benchmarks/critcmp_results/
./benchmarks/script/list.sh
```
```bash
2021-05-31 14:40 279890 s3://milli-benchmarks/critcmp_results/songs_main_09a4321.json
@ -101,5 +106,5 @@ s3cmd ls s3://milli-benchmarks/critcmp_results/
Run the comparison script:
```bash
bash benchmarks/scripts/compare.sh songs_main_09a4321.json songs_geosearch_24ec456.json
./benchmarks/scripts/compare.sh songs_main_09a4321.json songs_geosearch_24ec456.json
```

17
benchmarks/scripts/compare.sh
View file

@ -2,7 +2,7 @@
# Requirements:
# - critcmp. See: https://github.com/BurntSushi/critcmp
# - wget
# - curl
# Usage
# $ bash compare.sh json_file1 json_file1
@ -17,13 +17,6 @@ if [[ "$?" -ne 0 ]]; then
exit 1
fi
# Checking that wget is installed
command -v wget > /dev/null 2>&1
if [[ "$?" -ne 0 ]]; then
echo 'You must install wget to make this script working.'
exit 1
fi
if [[ $# -ne 2 ]]
then
echo 'Need 2 arguments.'
@ -43,9 +36,9 @@ file1_local_path="/tmp/$file1"
file2_local_path="/tmp/$file2"
if [[ ! -f "$file1_local_path" ]]; then
wget "$file1_s3_url" -O "$file1_local_path"
curl "$file1_s3_url" -O "$file1_local_path"
if [[ "$?" -ne 0 ]]; then
echo 'wget command failed. Check your configuration'
echo 'curl command failed. Check your configuration'
exit 1
fi
else
@ -53,9 +46,9 @@ else
fi
if [[ ! -f "$file2_local_path" ]]; then
wget "$file2_s3_url" -O "$file2_local_path"
curl "$file2_s3_url" -O "$file2_local_path"
if [[ "$?" -ne 0 ]]; then
echo 'wget command failed. Check your configuration'
echo 'curl command failed. Check your configuration'
exit 1
fi
else