invalid update payload returns bad_request

This commit is contained in:
marin postma 2021-06-21 18:56:22 +02:00
parent f91a3bc6ab
commit 2bdaa70f31
No known key found for this signature in database
GPG Key ID: 6088B7721C3E39F9
2 changed files with 5 additions and 1 deletions

View File

@ -173,7 +173,8 @@ where
if copy(&mut checker, &mut sink()).is_err() || checker.finish().is_err() { if copy(&mut checker, &mut sink()).is_err() || checker.finish().is_err() {
// The json file is invalid, we use Serde to get a nice error message: // The json file is invalid, we use Serde to get a nice error message:
file.seek(SeekFrom::Start(0))?; file.seek(SeekFrom::Start(0))?;
let _: serde_json::Value = serde_json::from_reader(file)?; let _: serde_json::Value = serde_json::from_reader(file)
.map_err(|e| UpdateActorError::InvalidPayload(Box::new(e)))?;
} }
Some(uuid) Some(uuid)
} else { } else {

View File

@ -19,6 +19,8 @@ pub enum UpdateActorError {
"update store was shut down due to a fatal error, please check your logs for more info." "update store was shut down due to a fatal error, please check your logs for more info."
)] )]
FatalUpdateStoreError, FatalUpdateStoreError,
#[error("invalid payload: {0}")]
InvalidPayload(Box<dyn Error + Send + Sync + 'static>),
} }
impl<T> From<tokio::sync::mpsc::error::SendError<T>> for UpdateActorError { impl<T> From<tokio::sync::mpsc::error::SendError<T>> for UpdateActorError {
@ -48,6 +50,7 @@ impl ErrorCode for UpdateActorError {
UpdateActorError::Internal(_) => Code::Internal, UpdateActorError::Internal(_) => Code::Internal,
UpdateActorError::IndexActor(e) => e.error_code(), UpdateActorError::IndexActor(e) => e.error_code(),
UpdateActorError::FatalUpdateStoreError => Code::Internal, UpdateActorError::FatalUpdateStoreError => Code::Internal,
UpdateActorError::InvalidPayload(_) => Code::BadRequest,
} }
} }
} }