Apply review suggestions and stop using rtxn.commit

This commit is contained in:
Loïc Lecrenier 2022-10-19 07:34:10 +02:00 committed by Clément Renault
parent 17cd2a4aa0
commit 11fee30f47
No known key found for this signature in database
GPG Key ID: 92ADA4E935E71FA4
3 changed files with 3 additions and 7 deletions

View File

@ -686,8 +686,7 @@ impl IndexScheduler {
| IndexOperation::DocumentClear { ref index_uid, .. } => {
// only get the index, don't create it
let rtxn = self.env.read_txn()?;
let r = self.index_mapper.index(&rtxn, index_uid)?;
r
self.index_mapper.index(&rtxn, index_uid)?
}
IndexOperation::DocumentImport { ref index_uid, allow_index_creation, .. }
| IndexOperation::Settings { ref index_uid, allow_index_creation, .. }
@ -701,8 +700,7 @@ impl IndexScheduler {
index
} else {
let rtxn = self.env.read_txn()?;
let r = self.index_mapper.index(&rtxn, index_uid)?;
r
self.index_mapper.index(&rtxn, index_uid)?
}
}
};

View File

@ -718,7 +718,7 @@ impl IndexScheduler {
Some(batch) => batch,
None => return Ok(0),
};
drop(rtxn); //rtxn.commit()?;
drop(rtxn);
// 1. store the starting date with the bitmap of processing tasks.
let mut ids = batch.ids();

View File

@ -80,8 +80,6 @@ pub fn snapshot_index_scheduler(scheduler: &IndexScheduler) -> String {
snap.push_str(&snapshot_file_store(file_store));
snap.push_str("\n----------------------------------------------------------------------\n");
rtxn.commit().unwrap();
snap
}