searchengines-web/MeiliSearch
searchengines-web/MeiliSearch
1
0
Fork 0
mirror of https://github.com/meilisearch/MeiliSearch synced 2024-11-26 14:54:27 +01:00
Code Issues Releases Wiki Activity

A score of 0.0 is now lesser than a sort result

Browse Source 
handles the niche case 🐩 in the hybrid search where:
1. a sort ranking rule is the first rule.
2. the keyword search is skipped at the first rule.
3. the semantic search is not skipped at the first rule.

Previously, we would have the skipped search winning, whereas we want the non skipped one winning.
This commit is contained in:
Louis Dureuil 2024-03-19 17:32:32 +01:00
parent d8fe4fe49d
commit 098ab594eb
No known key found for this signature in database
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
milli/src/search/hybrid.rs
View File

@ -50,8 +50,12 @@ fn compare_scores(
order => return order, order => return order,
} }
} }
(Some(ScoreValue::Score(_)), Some(_)) => return Ordering::Greater, (Some(ScoreValue::Score(x)), Some(_)) => {
(Some(_), Some(ScoreValue::Score(_))) => return Ordering::Less, return if x == 0. { Ordering::Less } else { Ordering::Greater }
}
(Some(_), Some(ScoreValue::Score(x))) => {
return if x == 0. { Ordering::Greater } else { Ordering::Less }
}
// if we have this, we're bad // if we have this, we're bad
(Some(ScoreValue::GeoSort(_)), Some(ScoreValue::Sort(_))) (Some(ScoreValue::GeoSort(_)), Some(ScoreValue::Sort(_)))
| (Some(ScoreValue::Sort(_)), Some(ScoreValue::GeoSort(_))) => { | (Some(ScoreValue::Sort(_)), Some(ScoreValue::GeoSort(_))) => {