MeiliSearch/filter-parser/README.md

37 lines
1.5 KiB
Markdown
Raw Normal View History

2021-11-04 14:39:02 +01:00
# Filter parser
This workspace is dedicated to the parsing of the MeiliSearch filters.
2021-11-04 14:43:36 +01:00
Most of the code and explanation are in the [`lib.rs`](./src/lib.rs). Especially, the BNF of the filters at the top of this file.
2021-11-04 14:39:02 +01:00
The parser use [nom](https://docs.rs/nom/) to do most of its work and [nom-locate](https://docs.rs/nom_locate/) to keep track of what we were doing when we encountered an error.
## Cli
A simple main is provided to quick-test if a filter can be parsed or not without bringing milli.
It takes one argument and try to parse it.
```
cargo run -- 'field = value' # success
cargo run -- 'field = "doggo' # error => missing closing delimiter "
```
## Fuzz
The workspace have been fuzzed with [cargo-fuzz](https://rust-fuzz.github.io/book/cargo-fuzz.html).
### Setup
You'll need rust-nightly to execute the fuzzer.
```
cargo install cargo-fuzz
```
### Run
2021-11-05 17:45:20 +01:00
When the filter parser is executed by the fuzzer it's triggering a stackoverflow really fast. We can avoid this problem by limiting the `max_len` of [libfuzzer](https://llvm.org/docs/LibFuzzer.html) at 500 characters.
2021-11-04 14:39:02 +01:00
```
2021-11-05 17:45:20 +01:00
cargo fuzz run parse -- -max_len=500
2021-11-04 14:39:02 +01:00
```
## What to do if you find a bug in the parser
2021-11-04 14:43:36 +01:00
- Write a test at the end of the [`lib.rs`](./src/lib.rs) to ensure it never happens again.
2021-11-09 16:40:05 +01:00
- Add a file in [the corpus directory](./fuzz/corpus/parse/) with your filter to help the fuzzer find new bugs. Since this directory is going to be heavily polluted by the execution of the fuzzer it's in the gitignore and you'll need to force push your new test.