989 lines
36 KiB
Rust
Raw Normal View History

2021-06-29 11:57:47 +02:00
use actix_web::test;
2022-10-20 18:00:07 +02:00
use serde_json::{json, Value};
use time::format_description::well_known::Rfc3339;
use time::OffsetDateTime;
2022-08-16 15:14:01 +02:00
use crate::common::encoder::Encoder;
2022-10-20 18:00:07 +02:00
use crate::common::{GetAllDocumentsOptions, Server};
2021-02-19 19:43:32 +01:00
2021-06-29 11:57:47 +02:00
/// This is the basic usage of our API and every other tests uses the content-type application/json
#[actix_rt::test]
async fn add_documents_test_json_content_types() {
let document = json!([
{
"id": 1,
"content": "Bouvier Bernois",
}
]);
// this is a what is expected and should work
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
// post
2021-06-29 11:57:47 +02:00
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
2022-08-18 11:33:22 +02:00
assert_eq!(status_code, 202);
assert_eq!(response["taskUid"], 0);
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 202);
assert_eq!(response["taskUid"], 1);
}
/// Here we try to send a single document instead of an array with a single document inside.
#[actix_rt::test]
async fn add_single_document_test_json_content_types() {
let document = json!({
"id": 1,
"content": "Bouvier Bernois",
});
// this is a what is expected and should work
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
2022-08-18 11:33:22 +02:00
// post
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
2021-06-29 11:57:47 +02:00
assert_eq!(status_code, 202);
assert_eq!(response["taskUid"], 0);
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 202);
assert_eq!(response["taskUid"], 1);
2021-06-29 11:57:47 +02:00
}
/// Here we try sending encoded (compressed) document request
#[actix_rt::test]
async fn add_single_document_gzip_encoded() {
let document = json!({
"id": 1,
"content": "Bouvier Bernois",
});
// this is a what is expected and should work
let server = Server::new().await;
2022-10-20 17:08:52 +02:00
let app = server.init_web_app().await;
// post
let document = serde_json::to_string(&document).unwrap();
let encoder = Encoder::Gzip;
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(encoder.encode(document.clone()))
.insert_header(("content-type", "application/json"))
.insert_header(encoder.header().unwrap())
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 202);
assert_eq!(response["taskUid"], 0);
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(encoder.encode(document))
.insert_header(("content-type", "application/json"))
.insert_header(encoder.header().unwrap())
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 202);
assert_eq!(response["taskUid"], 1);
}
/// Here we try document request with every encoding
#[actix_rt::test]
async fn add_single_document_with_every_encoding() {
let document = json!({
"id": 1,
"content": "Bouvier Bernois",
});
// this is a what is expected and should work
let server = Server::new().await;
2022-10-20 17:08:52 +02:00
let app = server.init_web_app().await;
// post
let document = serde_json::to_string(&document).unwrap();
for (task_uid, encoder) in Encoder::iterator().enumerate() {
let mut req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(encoder.encode(document.clone()))
.insert_header(("content-type", "application/json"));
req = match encoder.header() {
Some(header) => req.insert_header(header),
None => req,
};
let req = req.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 202);
assert_eq!(response["taskUid"], task_uid);
}
}
2021-10-21 14:42:01 +02:00
/// any other content-type is must be refused
2021-06-29 11:57:47 +02:00
#[actix_rt::test]
2021-10-21 14:42:01 +02:00
async fn error_add_documents_test_bad_content_types() {
2021-06-29 11:57:47 +02:00
let document = json!([
{
"id": 1,
2021-10-21 14:42:01 +02:00
"content": "Leonberg",
2021-06-29 11:57:47 +02:00
}
]);
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
// post
2021-06-29 11:57:47 +02:00
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-21 14:42:01 +02:00
.insert_header(("content-type", "text/plain"))
2021-06-29 11:57:47 +02:00
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
2021-10-21 14:42:01 +02:00
assert_eq!(status_code, 415);
assert_eq!(
response["message"],
json!(
2021-10-26 19:36:48 +02:00
r#"The Content-Type `text/plain` is invalid. Accepted values for the Content-Type header are: `application/json`, `application/x-ndjson`, `text/csv`"#
2021-10-21 14:42:01 +02:00
)
);
assert_eq!(response["code"], "invalid_content_type");
assert_eq!(response["type"], "invalid_request");
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], "https://docs.meilisearch.com/errors#invalid_content_type");
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-21 14:42:01 +02:00
.insert_header(("content-type", "text/plain"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
2021-10-21 14:42:01 +02:00
assert_eq!(status_code, 415);
assert_eq!(
response["message"],
json!(
2021-10-26 19:36:48 +02:00
r#"The Content-Type `text/plain` is invalid. Accepted values for the Content-Type header are: `application/json`, `application/x-ndjson`, `text/csv`"#
2021-10-21 14:42:01 +02:00
)
);
assert_eq!(response["code"], "invalid_content_type");
assert_eq!(response["type"], "invalid_request");
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], "https://docs.meilisearch.com/errors#invalid_content_type");
2021-06-29 11:57:47 +02:00
}
2021-10-21 14:42:01 +02:00
/// missing content-type must be refused
2021-06-29 11:57:47 +02:00
#[actix_rt::test]
2021-10-21 14:42:01 +02:00
async fn error_add_documents_test_no_content_type() {
2021-06-29 11:57:47 +02:00
let document = json!([
{
"id": 1,
"content": "Leonberg",
}
]);
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
// post
2021-06-29 11:57:47 +02:00
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 415);
assert_eq!(
response["message"],
json!(
2021-10-26 19:36:48 +02:00
r#"A Content-Type header is missing. Accepted values for the Content-Type header are: `application/json`, `application/x-ndjson`, `text/csv`"#
)
);
2021-10-21 14:42:01 +02:00
assert_eq!(response["code"], "missing_content_type");
assert_eq!(response["type"], "invalid_request");
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], "https://docs.meilisearch.com/errors#missing_content_type");
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 415);
assert_eq!(
response["message"],
json!(
2021-10-26 19:36:48 +02:00
r#"A Content-Type header is missing. Accepted values for the Content-Type header are: `application/json`, `application/x-ndjson`, `text/csv`"#
)
);
2021-10-21 14:42:01 +02:00
assert_eq!(response["code"], "missing_content_type");
assert_eq!(response["type"], "invalid_request");
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], "https://docs.meilisearch.com/errors#missing_content_type");
2021-10-21 14:42:01 +02:00
}
#[actix_rt::test]
async fn error_add_malformed_csv_documents() {
let document = "id, content\n1234, hello, world\n12, hello world";
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
2021-10-21 14:42:01 +02:00
// post
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-25 14:09:24 +02:00
.insert_header(("content-type", "text/csv"))
2021-10-21 14:42:01 +02:00
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
2021-10-25 14:09:24 +02:00
json!(
2022-03-08 12:26:02 +08:00
r#"The `csv` payload provided is malformed: `CSV error: record 1 (line: 2, byte: 12): found record with 3 fields, but the previous record has 2 fields`."#
2021-10-25 14:09:24 +02:00
)
2021-10-21 14:42:01 +02:00
);
2021-10-25 14:09:24 +02:00
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2021-10-21 14:42:01 +02:00
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-25 14:09:24 +02:00
.insert_header(("content-type", "text/csv"))
2021-10-21 14:42:01 +02:00
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
2021-10-25 14:09:24 +02:00
json!(
2022-03-08 12:26:02 +08:00
r#"The `csv` payload provided is malformed: `CSV error: record 1 (line: 2, byte: 12): found record with 3 fields, but the previous record has 2 fields`."#
2021-10-25 14:09:24 +02:00
)
2021-10-21 14:42:01 +02:00
);
2021-10-25 14:09:24 +02:00
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2021-10-21 14:42:01 +02:00
}
#[actix_rt::test]
async fn error_add_malformed_json_documents() {
let document = r#"[{"id": 1}, {id: 2}]"#;
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
2021-10-21 14:42:01 +02:00
// post
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-25 14:09:24 +02:00
.insert_header(("content-type", "application/json"))
2021-10-21 14:42:01 +02:00
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
2021-10-25 14:09:24 +02:00
json!(
2022-03-25 21:31:23 +08:00
r#"The `json` payload provided is malformed. `Couldn't serialize document value: key must be a string at line 1 column 14`."#
2021-10-25 14:09:24 +02:00
)
2021-10-21 14:42:01 +02:00
);
2021-10-25 14:09:24 +02:00
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2021-10-21 14:42:01 +02:00
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-25 14:09:24 +02:00
.insert_header(("content-type", "application/json"))
2021-10-21 14:42:01 +02:00
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
2021-10-25 14:09:24 +02:00
json!(
2022-03-25 21:31:23 +08:00
r#"The `json` payload provided is malformed. `Couldn't serialize document value: key must be a string at line 1 column 14`."#
)
);
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2022-03-25 21:31:23 +08:00
// truncate
// length = 100
let long = "0123456789".repeat(10);
2022-03-25 21:31:23 +08:00
let document = format!("\"{}\"", long);
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document)
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
json!(
r#"The `json` payload provided is malformed. `Couldn't serialize document value: data are neither an object nor a list of objects`."#
2022-03-25 21:31:23 +08:00
)
);
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2022-03-25 21:31:23 +08:00
2022-03-25 21:33:47 +08:00
// add one more char to the long string to test if the truncating works.
2022-03-25 21:31:23 +08:00
let document = format!("\"{}m\"", long);
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document)
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
json!("The `json` payload provided is malformed. `Couldn't serialize document value: data are neither an object nor a list of objects`.")
2021-10-21 14:42:01 +02:00
);
2021-10-25 14:09:24 +02:00
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2021-10-21 14:42:01 +02:00
}
#[actix_rt::test]
async fn error_add_malformed_ndjson_documents() {
let document = "{\"id\": 1}\n{id: 2}";
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
2021-10-21 14:42:01 +02:00
// post
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-25 14:09:24 +02:00
.insert_header(("content-type", "application/x-ndjson"))
2021-10-21 14:42:01 +02:00
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
2021-10-25 14:09:24 +02:00
json!(
2022-11-30 00:03:22 +08:00
r#"The `ndjson` payload provided is malformed. `Couldn't serialize document value: trailing characters at line 2 column 1`."#
2021-10-25 14:09:24 +02:00
)
2021-10-21 14:42:01 +02:00
);
2021-10-25 14:09:24 +02:00
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2021-10-21 14:42:01 +02:00
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
2021-10-25 14:09:24 +02:00
.insert_header(("content-type", "application/x-ndjson"))
2021-10-21 14:42:01 +02:00
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(
response["message"],
2022-11-30 00:03:22 +08:00
json!("The `ndjson` payload provided is malformed. `Couldn't serialize document value: trailing characters at line 2 column 1`.")
2021-10-21 14:42:01 +02:00
);
2021-10-25 14:09:24 +02:00
assert_eq!(response["code"], json!("malformed_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#malformed_payload"));
2021-06-29 11:57:47 +02:00
}
2021-02-19 19:43:32 +01:00
2021-10-26 19:36:48 +02:00
#[actix_rt::test]
async fn error_add_missing_payload_csv_documents() {
let document = "";
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
2021-10-26 19:36:48 +02:00
// post
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "text/csv"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(response["message"], json!(r#"A csv payload is missing."#));
assert_eq!(response["code"], json!("missing_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#missing_payload"));
2021-10-26 19:36:48 +02:00
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "text/csv"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(response["message"], json!(r#"A csv payload is missing."#));
assert_eq!(response["code"], json!("missing_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#missing_payload"));
2021-10-26 19:36:48 +02:00
}
#[actix_rt::test]
async fn error_add_missing_payload_json_documents() {
let document = "";
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
2021-10-26 19:36:48 +02:00
// post
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(response["message"], json!(r#"A json payload is missing."#));
assert_eq!(response["code"], json!("missing_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#missing_payload"));
2021-10-26 19:36:48 +02:00
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/json"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
assert_eq!(response["message"], json!(r#"A json payload is missing."#));
assert_eq!(response["code"], json!("missing_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#missing_payload"));
2021-10-26 19:36:48 +02:00
}
#[actix_rt::test]
async fn error_add_missing_payload_ndjson_documents() {
let document = "";
let server = Server::new().await;
2022-10-18 15:14:18 +02:00
let app = server.init_web_app().await;
2021-10-26 19:36:48 +02:00
// post
let req = test::TestRequest::post()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/x-ndjson"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
2022-10-20 18:00:07 +02:00
assert_eq!(response["message"], json!(r#"A ndjson payload is missing."#));
2021-10-26 19:36:48 +02:00
assert_eq!(response["code"], json!("missing_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#missing_payload"));
2021-10-26 19:36:48 +02:00
// put
let req = test::TestRequest::put()
.uri("/indexes/dog/documents")
.set_payload(document.to_string())
.insert_header(("content-type", "application/x-ndjson"))
.to_request();
let res = test::call_service(&app, req).await;
let status_code = res.status();
let body = test::read_body(res).await;
let response: Value = serde_json::from_slice(&body).unwrap_or_default();
assert_eq!(status_code, 400);
2022-10-20 18:00:07 +02:00
assert_eq!(response["message"], json!(r#"A ndjson payload is missing."#));
2021-10-26 19:36:48 +02:00
assert_eq!(response["code"], json!("missing_payload"));
assert_eq!(response["type"], json!("invalid_request"));
2022-10-20 18:00:07 +02:00
assert_eq!(response["link"], json!("https://docs.meilisearch.com/errors#missing_payload"));
2021-10-26 19:36:48 +02:00
}
2021-02-19 19:43:32 +01:00
#[actix_rt::test]
async fn add_documents_no_index_creation() {
let server = Server::new().await;
let index = server.index("test");
let documents = json!([
{
"id": 1,
"content": "foo",
}
]);
let (response, code) = index.add_documents(documents, None).await;
assert_eq!(code, 202);
assert_eq!(response["taskUid"], 0);
/*
* currently we dont check these field to stay ISO with meilisearch
* assert_eq!(response["status"], "pending");
* assert_eq!(response["meta"]["type"], "DocumentsAddition");
* assert_eq!(response["meta"]["format"], "Json");
* assert_eq!(response["meta"]["primaryKey"], Value::Null);
* assert!(response.get("enqueuedAt").is_some());
*/
2021-02-19 19:43:32 +01:00
index.wait_task(0).await;
2021-02-19 19:43:32 +01:00
let (response, code) = index.get_task(0).await;
2021-02-19 19:43:32 +01:00
assert_eq!(code, 200);
assert_eq!(response["status"], "succeeded");
assert_eq!(response["uid"], 0);
2022-05-25 12:05:24 +02:00
assert_eq!(response["type"], "documentAdditionOrUpdate");
assert_eq!(response["details"]["receivedDocuments"], 1);
assert_eq!(response["details"]["indexedDocuments"], 1);
2021-02-19 19:43:32 +01:00
2021-03-15 18:11:10 +01:00
let processed_at =
OffsetDateTime::parse(response["finishedAt"].as_str().unwrap(), &Rfc3339).unwrap();
2021-03-15 18:11:10 +01:00
let enqueued_at =
OffsetDateTime::parse(response["enqueuedAt"].as_str().unwrap(), &Rfc3339).unwrap();
2021-05-03 14:21:09 +02:00
assert!(processed_at > enqueued_at);
2021-02-19 19:43:32 +01:00
// index was created, and primary key was inferred.
2021-02-19 19:43:32 +01:00
let (response, code) = index.get().await;
assert_eq!(code, 200);
assert_eq!(response["primaryKey"], "id");
}
2021-03-10 14:43:10 +01:00
#[actix_rt::test]
2021-10-21 14:42:01 +02:00
async fn error_document_add_create_index_bad_uid() {
2021-03-10 14:43:10 +01:00
let server = Server::new().await;
let index = server.index("883 fj!");
let (response, code) = index.add_documents(json!([{"id": 1}]), None).await;
2021-10-21 14:42:01 +02:00
let expected_response = json!({
Bring back `release-v0.30.0` into `release-v0.30.0-temp` (final: into `main`) (#3145) * Fix error code of the "duplicate index found" error * Use the content of the ProcessingTasks in the tasks cancelation system * Change the missing_filters error code into missing_task_filters * WIP Introduce the invalid_task_uid error code * Use more precise error codes/message for the task routes + Allow star operator in delete/cancel tasks + rename originalQuery to originalFilters + Display error/canceled_by in task view even when they are = null + Rename task filter fields by using their plural forms + Prepare an error code for canceledBy filter + Only return global tasks if the API key action `index.*` is there * Add canceledBy task filter * Update tests following task API changes * Rename original_query to original_filters everywhere * Update more insta-snap tests * Make clippy happy They're a happy clip now. * Make rustfmt happy >:-( * Fix Index name parsing error message to fit the specification * Bump milli version to 0.35.1 * Fix the new error messages * fix the error messages and add tests * rename the error codes for the sake of consistency * refactor the way we send the cli informations + add the analytics for the config file and ssl usage * Apply suggestions from code review Co-authored-by: Clément Renault <clement@meilisearch.com> * add a comment over the new infos structure * reformat, sorry @kero * Store analytics for the documents deletions * Add analytics on all the settings * Spawn threads with names * Spawn rayon threads with names * update the distinct attributes to the spec update * update the analytics on the search route * implements the analytics on the health and version routes * Fix task details serialization * Add the question mark to the task deletion query filter * Add the question mark to the task cancelation query filter * Fix tests * add analytics on the task route * Add all the missing fields of the new task query type * Create a new analytics for the task deletion * Create a new analytics for the task creation * batch the tasks seen events * Update the finite pagination analytics * add the analytics of the swap-indexes route * Stop removing the DB when failing to read it * Rename originalFilters into originalFilters * Rename matchedDocuments into providedIds * Add `workflow_dispatch` to flaky.yml * Bump grenad to 0.4.4 * Bump milli to version v0.37.0 * Don't multiply total memory returned by sysinfo anymore sysinfo now returns bytes rather than KB * Add a dispatch to the publish binaries workflow * Fix publish release CI * Don't use gold but the default linker * Always display details for the indexDeletion task * Fix the insta tests * refactorize the whole test suite 1. Make a call to assert_internally_consistent automatically when snapshoting the scheduler. There is no point in snapshoting something broken and expect the dumb humans to notice. 2. Replace every possible call to assert_internally_consistent by a snapshot of the scheduler. It takes as many lines and ensure we never change something without noticing in any tests ever. 3. Name every snapshots: it's easier to debug when something goes wrong and easier to review in general. 4. Stop skipping breakpoints, it's too easy to miss something. Now you must explicitely show which path is the scheduler supposed to use. 5. Add a timeout on the channel.recv, it eases the process of writing tests, now when something file you get a failure instead of a deadlock. * rebase on release-v0.30 * makes clippy happy * update the snapshots after a rebase * try to remove the flakyness of the failing test * Add more analytics on the ranking rules positions * Update the dump test to check for the dumpUid dumpCreation task details * send the ranking rules as a string because amplitude is too dumb to process an array as a single value * Display a null dumpUid until we computed the dump itself on disk * Update tests * Check if the master key is missing before returning an error Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: ManyTheFish <many@meilisearch.com> Co-authored-by: Tamo <tamo@meilisearch.com> Co-authored-by: Louis Dureuil <louis@meilisearch.com>
2022-11-28 16:27:41 +01:00
"message": "`883 fj!` is not a valid index uid. Index uid can be an integer or a string containing only alphanumeric characters, hyphens (-) and underscores (_).",
2021-10-21 14:42:01 +02:00
"code": "invalid_index_uid",
"type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#invalid_index_uid"
});
2021-03-10 14:43:10 +01:00
assert_eq!(code, 400);
assert_eq!(response, expected_response);
2021-03-10 14:43:10 +01:00
}
2021-02-19 19:43:32 +01:00
#[actix_rt::test]
async fn document_addition_with_primary_key() {
let server = Server::new().await;
let index = server.index("test");
let documents = json!([
{
"primary": 1,
"content": "foo",
}
]);
2021-04-22 10:14:29 +02:00
let (response, code) = index.add_documents(documents, Some("primary")).await;
assert_eq!(code, 202, "response: {}", response);
2021-02-22 15:13:10 +01:00
index.wait_task(0).await;
2021-02-22 15:13:10 +01:00
let (response, code) = index.get_task(0).await;
2021-02-22 15:13:10 +01:00
assert_eq!(code, 200);
assert_eq!(response["status"], "succeeded");
assert_eq!(response["uid"], 0);
2022-05-25 12:05:24 +02:00
assert_eq!(response["type"], "documentAdditionOrUpdate");
assert_eq!(response["details"]["receivedDocuments"], 1);
assert_eq!(response["details"]["indexedDocuments"], 1);
2021-02-22 15:13:10 +01:00
let (response, code) = index.get().await;
2021-02-19 19:43:32 +01:00
assert_eq!(code, 200);
2021-02-22 15:13:10 +01:00
assert_eq!(response["primaryKey"], "primary");
}
2021-02-19 19:43:32 +01:00
#[actix_rt::test]
async fn replace_document() {
let server = Server::new().await;
let index = server.index("test");
let documents = json!([
{
"doc_id": 1,
"content": "foo",
}
]);
2021-04-22 10:14:29 +02:00
let (response, code) = index.add_documents(documents, None).await;
assert_eq!(code, 202, "response: {}", response);
2021-02-19 19:43:32 +01:00
index.wait_task(0).await;
2021-02-19 19:43:32 +01:00
let documents = json!([
{
"doc_id": 1,
"other": "bar",
}
]);
let (_response, code) = index.add_documents(documents, None).await;
assert_eq!(code, 202);
2021-02-19 19:43:32 +01:00
index.wait_task(1).await;
2021-02-19 19:43:32 +01:00
let (response, code) = index.get_task(1).await;
2021-02-19 19:43:32 +01:00
assert_eq!(code, 200);
assert_eq!(response["status"], "succeeded");
2021-02-19 19:43:32 +01:00
let (response, code) = index.get_document(1, None).await;
assert_eq!(code, 200);
assert_eq!(response.to_string(), r##"{"doc_id":1,"other":"bar"}"##);
}
#[actix_rt::test]
async fn add_no_documents() {
2021-02-19 19:43:32 +01:00
let server = Server::new().await;
let index = server.index("test");
let (_response, code) = index.add_documents(json!([]), None).await;
assert_eq!(code, 202);
2021-02-19 19:43:32 +01:00
}
#[actix_rt::test]
async fn add_larger_dataset() {
let server = Server::new().await;
let index = server.index("test");
let update_id = index.load_test_set().await;
let (response, code) = index.get_task(update_id).await;
2021-02-19 19:43:32 +01:00
assert_eq!(code, 200);
assert_eq!(response["status"], "succeeded");
2022-05-25 12:05:24 +02:00
assert_eq!(response["type"], "documentAdditionOrUpdate");
assert_eq!(response["details"]["indexedDocuments"], 77);
assert_eq!(response["details"]["receivedDocuments"], 77);
2021-03-15 18:11:10 +01:00
let (response, code) = index
2022-10-20 18:00:07 +02:00
.get_all_documents(GetAllDocumentsOptions { limit: Some(1000), ..Default::default() })
2021-03-15 18:11:10 +01:00
.await;
assert_eq!(code, 200, "failed with `{}`", response);
assert_eq!(response["results"].as_array().unwrap().len(), 77);
2021-02-22 15:13:10 +01:00
}
2021-02-22 14:55:40 +01:00
#[actix_rt::test]
2021-10-21 14:42:01 +02:00
async fn error_add_documents_bad_document_id() {
2021-02-22 14:55:40 +01:00
let server = Server::new().await;
let index = server.index("test");
index.create(Some("docid")).await;
let documents = json!([
{
"docid": "foo & bar",
"content": "foobar"
}
]);
index.add_documents(documents, None).await;
index.wait_task(1).await;
let (response, code) = index.get_task(1).await;
2021-02-22 14:55:40 +01:00
assert_eq!(code, 200);
2021-10-26 19:36:48 +02:00
assert_eq!(response["status"], json!("failed"));
2022-05-18 18:45:53 +02:00
assert_eq!(
response["error"]["message"],
json!(
r#"Document identifier `"foo & bar"` is invalid. A document identifier can be of type integer or string, only composed of alphanumeric characters (a-z A-Z 0-9), hyphens (-) and underscores (_)."#
)
);
assert_eq!(response["error"]["code"], json!("invalid_document_id"));
assert_eq!(response["error"]["type"], json!("invalid_request"));
assert_eq!(
response["error"]["link"],
json!("https://docs.meilisearch.com/errors#invalid_document_id")
);
2021-02-22 14:55:40 +01:00
}
2021-02-22 15:13:10 +01:00
2021-10-21 14:42:01 +02:00
#[actix_rt::test]
async fn error_add_documents_missing_document_id() {
let server = Server::new().await;
let index = server.index("test");
index.create(Some("docid")).await;
let documents = json!([
{
"id": "11",
"content": "foobar"
}
]);
index.add_documents(documents, None).await;
index.wait_task(1).await;
let (response, code) = index.get_task(1).await;
2021-10-21 14:42:01 +02:00
assert_eq!(code, 200);
assert_eq!(response["status"], "failed");
assert_eq!(
response["error"]["message"],
json!(r#"Document doesn't have a `docid` attribute: `{"id":"11","content":"foobar"}`."#)
);
assert_eq!(response["error"]["code"], json!("missing_document_id"));
assert_eq!(response["error"]["type"], json!("invalid_request"));
assert_eq!(
response["error"]["link"],
json!("https://docs.meilisearch.com/errors#missing_document_id")
);
2021-10-21 14:42:01 +02:00
}
#[actix_rt::test]
#[ignore] // // TODO: Fix in an other PR: this does not provoke any error.
async fn error_document_field_limit_reached() {
let server = Server::new().await;
let index = server.index("test");
index.create(Some("id")).await;
let mut big_object = std::collections::HashMap::new();
big_object.insert("id".to_owned(), "wow");
for i in 0..65535 {
let key = i.to_string();
big_object.insert(key, "I am a text!");
}
let documents = json!([big_object]);
let (_response, code) = index.update_documents(documents, Some("id")).await;
assert_eq!(code, 202);
index.wait_task(0).await;
let (response, code) = index.get_task(0).await;
assert_eq!(code, 200);
// Documents without a primary key are not accepted.
assert_eq!(response["status"], "failed");
2021-11-04 17:03:13 +01:00
let expected_error = json!({
"message": "A document cannot contain more than 65,535 fields.",
"code": "document_fields_limit_reached",
"type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#document_fields_limit_reached"
});
assert_eq!(response["error"], expected_error);
}
2021-10-21 14:42:01 +02:00
#[actix_rt::test]
2022-05-16 17:16:53 +02:00
async fn add_documents_invalid_geo_field() {
2021-10-21 14:42:01 +02:00
let server = Server::new().await;
let index = server.index("test");
index.create(Some("id")).await;
2022-10-20 18:00:07 +02:00
index.update_settings(json!({"sortableAttributes": ["_geo"]})).await;
2021-11-03 14:25:49 +01:00
2021-10-21 14:42:01 +02:00
let documents = json!([
{
"id": "11",
"_geo": "foobar"
}
]);
2021-11-03 14:25:49 +01:00
2021-10-21 14:42:01 +02:00
index.add_documents(documents, None).await;
index.wait_task(2).await;
let (response, code) = index.get_task(2).await;
2021-10-21 14:42:01 +02:00
assert_eq!(code, 200);
2022-06-16 15:58:39 +02:00
assert_eq!(response["status"], "failed");
2021-10-21 14:42:01 +02:00
}
#[actix_rt::test]
async fn error_add_documents_payload_size() {
let server = Server::new().await;
let index = server.index("test");
index.create(Some("id")).await;
let document = json!(
{
"id": "11",
"content": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec metus erat, consequat in blandit venenatis, ultricies eu ipsum. Etiam luctus elit et mollis ultrices. Nam turpis risus, dictum non eros in, eleifend feugiat elit. Morbi non dolor pulvinar, sagittis mi sed, ultricies lorem. Nulla ultricies sem metus. Donec at suscipit quam, sed elementum mi. Suspendisse potenti. Fusce pharetra turpis tortor, sed eleifend odio dapibus ut. Nulla facilisi. Suspendisse elementum, dui eget aliquet dignissim, ex tellus aliquam nisl, at eleifend nisl metus tempus diam. Mauris fermentum sollicitudin efficitur. Donec dignissim est vitae elit finibus faucibus"
}
);
let documents: Vec<_> = (0..16000).into_iter().map(|_| document.clone()).collect();
let documents = json!(documents);
let (response, code) = index.add_documents(documents, None).await;
let expected_response = json!({
2021-10-26 19:36:48 +02:00
"message": "The provided payload reached the size limit.",
2021-10-21 14:42:01 +02:00
"code": "payload_too_large",
"type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#payload_too_large"
});
assert_eq!(response, expected_response);
assert_eq!(code, 413);
2021-02-22 15:13:10 +01:00
}
2021-11-04 13:38:44 +01:00
#[actix_rt::test]
async fn error_primary_key_inference() {
let server = Server::new().await;
let index = server.index("test");
let documents = json!([
{
"title": "11",
"desc": "foobar"
}
]);
index.add_documents(documents, None).await;
index.wait_task(0).await;
let (response, code) = index.get_task(0).await;
2021-11-04 13:38:44 +01:00
assert_eq!(code, 200);
assert_eq!(response["status"], "failed");
2021-11-04 17:03:13 +01:00
let expected_error = json!({
"message": r#"The primary key inference process failed because the engine did not find any fields containing `id` substring in their name. If your document identifier does not contain any `id` substring, you can set the primary key of the index."#,
"code": "primary_key_inference_failed",
"type": "invalid_request",
"link": "https://docs.meilisearch.com/errors#primary_key_inference_failed"
});
assert_eq!(response["error"], expected_error);
2021-11-04 13:38:44 +01:00
}
#[actix_rt::test]
async fn add_documents_with_primary_key_twice() {
let server = Server::new().await;
let index = server.index("test");
let documents = json!([
{
"title": "11",
"desc": "foobar"
}
]);
index.add_documents(documents.clone(), Some("title")).await;
index.wait_task(0).await;
let (response, _code) = index.get_task(0).await;
assert_eq!(response["status"], "succeeded");
index.add_documents(documents, Some("title")).await;
index.wait_task(1).await;
let (response, _code) = index.get_task(1).await;
assert_eq!(response["status"], "succeeded");
}
2022-08-10 16:42:26 +02:00
#[actix_rt::test]
async fn batch_several_documents_addition() {
let server = Server::new().await;
let index = server.index("test");
let mut documents: Vec<_> = (0..150usize)
.into_iter()
.map(|id| {
json!(
{
"id": id,
"title": "foo",
"desc": "bar"
}
)
})
.collect();
documents[100] = json!({"title": "error", "desc": "error"});
// enqueue batch of documents
2022-08-16 15:14:01 +02:00
let mut waiter = Vec::new();
2022-08-10 16:42:26 +02:00
for chunk in documents.chunks(30) {
2022-08-16 15:14:01 +02:00
waiter.push(index.add_documents(json!(chunk), Some("id")));
2022-08-10 16:42:26 +02:00
}
// wait first batch of documents to finish
2022-08-16 15:14:01 +02:00
futures::future::join_all(waiter).await;
2022-08-10 16:42:26 +02:00
index.wait_task(4).await;
// run a second completely failing batch
2022-08-11 13:35:35 +02:00
documents[40] = json!({"title": "error", "desc": "error"});
documents[70] = json!({"title": "error", "desc": "error"});
documents[130] = json!({"title": "error", "desc": "error"});
2022-08-16 15:14:01 +02:00
let mut waiter = Vec::new();
2022-08-10 16:42:26 +02:00
for chunk in documents.chunks(30) {
2022-08-16 15:14:01 +02:00
waiter.push(index.add_documents(json!(chunk), Some("id")));
2022-08-10 16:42:26 +02:00
}
// wait second batch of documents to finish
2022-08-16 15:14:01 +02:00
futures::future::join_all(waiter).await;
2022-08-10 16:42:26 +02:00
index.wait_task(9).await;
2022-08-16 15:14:01 +02:00
let (response, _code) = index.filtered_tasks(&[], &["failed"]).await;
2022-08-10 16:42:26 +02:00
// Check if only the 6th task failed
2022-08-16 15:14:01 +02:00
println!("{}", &response);
assert_eq!(response["results"].as_array().unwrap().len(), 5);
2022-08-10 16:42:26 +02:00
// Check if there are exactly 120 documents (150 - 30) in the index;
let (response, code) = index
2022-10-20 18:00:07 +02:00
.get_all_documents(GetAllDocumentsOptions { limit: Some(200), ..Default::default() })
2022-08-10 16:42:26 +02:00
.await;
assert_eq!(code, 200, "failed with `{}`", response);
assert_eq!(response["results"].as_array().unwrap().len(), 120);
}