remove the awkward default_tsa parameter

default_tsa pointing to a specific tsa section doesn't make sense.
removing it.

conf/uts-server.cnf

@@ -102,15 +102,9 @@ tcp_nodelay = 0
 # Loglevel (debug, info, notice, warn, err, emerg, crit)
 log_level = info
 
-# Section defining which TSA section to use.
+# TSA configuration parameters
 [ tsa ]
 
-# Name of the TSA section to use as default.
-default_tsa = tsa_config1
-
-# Example of Time-Stamp section configuration.
-[ tsa_config1 ]
-
 # TSA root directory.
 dir = /etc/uts-server/pki
 

inc/rfc3161.h

@@ -14,6 +14,7 @@
 
 /* Name of config entry that defines the OID file. */
 #define OID_SECTION "oids"
+#define TSA_SECTION "tsa"
 
 // number of char we get to log for the serial
 #define SERIAL_ID_SIZE 8

src/lib/rfc3161.c

@@ -120,11 +120,11 @@ TS_RESP_CTX *create_tsctx(rfc3161_context *ct, CONF *conf, const char *section,
     TS_RESP_CTX *resp_ctx = NULL;
 
     // recover the section defining the default tsa
-    if ((section = TS_CONF_get_tsa_section(conf, section)) == NULL) {
-        uts_logger(ct, LOG_ERR, "failed to get or use '%s' in section [ %s ]",
-                   "default_tsa", "tsa");
-        goto end;
-    }
+    //if ((section = TS_CONF_get_tsa_section(conf, section)) == NULL) {
+    //    uts_logger(ct, LOG_ERR, "failed to get or use '%s' in section [ %s ]",
+    //               "default_tsa", "tsa");
+    //    goto end;
+    //}
     if ((resp_ctx = TS_RESP_CTX_new()) == NULL) {
         uts_logger(ct, LOG_ERR, "failed to initialize tsa context");
         goto end;

src/lib/utils.c

@@ -362,7 +362,7 @@ int set_params(rfc3161_context *ct, char *conf_file, char *conf_wd) {
     ct->ts_ctx_pool = calloc(numthreads, sizeof(ts_resp_ctx_wrapper));
     ct->numthreads = numthreads;
     for (int i = 0; i < numthreads; i++) {
-        ct->ts_ctx_pool[i].ts_ctx = create_tsctx(ct, ct->conf, NULL, NULL);
+        ct->ts_ctx_pool[i].ts_ctx = create_tsctx(ct, ct->conf, TSA_SECTION, NULL);
         ct->ts_ctx_pool[i].available = 1;
         if (ct->ts_ctx_pool[i].ts_ctx == NULL)
             ret = 0;

tests/cfg/uts-server-ssl.cnf

@@ -81,13 +81,6 @@ log_level = info
 ####################################################################
 [ tsa ]
 
-# The default TSA section.
-default_tsa = tsa_config1
-
-[ tsa_config1 ]
-
-# These are used by the TSA reply generation only.
-
 # TSA root directory
 dir		= ./pki
 

tests/cfg/uts-server.cnf

@@ -81,13 +81,6 @@ log_level = info
 ####################################################################
 [ tsa ]
 
-# The default TSA section.
-default_tsa = tsa_config1
-
-[ tsa_config1 ]
-
-# These are used by the TSA reply generation only.
-
 # TSA root directory
 dir		= ./pki