security-and-privacy/mat2
security-and-privacy/mat2
1
0
Fork 0
mirror of synced 2024-11-22 09:14:23 +01:00
Code Releases Activity

Please pylint by iterating on dict directly, instead of calling .keys()

Browse Source
This commit is contained in:
jvoisin 2021-12-26 15:23:26 +01:00
parent 48680b9852
commit 3378f3ab8c
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libmat2/office.py
View File

@ -179,7 +179,7 @@ class MSOfficeParser(ZipParser):
return False return False
# rsid, tags or attributes, are always under the `w` namespace # rsid, tags or attributes, are always under the `w` namespace
if 'w' not in namespace.keys(): if 'w' not in namespace:
return True return True
parent_map = {c:p for p in tree.iter() for c in p} parent_map = {c:p for p in tree.iter() for c in p}
@ -215,7 +215,7 @@ class MSOfficeParser(ZipParser):
return False return False
# The nsid tag is always under the `w` namespace # The nsid tag is always under the `w` namespace
if 'w' not in namespace.keys(): if 'w' not in namespace:
return True return True
parent_map = {c:p for p in tree.iter() for c in p} parent_map = {c:p for p in tree.iter() for c in p}
@ -328,7 +328,7 @@ class MSOfficeParser(ZipParser):
logging.error("Unable to parse %s: %s", full_path, e) logging.error("Unable to parse %s: %s", full_path, e)
return False return False
if 'p14' not in namespace.keys(): if 'p14' not in namespace:
return True # pragma: no cover return True # pragma: no cover
for item in tree.iterfind('.//p14:creationId', namespace): for item in tree.iterfind('.//p14:creationId', namespace):
@ -344,7 +344,7 @@ class MSOfficeParser(ZipParser):
logging.error("Unable to parse %s: %s", full_path, e) logging.error("Unable to parse %s: %s", full_path, e)
return False return False
if 'p' not in namespace.keys(): if 'p' not in namespace:
return True # pragma: no cover return True # pragma: no cover
for item in tree.iterfind('.//p:sldMasterId', namespace): for item in tree.iterfind('.//p:sldMasterId', namespace):
@ -486,7 +486,7 @@ class LibreOfficeParser(ZipParser):
logging.error("Unable to parse %s: %s", full_path, e) logging.error("Unable to parse %s: %s", full_path, e)
return False return False
if 'office' not in namespace.keys(): # no revisions in the current file if 'office' not in namespace: # no revisions in the current file
return True return True
for text in tree.getroot().iterfind('.//office:text', namespace): for text in tree.getroot().iterfind('.//office:text', namespace):