Commit Graph

129 Commits

Author SHA1 Message Date
kakwa bbafafae60 remove the double escaping.
Now the escaping is done by in the templates.
We need to remove the previous escaping done by hand in the code.
Otherwise, we end-up with double escaping and funky displaying of
fields.
2019-02-12 21:18:45 +01:00
kakwa e6bcf9d97d adding the possibility to log to stdout 2019-02-10 18:12:45 +01:00
kakwa b68214022c fix error handling when adding user that already exists 2019-02-09 20:47:34 +01:00
kakwa 90ff69586b remove deprecation warning for html escape
in python 2, (html) escape is part of the cgi module
in python 3, it's part of the html module

we now do a conditional import depending on the version, and name the
function html_escape.
2019-02-09 16:29:16 +01:00
kakwa 8c0bf94904 better log+fix in conf checking + fix in ppolicy handler
* log where the backend is declared (role or attribute) when
inconsistency with main .ini file
* fix check of configuration, only role file was checked 2 times instead
on checking role one time and attribute one time
* <dict>.keys() seems to have a different behavior between 2 (return
"list") and 3 (return "dict_keys"), casting to "list" to avoid that.
2019-02-08 20:38:29 +01:00
kakwa 3d6e24eb73 pep8 2019-02-07 20:16:39 +01:00
kakwa ccc252965d fix another __import__ 2019-02-06 23:04:23 +01:00
kakwa 74dc6c5894 various changes to support python3
* changes in urllib imports since quote_plus in urllib with python 2 and
in urllib.parse in python 3
* changes in imports for Sets since set is a native type in python 3 and
doesn't requires an import
* fix in __import__, '-1' level for module path discovery is not supported
anymore, switching to 0 (absolute import only).
2019-02-06 22:32:40 +01:00
John Thiltges 6f98076281 Protect against XSS vulnerabilities in URL redirection
- Switch from base64 to URL encoding for the passing the URL, using the built-in Mako filtering
- Apply HTML filtering to Mako output by default
- Disable HTML filtering for nested templates in adduser, modify, and selfmodify
2019-01-02 14:31:10 -06:00
kakwa f357adcd9a put version in standalone file
this way, it avoids error due to missing imports
2017-04-06 20:34:32 +02:00
kakwa 8270988ed4 changelog + version bump + factorize version 2017-04-06 20:21:31 +02:00
kakwa e4effc64ec fixing log errors in auth "none" mode
replacing None by unknown as a default value in order to avoid
error in generating log msg because None is not a string
2017-03-12 17:45:01 +01:00
kakwa 3a1966324d adding more try catch for template debugging 2017-03-07 22:34:05 +01:00
kakwa 819e575a28 pep8ification 2017-03-07 22:23:11 +01:00
Stan Rudenko e1a27aa0a7 adding support for display template parse error 2017-03-02 19:06:54 -08:00
kakwa d820cceeb6 pep8 2016-07-31 11:41:42 +02:00
kakwa d4235bc33c better behavior if user doesn't exist in one backend 2016-07-31 11:39:28 +02:00
kakwa fec09b1543 don't stop on UserDoesntExist exception on delete
previously, if a user didn't exist in one backend, the _deleteuser
function in ldapcherry would stop on the UserDoesntExist exception,
potentially leaving the user in other backends.
Now it logs it and continues to delete the user in other backend.
2016-07-31 10:06:17 +02:00
kakwa a84ee528aa 403 flag for _check_auth + fix default 404 page
_check_auth can now return a 403 error instead of redirected to
the login page if needed (in case of the checkppolicy for example).
The default page handles post data and querystring better now.
2016-07-29 22:56:56 +02:00
kakwa 14afde33b5 fix pep 8 2016-07-10 08:29:40 +02:00
kakwa f3fabe502e disable min search lenght for admin search 2016-07-10 08:10:19 +02:00
kakwa c2f6b95fb0 fix html escape for lonely groups 2016-07-10 07:40:56 +02:00
kakwa 0beac119f9 fix many error with html unescaped attributes 2016-07-08 21:46:00 +02:00
kakwa 6c3fb4975d fix many encoding errors on login and password 2016-07-07 20:22:33 +02:00
kakwa ebc5b69374 implement the display of users attributes on index page 2016-07-07 08:01:57 +02:00
kakwa c64bb11504 add a default handler for 404 requests 2016-07-06 22:50:59 +02:00
kakwa 8b0e68d9db implementing debug mode in console 2016-07-06 21:54:08 +02:00
kakwa baee15c40f properly implementing minimum lenght limit in search 2016-07-06 20:47:33 +02:00
kakwa e981451431 fix notification adding error
The test on whether the user notification queue existed or not was just wrong.
2015-11-08 20:15:48 +01:00
Carpentier Pierre-Francois 5caedc91c3 pep8 compliance 2015-11-03 09:14:03 +01:00
kakwa c71645ac99 better log on user deletion (adding deteled **by user**) 2015-11-03 08:54:17 +01:00
kakwa 451c59e875 it's more logical to do the auth check before anything... 2015-11-02 23:17:49 +01:00
kakwa fdba64f9da changing http returns for checkppolicy 2015-11-02 23:16:26 +01:00
kakwa 93cd8a40f6 adding notification for user deletion 2015-10-29 07:36:14 +01:00
kakwa 2451b2efdd adding notification after an action is performed 2015-10-28 23:11:23 +01:00
kakwa 27089f68ef fix pep8 2015-10-20 20:26:41 +02:00
kakwa 9ecd97a8d0 cleaner way to merge user's attributes from different backends 2015-10-20 20:05:22 +02:00
kakwa 2992cac1d7 slightly cleaner way to handle templates loading 2015-10-19 20:36:37 +02:00
kakwa 53676db341 small code reorganization
* extraction of exception decorator
* extraction of log handling
2015-10-19 20:14:49 +02:00
kakwa 61df2094c4 implementing custom js 2015-08-09 10:35:28 +02:00
kakwa ecbf112677 fix unit test on duplicate user exception 2015-07-31 22:54:21 +02:00
kakwa a8af29692e custom error handling for UserDoesntExist, UserAlreadyExists and GroupDoesntExist 2015-07-31 22:43:51 +02:00
kakwa 5561a9f42b typo in comment 2015-07-31 20:32:13 +02:00
kakwa efcaad54fc multiple modification/fix
* add display_name parameter for backend
* handle display_name in modify template (lonely groups) and error
  message
* fix bug in modify when user is in only one backend
* remove redondant exception in ad/ldap backend
* fix unit test accordingly
* fix License in AD backend (GPLv3 -> MIT, previously tought of using
  samba4 python library which is GPL, but this module finaly uses
  python-ldap which is MIT compatible)
2015-07-31 20:08:21 +02:00
kakwa 27fca43ac6 Better exception re-raising
re-raising the exception without specifying the exception object gives
exactly the previous exception (including the correct stacktrace)
which is nicer to have for debugging.
2015-07-28 20:30:51 +02:00
kakwa f6b1128274 adding more debug traces in case of a faulty backend 2015-07-25 22:02:53 +02:00
kakwa 3a6da2e480 better exception handling if user or group doesn't exist 2015-07-15 21:05:38 +02:00
kakwa 77fbb346f1 fix authentifcation 2015-07-14 23:49:09 +02:00
kakwa 5a199ae3fb fix trailling space 2015-07-14 23:38:33 +02:00
kakwa 1703dc9a33 adding global exception handler 2015-07-14 23:37:20 +02:00