security-and-privacy/ldapcherry
security-and-privacy/ldapcherry
1
0
Fork 0
mirror of https://github.com/kakwa/ldapcherry synced 2024-11-25 18:54:29 +01:00
Code Releases Activity

better log+fix in conf checking + fix in ppolicy handler

Browse Source 
* log where the backend is declared (role or attribute) when
inconsistency with main .ini file
* fix check of configuration, only role file was checked 2 times instead
on checking role one time and attribute one time
* <dict>.keys() seems to have a different behavior between 2 (return
"list") and 3 (return "dict_keys"), casting to "list" to avoid that.
This commit is contained in:
kakwa 2019-02-08 20:38:29 +01:00
parent 42759f1cc4
commit 8c0bf94904
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ldapcherry/__init__.py
View File

@ -149,10 +149,10 @@ class LdapCherry(object):
backends = self.backends_params.keys() backends = self.backends_params.keys()
for b in self.roles.get_backends(): for b in self.roles.get_backends():
if b not in backends: if b not in backends:
raise MissingBackend(b) raise MissingBackend(b, 'role')
for b in self.roles.get_backends(): for b in self.attributes.get_backends():
if b not in backends: if b not in backends:
raise MissingBackend(b) raise MissingBackend(b, 'attribute')
def _init_backends(self, config): def _init_backends(self, config):
""" Init all backends """ Init all backends
@ -1003,7 +1003,7 @@ class LdapCherry(object):
def checkppolicy(self, **params): def checkppolicy(self, **params):
""" search user page """ """ search user page """
self._check_auth(must_admin=False, redir_login=False) self._check_auth(must_admin=False, redir_login=False)
keys = params.keys() keys = list(params.keys())
if len(keys) != 1: if len(keys) != 1:
cherrypy.response.status = 400 cherrypy.response.status = 400
return "bad argument" return "bad argument"

7
ldapcherry/exceptions.py
View File

@ -46,11 +46,12 @@ class MissingRole(Exception):
class MissingBackend(Exception): class MissingBackend(Exception):
def __init__(self, backend): def __init__(self, backend, type_conf):
self.backend = backend self.backend = backend
self.log = \ self.log = \
"backend '%(backend)s' does not exist in main config file" % \ "backend '%(backend)s' does not exist in main config file " \
{'backend': backend} "but is still declared in '%(type_conf)s' file" % \
{'backend': backend, 'type_conf': type_conf}
class WrongBackend(Exception): class WrongBackend(Exception):