security-and-privacy/ldapcherry
security-and-privacy/ldapcherry
1
0
Fork 0
mirror of https://github.com/kakwa/ldapcherry synced 2024-11-22 01:14:21 +01:00
Code Releases Activity

improve robustness if user dn attribute contains something like ,cn=

Browse Source
This commit is contained in:
kakwa 2016-07-31 12:21:26 +02:00
parent d820cceeb6
commit 7f00264e32
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ldapcherry/backend/backendLdap.py
View File

@ -311,7 +311,9 @@ class Backend(ldapcherry.backend.Backend):
dn = \ dn = \
self._str(self.dn_user_attr) + \ self._str(self.dn_user_attr) + \
'=' + \ '=' + \
self._str(attrs[self.dn_user_attr]) + \ ldap.dn.escape_dn_chars(
self._str(attrs[self.dn_user_attr])
) + \
',' + \ ',' + \
self._str(self.userdn) self._str(self.userdn)
# gen the ldif fir add_s and add the user # gen the ldif fir add_s and add the user

6
tests/test_BackendLdap.py
View File

@ -172,12 +172,12 @@ class TestError(object):
def testAddUser(self): def testAddUser(self):
try: try:
inv.del_user(u'test☭') inv.del_user(u'test☭,cn=')
except: except:
pass pass
inv = Backend(cfg, cherrypy.log, 'ldap', attr, 'uid') inv = Backend(cfg, cherrypy.log, 'ldap', attr, 'uid')
user = { user = {
'uid': u'test☭', 'uid': u'test☭,cn=',
'sn': u'test☭', 'sn': u'test☭',
'cn': u'test☭', 'cn': u'test☭',
'userPassword': u'test☭', 'userPassword': u'test☭',
@ -186,7 +186,7 @@ class TestError(object):
'homeDirectory': '/home/test/' 'homeDirectory': '/home/test/'
} }
inv.add_user(user) inv.add_user(user)
inv.del_user(u'test☭') inv.del_user(u'test☭,cn=')
def testModifyUser(self): def testModifyUser(self):
inv = Backend(cfg, cherrypy.log, 'ldap', attr, 'uid') inv = Backend(cfg, cherrypy.log, 'ldap', attr, 'uid')