1
0
mirror of git://git.gnupg.org/gnupg.git synced 2024-06-01 22:28:02 +02:00
gnupg/g10
Daniel Kahn Gillmor 91015d021b
gpg: Ensure all weak digest rejection notices are shown
* g10/main.h: Add rejection_shown flag to each weakhash struct
* g10/misc.c (print_digest_algo_note, additional_weak_digest): Do not
treat MD5 separately; (print_digest_rejected_note): Use
weakhash.rejection_shown instead of static shown.
* g10/options.h (opt): Change from additional_weak_digests to
weak_digests.
* g10/sig-check.c: Do not treat MD5 separately.
* g10/gpg.c (main): Explicitly set MD5 as weak.
* g10/gpgv.c (main): Explicitly set MD5 as weak.

--

Previously, only one weak digest rejection message was shown, of
whichever was the first type encountered.  This meant that if "gpg
--weak-digest SHA224" encountered both an MD5 digest and a SHA224
digest, it would only show the user that the MD5 digest was rejected.

In order to let the user know which algorithms were rejected, we
needed to move the "shown" flag into a per-weak-algorithm location.
Given this additional complication, it made no sense to continue to
treat MD5 specially, so it is added as a default weak algorithm in the
same opt.weak_digests data structure as any other.

Signed-Off-By: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
2015-10-26 16:56:56 +01:00
..
armor.c gpg: Replace remaining old error code macros by GPG_ERR_. 2015-01-22 12:06:11 +01:00
build-packet.c gpg: Create all MPIs with RFC-4880 correct length headers. 2015-03-16 20:14:58 +01:00
call-agent.c gpg: Print a new FAILURE status after most commands. 2015-08-25 15:26:33 +02:00
call-agent.h scd: support any curves defined by libgcrypt. 2015-07-25 12:09:23 +09:00
call-dirmngr.c Change capitalization of TOR to Tor. 2015-10-21 18:14:24 +02:00
call-dirmngr.h gpg: Deprecate the --keyserver option. 2015-10-05 17:52:28 +02:00
card-util.c gpg: Add a new OpenPGP card vendor. 2015-10-21 18:23:25 +02:00
ChangeLog-2011 Generate the ChangeLog from commit logs. 2011-12-01 11:09:02 +01:00
cipher.c gpg: Remove options --pgp2 and --rfc1991. 2014-08-14 11:03:55 +02:00
compress-bz2.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
compress.c gpg: Replace remaining old error code macros by GPG_ERR_. 2015-01-22 12:06:11 +01:00
cpr.c gpg: Print a new FAILURE status after most commands. 2015-08-25 15:26:33 +02:00
dearmor.c gpg: Create exported secret files and revocs with mode 700. 2014-06-30 09:12:48 +02:00
decrypt-data.c gpg: Replace remaining old error code macros by GPG_ERR_. 2015-01-22 12:06:11 +01:00
decrypt.c common/iobuf.h: Remove iobuf_open_fd_or_name. 2015-08-20 14:16:22 +02:00
dek.h gpg: Remove cipher.h and put algo ids into a common file. 2014-01-29 20:35:05 +01:00
delkey.c gpg: --delete-secret-key - check that a secret key exists. 2014-09-20 16:27:16 +02:00
dirmngr-conf.skel dirmngr: Add example Tor hidden service. 2015-10-26 16:34:19 +01:00
distsigkey.gpg Add more signing keys. 2014-10-31 14:21:34 +01:00
ecdh.c Curve25519 support. 2015-08-06 17:00:41 +09:00
encrypt.c gpg: Try hard to use MDC also for sign+symenc. 2015-10-12 09:31:44 +02:00
exec.c gpg: Replace remaining old error code macros by GPG_ERR_. 2015-01-22 12:06:11 +01:00
exec.h Changed to GPLv3. 2007-07-04 19:49:40 +00:00
export.c gpg: Add option --print-dane-records. 2015-10-08 15:40:53 +02:00
filter.h gpg: Remove PGP-2 related cruft. 2014-11-13 12:01:42 +01:00
free-packet.c g10: fix cmp_public_key. 2015-05-01 13:58:18 +09:00
getkey.c gpg: Add new --auto-key-locate mechanism "dane". 2015-10-06 20:31:43 +02:00
gpg-w32info.rc w32: Add manifest to gpg. 2015-02-04 09:15:34 +01:00
gpg.c gpg: Ensure all weak digest rejection notices are shown 2015-10-26 16:56:56 +01:00
gpg.h gpg: Replace remaining old error code macros by GPG_ERR_. 2015-01-22 12:06:11 +01:00
gpg.w32-manifest.in w32: Add manifest to gpg. 2015-02-04 09:15:34 +01:00
gpgv.c gpg: Ensure all weak digest rejection notices are shown 2015-10-26 16:56:56 +01:00
helptext.c Change all quotes in strings and comments to the new GNU standard. 2012-06-05 19:29:22 +02:00
import.c g10: Remove unused parameter. 2015-08-31 11:30:54 +02:00
kbnode.c gpg: Fix a missing LF in debug output. 2014-11-13 17:01:17 +01:00
keydb.c g10: Make the keyblock cache per-handle rather than global. 2015-09-02 10:52:01 +02:00
keydb.h g10: Improve documentation and comments for getkey.c. 2015-09-16 15:15:28 +02:00
keyedit.c build: Allow building without SQLlite support. 2015-10-20 17:32:23 +02:00
keygen.c gpg: Pass CTRL parameter to all key listing functions. 2015-10-08 14:55:07 +02:00
keyid.c Curve25519 support. 2015-08-06 17:00:41 +09:00
keylist.c w32: Make it build again if Tofu support is not available. 2015-10-26 16:38:41 +01:00
keyring.c kbx: Change skipfnc's prototype so that we can provide all information. 2015-09-16 15:15:20 +02:00
keyring.h gpg: Add push/pop found state feature to keydb. 2015-05-08 15:51:11 +02:00
keyserver-internal.h gpg: Add new --auto-key-locate mechanism "dane". 2015-10-06 20:31:43 +02:00
keyserver.c Move SRV RR code from common/ to dirmngr/. 2015-10-22 09:22:41 +02:00
main.h gpg: Ensure all weak digest rejection notices are shown 2015-10-26 16:56:56 +01:00
mainproc.c gpg: Improve and regularize naming of signature checking functions. 2015-10-19 20:11:01 +02:00
Makefile.am build: Allow building without SQLlite support. 2015-10-20 17:32:23 +02:00
mdfilter.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
migrate.c gpg: Change wording of a migration error message. 2014-10-09 10:56:25 +02:00
misc.c gpg: Ensure all weak digest rejection notices are shown 2015-10-26 16:56:56 +01:00
openfile.c gpg: Install a dirmngr.conf file. 2015-10-05 19:48:47 +02:00
OPTIONS See ChangeLog: Mon Jul 31 10:04:47 CEST 2000 Werner Koch 2000-07-31 08:04:16 +00:00
options.h gpg: Ensure all weak digest rejection notices are shown 2015-10-26 16:56:56 +01:00
options.skel gpg: Install a dirmngr.conf file. 2015-10-05 19:48:47 +02:00
packet.h gpg: Remove unused prototype digest_algo_from_sig. 2015-10-20 10:21:40 +02:00
parse-packet.c gpg: Fix regression in packet parser from Aug 19. 2015-08-23 12:17:43 +02:00
passphrase.c Fix sending INQUIRE_MAXLEN for symmetric data. 2015-08-16 12:54:04 -04:00
photoid.c gpg: New %U expando for the photo viewer. 2014-04-17 21:44:09 +02:00
photoid.h Decryption and signi via agent is now implemented. 2010-04-23 11:36:59 +00:00
pkclist.c g10: Add TOFU support. 2015-10-18 18:45:40 +02:00
pkglue.c Curve25519 support. 2015-08-06 17:00:41 +09:00
pkglue.h gpg: Use only OpenPGP public key algo ids and add the EdDSA algo id. 2014-01-30 18:48:37 +01:00
plaintext.c gpg: Replace remaining old error code macros by GPG_ERR_. 2015-01-22 12:06:11 +01:00
progress.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
pubkey-enc.c Curve25519 support. 2015-08-06 17:00:41 +09:00
pubring.asc See ChangeLog: Mon Jul 31 10:04:47 CEST 2000 Werner Koch 2000-07-31 08:04:16 +00:00
revoke.c gpg: Fix --desig-revoke. 2015-10-19 20:11:03 +02:00
rmd160.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
rmd160.h Add missing header file. 2008-12-12 08:54:50 +00:00
seckey-cert.c Use inline functions to convert buffer data to scalars. 2015-02-11 10:28:25 +01:00
server.c Remove support for the GPG_AGENT_INFO envvar. 2014-10-03 11:58:58 +02:00
seskey.c gpg: Rename a debug macro. 2015-04-06 13:07:09 +02:00
sig-check.c gpg: Ensure all weak digest rejection notices are shown 2015-10-26 16:56:56 +01:00
sign.c gpg: Try hard to use MDC also for sign+symenc. 2015-10-12 09:31:44 +02:00
skclist.c gpg: Remove cipher.h and put algo ids into a common file. 2014-01-29 20:35:05 +01:00
t-keydb-keyring.kbx g10: Add test for keydb as well as new testing infrastructure. 2015-09-02 15:08:57 +02:00
t-keydb.c g10: Fix make distcheck problem. 2015-09-10 18:12:20 +02:00
t-rmd160.c Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
tdbdump.c gpg: Replace -1 by GPG_ERR_NOT_FOUND in tdbio.c 2015-06-04 18:08:26 +02:00
tdbio.c gpg: Mark local function as static. 2015-10-19 20:11:00 +02:00
tdbio.h gpg: Replace -1 by GPG_ERR_NOT_FOUND in tdbio.c 2015-06-04 18:08:26 +02:00
test-stubs.c gpg: Provide an interface to patch TOFU updates. 2015-10-23 17:38:17 +02:00
test.c g10: Fix make distcheck problem. 2015-09-10 18:12:20 +02:00
textfilter.c gpg: Remove all support for v3 keys and always create v4-signatures. 2014-10-17 13:32:16 +02:00
tofu.c gpg: Make sure we only have a single SQL statement. 2015-10-26 13:41:59 +01:00
tofu.h gpg: Provide an interface to patch TOFU updates. 2015-10-23 17:38:17 +02:00
trust.c g10: Add TOFU support. 2015-10-18 18:45:40 +02:00
trustdb.c gpg: If the saved trust model is unknown, default to tofu+pgp. 2015-10-21 13:45:50 +02:00
trustdb.h gpg: Factor out code into a standalone function. 2015-10-21 13:45:47 +02:00
verify.c gpg: Replace remaining old error code macros by GPG_ERR_. 2015-01-22 12:06:11 +01:00
zlib-riscos.h include: Remove this directory. 2014-01-29 17:45:05 +01:00