gnupg/tests
Werner Koch 43b23aa82b
gpg: Avoid importing secret keys if the keyblock is not valid.
* g10/keydb.h (struct kbnode_struct): Replace unused field RECNO by
new field TAG.
* g10/kbnode.c (alloc_node): Change accordingly.
* g10/import.c (import_one): Add arg r_valid.
(sec_to_pub_keyblock): Set tags.
(resync_sec_with_pub_keyblock): New.
(import_secret_one): Change return code to gpg_error_t.   Return an
error code if sec_to_pub_keyblock failed.  Resync secret keyblock.
--

When importing an invalid secret key ring for example without key
binding signatures or no UIDs, gpg used to let gpg-agent store the
secret keys anyway.  This is clearly a bug because the diagnostics
before claimed that for example the subkeys have been skipped.
Importing the secret key parameters then anyway is surprising in
particular because a gpg -k does not show the key.  After importing
the public key the secret keys suddenly showed up.

This changes the behaviour of
GnuPG-bug-id: 4392
to me more consistent but is not a solution to the actual bug.

Caution: The ecc.scm test now fails because two of the sample keys
         don't have binding signatures.

Signed-off-by: Werner Koch <wk@gnupg.org>
(cherry picked from commit f799e9728b)
2019-03-18 13:16:35 +01:00
..
extrasamples Added sample certificates. 2006-05-16 09:54:41 +00:00
fake-pinentries docs: Point to https://dev.gnupg.org/ . 2017-05-18 15:05:57 -04:00
gpgme tests: Add "disable-scdaemon" in gpg-agent.conf. 2019-03-07 10:50:17 +01:00
gpgscm gpgscm: Build well even if NDEBUG defined. 2019-02-25 10:48:12 +09:00
gpgsm tests: Add "disable-scdaemon" in gpg-agent.conf. 2019-03-07 10:50:17 +01:00
migrations tests: Fix no gpg-agent upon removal of GNUPGHOME. 2018-04-04 20:27:08 +09:00
openpgp gpg: Avoid importing secret keys if the keyblock is not valid. 2019-03-18 13:16:35 +01:00
pkits tests: Add "disable-scdaemon" in gpg-agent.conf. 2019-03-07 10:50:17 +01:00
samplekeys Add the STEED Self-Signing Nonthority certificate. 2011-12-20 15:35:42 +01:00
samplemsgs More samples 2004-02-17 15:07:27 +00:00
567064FE6D14A17B2D811ABB407728BC558AA455 added test certificate and secret key 2001-12-06 20:19:52 +00:00
ChangeLog-2011 Generate the ChangeLog from commit logs. 2011-12-01 11:09:02 +01:00
Makefile.am tests: Make it possible to run all tests using our infrastructure. 2017-05-11 18:12:37 +02:00
asschk.c tests: Fix for NetBSD with __func__. 2018-01-29 09:34:37 +09:00
cert_cci_sphinx_ca.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_cci_test_wzs.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_cci_test_zs.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_cci_user02.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_cci_user03.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_cci_user04.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_cci_user06.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_cci_user07.pem A few test certificates 2002-01-29 15:46:55 +00:00
cert_testpki_testpca.pem A few test certificates 2002-01-29 15:46:55 +00:00
crl_testpki_testpca.pem A few test certificates 2002-01-29 15:46:55 +00:00
inittests tests: Add "disable-scdaemon" in gpg-agent.conf. 2019-03-07 10:50:17 +01:00
key_g10code_pete1.pem released 0.3.5 2002-04-15 17:15:21 +00:00
key_g10code_theo1.pem yet another test certificate 2002-03-28 17:25:28 +00:00
run-tests.scm tests: Make it possible to run all tests using our infrastructure. 2017-05-11 18:12:37 +02:00
runtest Nuked almost all trailing white space. 2011-02-04 12:57:53 +01:00
skey_g10code_test1.pem added test certificate and secret key 2001-12-06 20:19:52 +00:00
sm-sign+verify Tweaked the build system so that make distcheck finanly said Well 2002-08-09 18:16:02 +00:00
sm-verify Tweaked the build system so that make distcheck finanly said Well 2002-08-09 18:16:02 +00:00
text-1.dsig.pem * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00
text-1.osig-bad.pem * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00
text-1.osig-badusage.pem new test certs and messages 2002-09-03 14:54:18 +00:00
text-1.osig.pem * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00
text-1.txt * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00
text-2.osig-bad.pem * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00
text-2.osig.pem * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00
text-2.txt * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00
text-3.txt * asschk.c: Added some new features. 2002-08-08 16:32:01 +00:00