Simon Arlott d9fd52afac g10: Skip signing keys where no secret key is available. ...

* g10/getkey.c (finish_lookup): When requiring PUBKEY_USAGE_SIG, skip
over keys where no signing key is available.

--

This should only be relevant when gpg is required to choose which key
to sign with -- if verifying signatures, we already know which subkey
to look at, and indeed gpg doesn't seem to have a problem with this.

This patch comes from
https://bugs.gnupg.org/gnupg/file793/sign-fix.patch

I (dkg) have reviewed and tested it with missing local keys, and it
makes sense to me as the default behavior.  If the user has the secret
key for a signing-capable subkey available and the command is --sign,
it should be used.

If the user has explicitly specified a subkey that happens to be
missing (e.g. with the trailing ! for --default-key 0x${FPR}!) then
this does not override that behavior (the signature will still fail).

GnuPG-bug-id: 1967
Debian-bug-id: 834922

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

2017-04-25 21:22:48 -04:00

..

armor.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

build-packet.c

gpg: Fix actual leak and possible leaks in the packet parser.

2017-03-30 16:01:52 +02:00

call-agent.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

call-agent.h

agent,g10: Remove redundant SERIALNO request.

2017-03-16 14:32:51 +09:00

call-dirmngr.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

call-dirmngr.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

card-util.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

ChangeLog-2011

Spelling: correct spelling of "passphrase".

2016-11-02 12:53:58 +01:00

cipher.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

compress-bz2.c

g10,tools: Fix bzlib.h include order.

2017-04-11 13:52:19 +09:00

compress.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

cpr.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

dearmor.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

decrypt-data.c

g10: Fix memory leak.

2017-03-28 12:11:02 +02:00

decrypt.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

dek.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

delkey.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

dirmngr-conf.skel

dirmngr: Do not put a keyserver into a new dirmngr.conf

2017-03-08 11:35:53 +01:00

distsigkey.gpg

build: Update distributed signature key.

2016-12-20 10:22:05 +01:00

ecdh.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

encrypt.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

exec.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

exec.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

export.c

g10: Minor fixes.

2017-04-17 09:15:13 +09:00

filter.h

Remove -I option to common.

2017-03-07 20:25:54 +09:00

free-packet.c

gpg: Fix actual leak and possible leaks in the packet parser.

2017-03-30 16:01:52 +02:00

getkey.c

g10: Skip signing keys where no secret key is available.

2017-04-25 21:22:48 -04:00

gpg-w32info.rc

w32: Add manifest to gpg.

2015-02-04 09:15:34 +01:00

gpg.c

w32: Enable wildcard expansion with mingw-w64

2017-04-24 18:10:04 +02:00

gpg.h

gpg: Avoid multiple open calls to the keybox file.

2017-03-31 21:27:16 +02:00

gpg.w32-manifest.in

w32: Add manifest to gpg.

2015-02-04 09:15:34 +01:00

gpgcompose.c

common: Simplify format_text.

2017-04-12 14:47:30 +09:00

gpgsql.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

gpgsql.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

gpgv.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

helptext.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

import.c

g10: Fix import/export filter property match.

2017-04-17 09:08:31 +09:00

kbnode.c

gpg: Extend free_packet to handle a packet parser context.

2017-03-29 12:08:31 +02:00

keydb.c

gpg: Print more stats for the keydb and the signature cache.

2017-03-31 20:08:23 +02:00

keydb.h

gpg: Avoid multiple open calls to the keybox file.

2017-03-31 21:27:16 +02:00

keyedit.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

keygen.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

keyid.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

keylist.c

gpg: Fix printing of offline taken subkey.

2017-04-07 10:13:09 +02:00

keyring.c

g10: invalidate the fd cache for keyring.

2017-04-25 07:48:51 +09:00

keyring.h

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

keyserver-internal.h

Remove -I option to common.

2017-03-07 20:25:54 +09:00

keyserver.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

main.h

gpg: Print more stats for the keydb and the signature cache.

2017-03-31 20:08:23 +02:00

mainproc.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

Makefile.am

tests: Locate resources and scripts relative to top source dir.

2017-04-24 14:14:05 +02:00

mdfilter.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

migrate.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

misc.c

common, g10: Fix enumeration types.

2017-04-13 12:54:52 +09:00

openfile.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

options.h

gpg: Remove unused stuff.

2017-03-20 08:40:21 +01:00

options.skel

gpg: Rework gpg-conf.skel

2016-01-22 10:54:10 +01:00

packet.h

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

parse-packet.c

g10: Fix parse_ring_trust.

2017-04-17 09:33:19 +09:00

passphrase.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

photoid.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

photoid.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

pkclist.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

pkglue.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

pkglue.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

plaintext.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

progress.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

pubkey-enc.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

pubring.asc

Update copyright notices for 2017.

2017-01-23 19:16:55 +01:00

revoke.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

rmd160.c

Clean up word replication.

2017-02-21 13:11:46 -05:00

rmd160.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

seckey-cert.c

More change for common.

2017-03-07 20:32:09 +09:00

server.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

seskey.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

sig-check.c

gpg: Print more stats for the keydb and the signature cache.

2017-03-31 20:08:23 +02:00

sign.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

skclist.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

sqrtu32.c

Update copyright notices for 2017.

2017-01-23 19:16:55 +01:00

sqrtu32.h

g10: Add missing sqrtu32.h and sqrtu32.c.

2016-09-07 08:55:17 +02:00

t-keydb-get-keyblock.c

gpg: Fix actual leak and possible leaks in the packet parser.

2017-03-30 16:01:52 +02:00

t-keydb-get-keyblock.gpg

gpg: Correctly handle keyblocks followed by legacy keys.

2015-11-17 14:53:03 +01:00

t-keydb-keyring.kbx

g10: Add test for keydb as well as new testing infrastructure.

2015-09-02 15:08:57 +02:00

t-keydb.c

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

t-rmd160.c

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00

t-stutter-data.asc

gpg: Add a new test.

2016-03-08 14:08:49 +01:00

t-stutter.c

tests: Locate resources and scripts relative to top source dir.

2017-04-24 14:14:05 +02:00

tdbdump.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

tdbio.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

tdbio.h

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

test-stubs.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

test.c

tests: Locate resources and scripts relative to top source dir.

2017-04-24 14:14:05 +02:00

textfilter.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

tofu.c

g10: Minor fixes.

2017-04-17 09:15:13 +09:00

tofu.h

g10: Remove dead code.

2016-12-06 12:16:56 +01:00

trust.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

trustdb.c

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

trustdb.h

gpg: Pass CTRL to many more functions.

2017-03-31 20:07:20 +02:00

verify.c

Remove -I option to common.

2017-03-07 20:25:54 +09:00

zlib-riscos.h

Change all http://www.gnu.org in license notices to https://

2016-11-05 12:02:19 +01:00