1
0
mirror of git://git.gnupg.org/gnupg.git synced 2024-06-26 01:52:45 +02:00
Commit Graph

485 Commits

Author SHA1 Message Date
Werner Koch
123b68aadb Backported security fixes. 2006-12-07 16:17:12 +00:00
Werner Koch
37f8183d05 (is_prime): Free A2. Fixed bug #423. 2005-03-07 12:39:09 +00:00
David Shaw
4df22ba030 Disable the "quick check" bytes for PK decryptions. This is in
regards to the Mister and Zuccherato attack on OpenPGP CFB mode.
2005-02-10 04:11:35 +00:00
David Shaw
ee1827b8c1 * getkey.c (parse_key_usage): New function to parse out key usage flags.
Set PUBKEY_USAGE_UNKNOWN to handle flags (i.e. authentication) that we
don't understand in this branch. (fixup_uidnode, merge_selfsigs_main,
merge_selfsigs_subkey): Call it from here to remove duplicate code.  This
is bug 378.
2004-11-29 21:07:08 +00:00
David Shaw
b96dc04cde * getkey.c (premerge_public_with_secret): Fix subkey<->binding sig
mismatch when some secret subkeys are missing.  Discovered by Michael
Roth.
2004-09-14 01:55:58 +00:00
Werner Koch
ca650aefbc (maybe_create_keyring): Try to create the home directory
before acquiring a lock for the keyring.
2004-08-31 15:22:52 +00:00
David Shaw
297459b28b * hkp.c (dehtmlize): Understand the quote character (i.e. "&quot;") in
HTML responses.

* keydb.h, getkey.c (get_user_id_printable): Rename to get_user_id_native
and remove the printable stuff since we're print-ifying valid utf8
characters.  Change all callers in import.c, sign.c, and encode.c.
2004-08-20 17:24:08 +00:00
David Shaw
081a9b6fb7 * hkp.c (hkp_search): Translate string to search for from utf8 to native
before displaying it.

* keyserver.c (keyserver_search_prompt): Comments.
2004-08-19 20:40:52 +00:00
Werner Koch
ecb6f4c2f7 (encode_session_key): Changed the zero random byte
substituting code to actually do clever things.  Thanks to
Matthias Urlichs for noting the implementation problem.
2004-08-19 09:29:23 +00:00
Werner Koch
2639033890 (agent_get_passphrase): Fixed detection of canceled
error state as send by current gpg-agents.
2004-08-18 10:12:39 +00:00
Werner Koch
3cecfe2496 Removed stray semicolon. 2004-08-16 08:19:42 +00:00
Werner Koch
620abc1658 * keydb.c (keydb_add_resource): Factored keyring creation out to ..
(maybe_create_keyring): .. new.  Make sure that we do the checks
in a locked state.  Problem reported by Stefan Haller.
2004-08-13 17:00:05 +00:00
Werner Koch
c6b88a12dd * configure.ac (ALL_LINGUAS): Removed.
* Makefile.am (LDADD): Replaced INTLLIBS by LIBINTL.

* Makefile.am (gpgkeys_hkp_LDADD): Replaced INTLLIBS by LIBINTL.

* ca.po: Updated.

* autogen.sh: Run aclocal with -I m4.

* Makefile.am: Replaced INTLLIBS by LIBINTL.

* Makefile.am (http-test): Replaced INTLLIBS by LIBINTL.
2004-08-09 19:47:08 +00:00
Werner Koch
fe94e944ba New alias --throw-keyid for --throw-keyids, so that it
continues to work in old configuration files.  Noted by Jens Adam.
2004-07-30 09:26:09 +00:00
David Shaw
7a03f5baa3 * pkclist.c (algo_available): --pgp8 now allows blowfish, zlib, and bzip2. 2004-07-29 23:42:22 +00:00
David Shaw
4340b6765e * status.c (do_get_from_fd): Flush stdout if status isn't flushing it for
us.  This guarantees that any menus that were displayed before the prompt
don't get stuck in a buffer.  Noted by Peter Palfrader.  This is Debian
bug #254072.
2004-07-21 03:21:36 +00:00
Werner Koch
102408f458 Minor fixes for W32 packaging and building. 2004-07-20 17:21:28 +00:00
David Shaw
dd746f4e4b * sign.c (update_keysig_packet): Revert change of 2004-05-18. It is not
appropriate to strip policy and notations when remaking a sig.  That
should only happen when specifically requested by the user.
2004-07-19 00:39:00 +00:00
David Shaw
af77fd89fa * sign.c (sign_symencrypt_file): Allow using --force-mdc in --sign
--symmetric messages.
2004-06-27 22:53:09 +00:00
David Shaw
eb5045d972 * mainproc.c (proc_symkey_enc), seckey-cert.c (do_check): Check the S2K
hash algorithm before we try to generate a passphrase using it.  This
prevents hitting BUG() when generating a passphrase using a hash that we
don't have.
2004-06-27 18:26:49 +00:00
David Shaw
7c90cacd33 * keyedit.c (sign_uids): Properly handle remaking a self-sig on revoked or
expired user IDs.  Also, once we've established that a given uid cannot or
will not be signed, don't continue to ask about each sig.
2004-06-24 03:52:18 +00:00
David Shaw
0180c207e2 * status.h, status.c (get_status_string), plaintext.c (handle_plaintext):
New status tags PLAINTEXT and PLAINTEXT_LENGTH.
2004-06-18 19:16:03 +00:00
David Shaw
3659850b1b * keygen.c (make_backsig): Make sure that the backsig was built
successfully before we try and use it.
2004-06-16 14:43:05 +00:00
Werner Koch
c604d59716 (copy_secret_key): Get last fix right. 2004-06-16 13:22:36 +00:00
Werner Koch
40e66b1af1 (copy_secret_key): Fixed memory leak. 2004-06-16 09:36:59 +00:00
David Shaw
cd3e058f8b * g10.c (main): Alias --charset as --display-charset to help avoid the
continuing confusion and make room for possible changes in devel.

* parse-packet.c (parse_plaintext): Show the hex value for the literal
packet mode since it may not be printable.
2004-06-01 20:17:37 +00:00
David Shaw
4ea8f55f32 * pkclist.c (do_edit_ownertrust): Fix kbnode leak. 2004-05-23 16:09:01 +00:00
David Shaw
44aa6f9d4d * sign.c (update_keysig_packet): Policies and notations should be stripped
out when remaking a self-signature.  Noted by Atom Smasher.
2004-05-19 02:22:05 +00:00
Werner Koch
9953adb5e7 (do_generate_keypair, read_parameter_file): Really
close the files.
(do_generate_keypair): Create the secret key file using safe
permissions.  Noted by Atom Smasher.
2004-05-11 07:42:03 +00:00
Werner Koch
88dcf26646 (write_plaintext_packet): Fixed the detection of too
large files in the same way as in encode.c.
2004-05-07 09:32:53 +00:00
David Shaw
4a07655935 * keygen.c (make_backsig): If DO_BACKSIGS is not defined, do not create
backsigs.

* getkey.c (merge_selfsigs_subkey): Find 0x19 backsigs on subkey selfsigs
and verify they are valid.  If DO_BACKSIGS is not defined, fake this as
always valid.

* packet.h, parse-packet.c (parse_signature): Make parse_signature
non-static so we can parse 0x19s in self-sigs.

* main.h, sig-check.c (check_backsig): Check a 0x19 signature.
(signature_check2): Give a backsig warning if there is no or a bad 0x19
with signatures from a subkey.
2004-04-23 03:01:53 +00:00
David Shaw
8030362eae * parse-packet.c (dump_sig_subpkt, parse_one_sig_subpkt,
can_handle_critical): Parse and display 0x19 signatures.
2004-04-22 00:45:28 +00:00
David Shaw
e161b21b53 * keyserver.c (parse_keyserver_uri): Do not accept "http" as an alias for
"hkp".  They are not the same thing.
2004-04-20 19:37:58 +00:00
David Shaw
ce7d313333 * keygen.c (make_backsig): New function to add a backsig to a binding sig
of signing subkeys.  Currently disabled. (write_keybinding): Call it here,
for signing subkeys only.

* sign.c (make_keysig_packet): Allow generating 0x19 signatures (same as
0x18 or 0x28, but used for backsigs).

* packet.h, build-packet.c (build_sig_subpkt): Add new SIGSUBPKT_SIGNATURE
type for embedded signatures.
2004-04-13 01:17:32 +00:00
David Shaw
7ac574aeea * g10.c (main): --no-use-embedded-filename.
* plaintext.c (handle_plaintext): Accept 'u' as a plaintext mode that
requires end of line conversion.  This is being considered for a UTF8 text
packet.  If this doesn't take place, no major harm done.  If it does take
place, we'll get a jump on starting the changeover.
2004-04-01 04:02:27 +00:00
Werner Koch
42ac422ba0 *** empty log message *** 2004-03-29 13:56:57 +00:00
David Shaw
4c8b18363f * keyedit.c (keyedit_menu): Request a trustdb update when adding a new
user ID so the new ID gets validity set.  Reported by Owen Taylor.
2004-03-27 21:57:04 +00:00
David Shaw
5b9ec9dc31 * build-packet.c (calc_plaintext, do_plaintext): Do not create illegal
(packet header indicates a size larger than the actual packet) encrypted
data packets when not compressing and using a filename longer than 255
characters.
2004-03-26 19:49:01 +00:00
David Shaw
00bdac950e * options.h, g10.c (main), compress-bz2.c (init_uncompress): Backport
--bzip2-decompress-lowmem since we do handle receiving a bzip2 message on
the stable branch.
2004-03-25 22:53:54 +00:00
David Shaw
fd2e1cd717 * keyedit.c (no_primary_warning): Cleanup. (menu_expire): Don't give
primary warning for subkey expiration changes.  These cannot reorder
primaries.
2004-03-23 15:18:10 +00:00
David Shaw
2980b7129f * packet.h, getkey.c (fixup_uidnode, merge_selfsigs_subkey): Keep track of
which self-sig we actually chose.

* keyedit.c (menu_expire, menu_set_primary_uid, menu_set_preferences): Use
it here to avoid updating non-used self-sigs and possibly promoting an old
self-sig into consideration again.
2004-03-22 20:56:30 +00:00
David Shaw
8e5f3ce846 * keygen.c (write_keybinding, do_generate_keypair, generate_subkeypair):
Keep track of the unprotected subkey secret key so we can make a backsig
with it.
2004-03-18 19:43:07 +00:00
David Shaw
8615da464e * keygen.c (gen_elg, gen_dsa, gen_rsa, do_create, do_generate_keypair,
generate_subkeypair): New is_subkey argument to set whether a generated
key is a subkey.  Do not overload the ret_sk.  This is some early cleanup
to do backsigs for signing subkeys.
2004-03-18 17:42:09 +00:00
David Shaw
be441babaa * import.c (import_one): Try and collapse user IDs when importing a key
for the first time.

* build-packet.c (do_comment, do_user_id): Try for a headerlen of 2 since
that's the smallest and most likely encoding for these packets

* keyedit.c (menu_addrevoker): Allow appointing a subkey as a designated
revoker if the user forces it via keyid!, so long as the subkey can
certify.  Also use the proper date string when prompting for confirmation.
2004-03-09 20:49:31 +00:00
Werner Koch
5be5a9bbfd * options.h (ctrl): New for member IN_AUTO_KEY_RETRIEVE.
* mainproc.c (check_sig_and_print): track whether we are
retrieving a key.
* status.c (status_currently_allowed): New.
(write_status_text, write_status_text_and_buffer): Use it here.
2004-03-01 20:00:39 +00:00
David Shaw
009af80106 * keyedit.c (menu_addrevoker): Do not allow appointing a subkey as a
designated revoker.
2004-02-27 19:56:15 +00:00
David Shaw
693e4440b2 * delkey.c (do_delete_key): Allow deleting a public key with a secret
present if --expert is set.

* plaintext.c (handle_plaintext): Make bytecount static so it works with
multiple literal packets inside a message.
2004-02-25 23:32:34 +00:00
David Shaw
ecb568502d * encode.c (encode_simple): Show cipher with --verbose.
* options.h, g10.c (main), keyedit.c (sign_keys): Add --ask-cert-level
option to enable cert level prompts during sigs. Defaults to on.
Simplify --default-cert-check-level to --default-cert-level.  If
ask-cert-level is off, or batch is on, use the default-cert-level as the
cert level.

* options.h, g10.c (main), trustdb.c (mark_usable_uid_certs): Simplify
--min-cert-check-level to --min-cert-level.
2004-02-24 22:00:03 +00:00
David Shaw
2f0a98ad35 * options.h, g10.c (main), trustdb.c (mark_usable_uid_certs): Add
--min-cert-check-level option to specify minimum cert check level.
Defaults to 1 (so no sigs are ignored).  0x10 sigs cannot be ignored.

* options.h, g10.c (main), plaintext.c (handle_plaintext): Add
--max-output option to help people deal with decompression bombs.
2004-02-23 18:35:05 +00:00
David Shaw
95b6aacacc * build-packet.c (do_user_id): Do not force a header for attribute packets
as they require a new CTB, and we don't support forced headers for new
CTBs yet.
2004-02-15 15:49:05 +00:00