security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-03-02 21:11:05 +01:00
Code Activity

* keylist.c, keyedit.c, keyserver.c, sign.c: Some TODOs and comments.

Browse Source 
* export.c (do_export_stream): Fix noop bug in exporting sensitive
revocation keys.

* pkclist.c (do_edit_ownertrust): Comment out the option for showing trust
paths until it can be implemented.
This commit is contained in:
David Shaw 2002-08-20 12:45:57 +00:00
parent 0d8006450a
commit fa88fe9aaf
7 changed files with 39 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
g10/ChangeLog
View File

@ -1,3 +1,14 @@
2002-08-20 David Shaw <dshaw@jabberwocky.com>
* keylist.c, keyedit.c, keyserver.c, sign.c: Some TODOs and
comments.
* export.c (do_export_stream): Fix noop bug in exporting sensitive
revocation keys.
* pkclist.c (do_edit_ownertrust): Comment out the option for
showing trust paths until it can be implemented.
2002-08-19 Werner Koch <wk@gnupg.org>
* getkey.c (get_user_id_native): Renamed to ..

5
g10/export.c
View File

@ -275,7 +275,10 @@ do_export_stream( IOBUF out, STRLIST users, int secret,
for(i=0;i<node->pkt->pkt.signature->numrevkeys;i++)
if(node->pkt->pkt.signature->revkey[i]->class & 0x40)
continue;
break;
if(i<node->pkt->pkt.signature->numrevkeys)
continue;
}
/* delete our verification cache */

3
g10/keyedit.c
View File

@ -100,6 +100,9 @@ print_and_check_one_sig( KBNODE keyblock, KBNODE node,
int rc, sigrc;
int is_rev = sig->sig_class == 0x30;
/* TODO: Make sure a cached sig record here still has the pk that
issued it. See also keylist.c:list_keyblock_print */
switch( (rc = check_key_signature( keyblock, node, is_selfsig)) ) {
case 0:
node->flag &= ~(NODFLG_BADSIG|NODFLG_NOKEY|NODFLG_SIGERR);

5
g10/keylist.c
View File

@ -517,6 +517,11 @@ list_keyblock_print ( KBNODE keyblock, int secret, int fpr, void *opaque )
case G10ERR_UNU_PUBKEY: stats->no_key++; continue;
default: stats->oth_err++; sigrc = '%'; break;
}
/* TODO: Make sure a cached sig record here still has
the pk that issued it. See also
keyedit.c:print_and_check_one_sig */
}
else {
rc = 0;

5
g10/keyserver.c
View File

@ -987,6 +987,11 @@ keyserver_search(STRLIST tokens)
/* Count and searchstr are just for cosmetics. If the count is too
small, it will grow safely. If negative it disables the "Key x-y
of z" messages. */
/* TODO: do this as a list sent to keyserver_work rather than calling
it once for each key to get the correct counts after the import
(cosmetics, really) and to better take advantage of the keyservers
that can do multiple fetches in one go (LDAP). */
void
keyserver_search_prompt(IOBUF buffer,int count,const char *searchstr)
{

6
g10/pkclist.c
View File

@ -276,7 +276,10 @@ do_edit_ownertrust (PKT_public_key *pk, int mode,
tty_printf (_(" %d = I trust fully\n"), 4);
if (mode)
tty_printf (_(" %d = I trust ultimately\n"), 5);
#if 0
/* not yet implemented */
tty_printf (_(" i = please show me more information\n") );
#endif
if( mode )
tty_printf(_(" m = back to the main menu\n"));
else
@ -320,12 +323,15 @@ do_edit_ownertrust (PKT_public_key *pk, int mode,
break;
}
}
#if 0
/* not yet implemented */
else if( *p == ans[0] || *p == ans[1] )
{
tty_printf(_("Certificates leading to an ultimately trusted key:\n"));
show = 1;
break;
}
#endif
else if( mode && (*p == ans[2] || *p == ans[3] || *p == CONTROL_D ) )
{
break ; /* back to the menu */

4
g10/sign.c
View File

@ -1165,7 +1165,9 @@ make_keysig_packet( PKT_signature **ret_sig, PKT_public_key *pk,
/* If you are making a signature on a v4 key using your v3 key, it
doesn't make sense to generate a v3 sig. After all, no v3-only
PGP implementation could understand the v4 key in the first
place. */
place. Note that this implies that a signature on an attribute
uid is usually going to be v4 as well, since they are not
generally found on v3 keys. */
if (sigversion < pk->version)
sigversion = pk->version;