From ef5fa47ee80da14427187b006a9c44321081f09c Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Fri, 30 May 2025 14:11:22 +0200 Subject: [PATCH] gpgtar: Fix regression exhibited by make check * tools/gpgtar-extract.c (gpgtar_extract): Do final process_release. * tools/gpgtar-list.c (gpgtar_list): Ditto. -- Fixes-commit: 29bc14f56f6430294f225b6744012ab1f5df62e6 Running "make -C tests/openpgp check verbose=3" failed with Creating configuration files Executing: '/home/wk/b/gnupg/tools/gpgtar' '--extract' \ '--directory=.' \ '/tmp/gpgscm-20250530T121329-run-tests-vGAT4R/environment-cache' make: *** [Makefile:998: xcheck] Terminated for unknown reasons. Not calling the gpgrt_process_release fixes this regression. The real cause needs to be investigated. --- tools/gpgtar-extract.c | 2 +- tools/gpgtar-list.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/gpgtar-extract.c b/tools/gpgtar-extract.c index 37c5996c1..7f75ebd23 100644 --- a/tools/gpgtar-extract.c +++ b/tools/gpgtar-extract.c @@ -559,7 +559,7 @@ gpgtar_extract (const char *filename, int decrypt) } leave: - gpgrt_process_release (proc); + /* fixme: Why can't we use gpgrt_process_release (proc); */ notextracted = tarinfo->skipped_badname; notextracted += tarinfo->skipped_suspicious; notextracted += tarinfo->skipped_symlinks; diff --git a/tools/gpgtar-list.c b/tools/gpgtar-list.c index ef851d8f1..9bd568380 100644 --- a/tools/gpgtar-list.c +++ b/tools/gpgtar-list.c @@ -593,7 +593,7 @@ gpgtar_list (const char *filename, int decrypt) } leave: - gpgrt_process_release (proc); + /* fixme: Why can't we use gpgrt_process_release (proc); */ free_strlist (extheader); xfree (header); if (stream != es_stdin)