1
0
mirror of git://git.gnupg.org/gnupg.git synced 2024-11-10 21:38:50 +01:00

gpg: New option --require-compliance.

* g10/options.h (opt): Add field flags.require_compliance.
* g10/gpg.c (oRequireCompliance): New.
(opts): Add --require-compliance.
(main): Set option.
* g10/mainproc.c (proc_encrypted): Emit error if non de-vs compliant.
(check_sig_and_print): Ditto.
* g10/encrypt.c (encrypt_crypt): Ditto.
--

Note that in the --encrypt and --verify cased other checks may kick in
earlier than this new --require-compliance controlled one.
This commit is contained in:
Werner Koch 2022-03-08 10:13:44 +01:00
parent 49c6e58394
commit ee013c5350
No known key found for this signature in database
GPG Key ID: E3FDFF218E45B72B
5 changed files with 66 additions and 6 deletions

View File

@ -2957,6 +2957,17 @@ This option adjusts the compliance mode "de-vs" for stricter key size
requirements. For example, a value of 3000 turns rsa2048 and dsa2048 requirements. For example, a value of 3000 turns rsa2048 and dsa2048
keys into non-VS-NfD compliant keys. keys into non-VS-NfD compliant keys.
@item --require-compliance
@opindex require-compliance
To check that data has been encrypted according to the rules of the
current compliance mode, a gpg user needs to evaluate the status
lines. This is allows frontends to handle compliance check in a more
flexible way. However, for scripted use the required evaluation of
the status-line requires quite some effort; this option can be used
instead to make sure that the gpg process exits with a failure if the
compliance rules are not fulfilled. Note that this option has
currently an effect only in "de-vs" mode.
@end table @end table

View File

@ -847,6 +847,17 @@ encrypt_crypt (ctrl_t ctrl, int filefd, const char *filename,
gnupg_status_compliance_flag (CO_DE_VS), gnupg_status_compliance_flag (CO_DE_VS),
NULL); NULL);
if (opt.flags.require_compliance
&& opt.compliance == CO_DE_VS
&& !compliant)
{
log_error (_("operation forced to fail due to"
" unfulfilled compliance rules\n"));
rc = gpg_error (GPG_ERR_FORBIDDEN);
g10_errors_seen = 1;
goto leave;
}
cfx.dek->use_aead = use_aead (pk_list, cfx.dek->algo); cfx.dek->use_aead = use_aead (pk_list, cfx.dek->algo);
if (!cfx.dek->use_aead) if (!cfx.dek->use_aead)
cfx.dek->use_mdc = !!use_mdc (pk_list, cfx.dek->algo); cfx.dek->use_mdc = !!use_mdc (pk_list, cfx.dek->algo);

View File

@ -442,6 +442,7 @@ enum cmd_and_opt_values
oChUid, oChUid,
oForceSignKey, oForceSignKey,
oForbidGenKey, oForbidGenKey,
oRequireCompliance,
oNoop oNoop
}; };
@ -911,6 +912,7 @@ static gpgrt_opt_t opts[] = {
ARGPARSE_s_n (oNoAutostart, "no-autostart", "@"), ARGPARSE_s_n (oNoAutostart, "no-autostart", "@"),
ARGPARSE_s_n (oUseKeyboxd, "use-keyboxd", "@"), ARGPARSE_s_n (oUseKeyboxd, "use-keyboxd", "@"),
ARGPARSE_s_n (oForbidGenKey, "forbid-gen-key", "@"), ARGPARSE_s_n (oForbidGenKey, "forbid-gen-key", "@"),
ARGPARSE_s_n (oRequireCompliance, "require-compliance", "@"),
/* Options which can be used in special circumstances. They are not /* Options which can be used in special circumstances. They are not
* published and we hope they are never required. */ * published and we hope they are never required. */
ARGPARSE_s_n (oUseOnlyOpenPGPCard, "use-only-openpgp-card", "@"), ARGPARSE_s_n (oUseOnlyOpenPGPCard, "use-only-openpgp-card", "@"),
@ -3731,6 +3733,10 @@ main (int argc, char **argv)
mopt.forbid_gen_key = 1; mopt.forbid_gen_key = 1;
break; break;
case oRequireCompliance:
opt.flags.require_compliance = 1;
break;
case oNoop: break; case oNoop: break;
default: default:

View File

@ -546,6 +546,7 @@ proc_encrypted (CTX c, PACKET *pkt)
{ {
int result = 0; int result = 0;
int early_plaintext = literals_seen; int early_plaintext = literals_seen;
unsigned int compliance_de_vs = 0;
if (pkt->pkttype == PKT_ENCRYPTED_AEAD) if (pkt->pkttype == PKT_ENCRYPTED_AEAD)
c->seen_pkt_encrypted_aead = 1; c->seen_pkt_encrypted_aead = 1;
@ -721,10 +722,12 @@ proc_encrypted (CTX c, PACKET *pkt)
xfree (pk); xfree (pk);
if (compliant) if (compliant)
write_status_strings (STATUS_DECRYPTION_COMPLIANCE_MODE, {
gnupg_status_compliance_flag (CO_DE_VS), write_status_strings (STATUS_DECRYPTION_COMPLIANCE_MODE,
NULL); gnupg_status_compliance_flag (CO_DE_VS),
NULL);
compliance_de_vs |= 1;
}
} }
if (!result) if (!result)
@ -779,9 +782,15 @@ proc_encrypted (CTX c, PACKET *pkt)
log_info(_("decryption okay\n")); log_info(_("decryption okay\n"));
if (pkt->pkt.encrypted->aead_algo) if (pkt->pkt.encrypted->aead_algo)
write_status (STATUS_GOODMDC); {
write_status (STATUS_GOODMDC);
compliance_de_vs |= 2;
}
else if (pkt->pkt.encrypted->mdc_method && !result) else if (pkt->pkt.encrypted->mdc_method && !result)
write_status (STATUS_GOODMDC); {
write_status (STATUS_GOODMDC);
compliance_de_vs |= 2;
}
else else
log_info (_("WARNING: message was not integrity protected\n")); log_info (_("WARNING: message was not integrity protected\n"));
} }
@ -823,6 +832,17 @@ proc_encrypted (CTX c, PACKET *pkt)
* a misplace extra literal data packets follows after this * a misplace extra literal data packets follows after this
* encrypted packet. */ * encrypted packet. */
literals_seen++; literals_seen++;
/* The --require-compliance option allows to simplify decryption in
* de-vs compliance mode by just looking at the exit status. */
if (opt.flags.require_compliance
&& opt.compliance == CO_DE_VS
&& compliance_de_vs != (2|1))
{
log_error (_("operation forced to fail due to"
" unfulfilled compliance rules\n"));
g10_errors_seen = 1;
}
} }
@ -2439,6 +2459,15 @@ check_sig_and_print (CTX c, kbnode_t node)
write_status_strings (STATUS_VERIFICATION_COMPLIANCE_MODE, write_status_strings (STATUS_VERIFICATION_COMPLIANCE_MODE,
gnupg_status_compliance_flag (CO_DE_VS), gnupg_status_compliance_flag (CO_DE_VS),
NULL); NULL);
else if (opt.flags.require_compliance
&& opt.compliance == CO_DE_VS)
{
log_error (_("operation forced to fail due to"
" unfulfilled compliance rules\n"));
if (!rc)
rc = gpg_error (GPG_ERR_FORBIDDEN);
}
free_public_key (pk); free_public_key (pk);
pk = NULL; pk = NULL;

View File

@ -269,6 +269,9 @@ struct
/* The next flag is set internally iff IMPORT_CLEAN has /* The next flag is set internally iff IMPORT_CLEAN has
* been set by the user and is not the default value. */ * been set by the user and is not the default value. */
unsigned int expl_import_clean:1; unsigned int expl_import_clean:1;
/* Fail if an operation can't be done in the requested compliance
* mode. */
unsigned int require_compliance:1;
} flags; } flags;
/* Linked list of ways to find a key if the key isn't on the local /* Linked list of ways to find a key if the key isn't on the local