security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-07-02 22:46:30 +02:00
Code Activity

common,agent,dirmngr,g10,tools: Fix split_fields API.

Browse source 
* common/stringhelp.h (split_fields): Use const * for the strings in
the ARRAY.
(split_fields_colon): Likewise.
* common/stringhelp.c (split_fields, split_fields_colon): Fix
the implementation.
* agent/call-scd.c, agent/command.c: Follow the change.
* common/t-stringhelp.c, dirmngr/loadswdb.c: Likewise.
* g10/call-agent.c, tools/card-call-scd.c: Likewise.
* tools/card-yubikey.c, tools/gpg-card.c: Likewise.
* tools/gpg-card.h, tools/gpg-wks-client.c: Likewise.
* tools/gpgconf-comp.c, tools/gpgconf.c: Likewise.
* tools/wks-util.c: Likewise.

--

The strings in the ARRAY don't need to be released by caller, as those
are references.  It's easier to follow the code when it's explicitly
const *.

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
This commit is contained in:
NIIBE Yutaka 2020-09-18 10:20:23 +09:00
parent 8ff3663027
commit dfdcf14738
15 changed files with 33 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

6
g10/call-agent.c
View file

@ -842,7 +842,7 @@ scd_keypairinfo_status_cb (void *opaque, const char *line)
/* The format of such a line is:
* KEYPAIRINFO <hexgrip> <keyref> [usage] [keytime]
*/
char *fields[4];
const char *fields[4];
int nfields;
const char *hexgrp, *keyref, *usage;
time_t atime;
@ -1467,7 +1467,7 @@ readkey_status_cb (void *opaque, const char *line)
* Note that we use only the first valid KEYPAIRINFO line. More
* lines are possible if a second card carries the same key.
*/
char *fields[4];
const char *fields[4];
int nfields;
time_t atime;
@ -2099,7 +2099,7 @@ keyinfo_status_cb (void *opaque, const char *line)
* 6 7 8
* <sshfpr> <ttl> <flags>
*/
char *fields[9];
const char *fields[9];
if (split_fields (s, fields, DIM (fields)) == 9)
{