security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-07-02 22:46:30 +02:00
Code Activity

common,agent,dirmngr,g10,tools: Fix split_fields API.

Browse source 
* common/stringhelp.h (split_fields): Use const * for the strings in
the ARRAY.
(split_fields_colon): Likewise.
* common/stringhelp.c (split_fields, split_fields_colon): Fix
the implementation.
* agent/call-scd.c, agent/command.c: Follow the change.
* common/t-stringhelp.c, dirmngr/loadswdb.c: Likewise.
* g10/call-agent.c, tools/card-call-scd.c: Likewise.
* tools/card-yubikey.c, tools/gpg-card.c: Likewise.
* tools/gpg-card.h, tools/gpg-wks-client.c: Likewise.
* tools/gpgconf-comp.c, tools/gpgconf.c: Likewise.
* tools/wks-util.c: Likewise.

--

The strings in the ARRAY don't need to be released by caller, as those
are references.  It's easier to follow the code when it's explicitly
const *.

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
This commit is contained in:
NIIBE Yutaka 2020-09-18 10:20:23 +09:00
parent 8ff3663027
commit dfdcf14738
15 changed files with 33 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

2
agent/call-scd.c
View file

@ -682,7 +682,7 @@ readkey_status_cb (void *opaque, const char *line)
* Here we only need the keyref. We use only the first received
* KEYPAIRINFO; it is possible to receive several if there are
* two or more active cards with the same key. */
char *fields[2];
const char *fields[2];
int nfields;
line_buffer = xtrystrdup (line);

4
agent/command.c
View file

@ -2804,7 +2804,7 @@ cmd_keytocard (assuan_context_t ctx, char *line)
ctrl_t ctrl = assuan_get_pointer (ctx);
int force;
gpg_error_t err = 0;
char *argv[5];
const char *argv[5];
int argc;
unsigned char grip[20];
const char *serialno, *timestamp_str, *keyref;
@ -3501,7 +3501,7 @@ cmd_getinfo (assuan_context_t ctx, char *line)
{
#if GCRYPT_VERSION_NUMBER >= 0x010800
char *buf;
char *fields[5];
const char *fields[5];
buf = gcry_get_config (0, "rng-type");
if (buf