From cf4910419e09daf414f76ca2c8ab685c3d488ec1 Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Wed, 8 Jun 2016 14:04:47 +0200 Subject: [PATCH] gpgconf: New commands --create-socketdir and --remove-socketdir. * tools/gpgconf.c: Include unistd.h. (aCreateSocketDir, aRemoveSocketDir): New. (opts): Add --create-socketdir and --remove-socketdir. (main): Implement them. Signed-off-by: Werner Koch --- doc/tools.texi | 11 ++++++++ tools/gpgconf.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+) diff --git a/doc/tools.texi b/doc/tools.texi index 425790e9d..8fdaa96a7 100644 --- a/doc/tools.texi +++ b/doc/tools.texi @@ -319,6 +319,17 @@ gpg-agent and scdaemon. Components which don't support reloading are ignored. Note that as of now reload and kill have the same effect for scdaemon. +@item --create-socketdir +@opindex create-socketdir +Create a directory for sockets below /run/user or /var/run/user. This +is command is only required if a non default home directory is used +and the /run based sockets shall be used. For the default home +directory GnUPG creates a directory on the fly. + +@item --remove-socketdir +@opindex remove-socketdir +Remove a directory created with command @option{--create-socketdir}. + @end table diff --git a/tools/gpgconf.c b/tools/gpgconf.c index fb1032bba..2b177e233 100644 --- a/tools/gpgconf.c +++ b/tools/gpgconf.c @@ -22,6 +22,7 @@ #include #include #include +#include #include "gpgconf.h" #include "i18n.h" @@ -53,6 +54,8 @@ enum cmd_and_opt_values aListDirs, aLaunch, aKill, + aCreateSocketDir, + aRemoveSocketDir, aReload }; @@ -78,6 +81,8 @@ static ARGPARSE_OPTS opts[] = { aReload, "reload", 256, N_("reload all or a given component")}, { aLaunch, "launch", 256, N_("launch a given component")}, { aKill, "kill", 256, N_("kill a given component")}, + { aCreateSocketDir, "create-socketdir", 256, "@"}, + { aRemoveSocketDir, "remove-socketdir", 256, "@"}, { 301, NULL, 0, N_("@\nOptions:\n ") }, @@ -191,6 +196,8 @@ main (int argc, char **argv) case aReload: case aLaunch: case aKill: + case aCreateSocketDir: + case aRemoveSocketDir: cmd = pargs.r_opt; break; @@ -388,6 +395,66 @@ main (int argc, char **argv) xfree (tmp); } break; + + case aCreateSocketDir: + { + char *socketdir; + unsigned int flags; + + /* Make sure that the top /run/user/UID/gnupg dir has been + * created. */ + gnupg_socketdir (); + + /* Check the /var/run dir. */ + socketdir = _gnupg_socketdir_internal (1, &flags); + if ((flags & 64) && !opt.dry_run) + { + /* No sub dir - create it. */ + if (gnupg_mkdir (socketdir, "-rwx")) + gc_error (1, errno, "error creating '%s'", socketdir); + /* Try again. */ + socketdir = _gnupg_socketdir_internal (1, &flags); + } + + /* Give some info. */ + if ( (flags & ~32) || opt.verbose || opt.dry_run) + { + log_info ("socketdir is '%s'\n", socketdir); + if ((flags & 1)) log_info ("\tgeneral error\n"); + if ((flags & 2)) log_info ("\tno /run/user dir\n"); + if ((flags & 4)) log_info ("\tbad permissions\n"); + if ((flags & 8)) log_info ("\tbad permissions (subdir)\n"); + if ((flags & 16)) log_info ("\tmkdir failed\n"); + if ((flags & 32)) log_info ("\tnon-default homedir\n"); + if ((flags & 64)) log_info ("\tno such subdir\n"); + if ((flags & 128)) log_info ("\tusing homedir as fallback\n"); + } + + if ((flags & ~32) && !opt.dry_run) + gc_error (1, 0, "error creating socket directory"); + + xfree (socketdir); + } + break; + + case aRemoveSocketDir: + { + char *socketdir; + unsigned int flags; + + /* Check the /var/run dir. */ + socketdir = _gnupg_socketdir_internal (1, &flags); + if ((flags & 128)) + log_info ("ignoring request to remove non /run/user socket dir\n"); + else if (opt.dry_run) + ; + else if (rmdir (socketdir)) + gc_error (1, errno, "error removing '%s'", socketdir); + + xfree (socketdir); + } + break; + } if (outfp != es_stdout)