security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-01-08 12:44:23 +01:00
Code Activity

g10: Fix ECDH, clarifying the format.

Browse Source 
* g10/ecdh.c (pk_ecdh_encrypt_with_shared_point): Returns error when
it's short.  Clarify the format.  Handle other prefixes correctly.

--
With the scdaemon's change, there is no case NBYTES < SECRET_X_SIZE.
This fixes the break of ECDH with X25519.

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>
This commit is contained in:
NIIBE Yutaka 2016-10-27 12:59:49 +09:00
parent 6bbd97d6c7
commit ca0ee4e381
1 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
g10/ecdh.c
View File

@ -135,27 +135,29 @@ pk_ecdh_encrypt_with_shared_point (int is_encrypt, gcry_mpi_t shared_mpi,
/* Expected size of the x component */ /* Expected size of the x component */
secret_x_size = (nbits+7)/8; secret_x_size = (nbits+7)/8;
if (nbytes > secret_x_size) /* Extract X from the result. It must be in the format of:
{ 04 || X || Y
/* Uncompressed format expected, so it must start with 04 */ 40 || X
if (secret_x[0] != (byte)0x04) 41 || X
Since it always comes with the prefix, it's larger than X. In
old experimental version of libgcrypt, there is a case where it
returns X with no prefix of 40, so, nbytes == secret_x_size
is allowed. */
if (nbytes < secret_x_size)
{ {
xfree (secret_x);
return gpg_error (GPG_ERR_BAD_DATA); return gpg_error (GPG_ERR_BAD_DATA);
} }
/* Remove the "04" prefix of non-compressed format. */ /* Remove the prefix. */
if ((nbytes & 1))
memmove (secret_x, secret_x+1, secret_x_size); memmove (secret_x, secret_x+1, secret_x_size);
/* Zeroize the y component following */ /* Clear the rest of data. */
if (nbytes > secret_x_size) if (nbytes - secret_x_size)
memset (secret_x+secret_x_size, 0, nbytes-secret_x_size); memset (secret_x+secret_x_size, 0, nbytes-secret_x_size);
}
else if (nbytes < secret_x_size)
{
/* Raw share secret (x coordinate), without leading zeros */
memmove (secret_x+(secret_x_size - nbytes), secret_x, nbytes);
memset (secret_x, 0, secret_x_size - nbytes);
}
if (DBG_CRYPTO) if (DBG_CRYPTO)
log_printhex ("ECDH shared secret X is:", secret_x, secret_x_size ); log_printhex ("ECDH shared secret X is:", secret_x, secret_x_size );
} }