security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2025-06-14 18:31:03 +02:00
Code Activity

(keygen_set_std_prefs): Explain the chosen order of

Browse Source 
AES key sizes.
This commit is contained in:
Werner Koch 2005-04-01 09:03:15 +00:00
parent c336e34571
commit c43423f0bd
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
g10/keygen.c
View File

@ -325,7 +325,7 @@ keygen_set_std_prefs (const char *string,int personal)
byte sym[MAX_PREFS], hash[MAX_PREFS], zip[MAX_PREFS]; byte sym[MAX_PREFS], hash[MAX_PREFS], zip[MAX_PREFS];
int nsym=0, nhash=0, nzip=0, val, rc=0; int nsym=0, nhash=0, nzip=0, val, rc=0;
int mdc=1, modify=0; /* mdc defaults on, modify defaults off. */ int mdc=1, modify=0; /* mdc defaults on, modify defaults off. */
char dummy_string[45]; /* enough for 15 items */ char dummy_string[45+1]; /* Enough for 15 items. */
if (!string || !ascii_strcasecmp (string, "default")) if (!string || !ascii_strcasecmp (string, "default"))
{ {
@ -335,6 +335,18 @@ keygen_set_std_prefs (const char *string,int personal)
{ {
dummy_string[0]='\0'; dummy_string[0]='\0';
/* The rationale why we use the order AES256,192,128 is
for compatibility reasons with PGP. If gpg would
define AES128 first, we would get the somewhat
confusing situation:
gpg -r pgpkey -r gpgkey ---gives--> AES256
gpg -r gpgkey -r pgpkey ---gives--> AES
Note that by using --personal-cipher-preferences it is
possible to prefer AES128.
*/
/* Make sure we do not add more than 15 items here, as we /* Make sure we do not add more than 15 items here, as we
could overflow the size of dummy_string. */ could overflow the size of dummy_string. */
if(!check_cipher_algo(CIPHER_ALGO_AES256)) if(!check_cipher_algo(CIPHER_ALGO_AES256))