security-and-privacy/gnupg
security-and-privacy/gnupg
1
0
Fork 0
mirror of git://git.gnupg.org/gnupg.git synced 2024-12-22 10:19:57 +01:00
Code Activity

Truncate the DSA hash; fixes regression.

Browse Source 
Removed left over debug code.
This commit is contained in:
Werner Koch 2011-01-21 15:58:07 +01:00
parent 27929981fc
commit c3db7705c0
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
g10/ChangeLog
View File

@ -1,5 +1,7 @@
2011-01-21 Werner Koch <wk@g10code.com> 2011-01-21 Werner Koch <wk@g10code.com>
* seskey.c (encode_md_value): Truncate the DSA hash again.
* misc.c (openpgp_pk_algo_name): Always use the gcrypt function. * misc.c (openpgp_pk_algo_name): Always use the gcrypt function.
2010-12-09 Werner Koch <wk@g10code.com> 2010-12-09 Werner Koch <wk@g10code.com>

10
g10/seskey.c
View File

@ -319,11 +319,13 @@ encode_md_value (PKT_public_key *pk, gcry_md_hd_t md, int hash_algo)
return NULL; return NULL;
} }
/* Note that in case of ECDSA 521 hash is always smaller than /* By passing QBYTES as length to mpi_scan, we do the truncation
the key size. */ of the hash.
Note that in case of ECDSA 521 the hash is always smaller
than the key size. */
if (gcry_mpi_scan (&frame, GCRYMPI_FMT_USG, if (gcry_mpi_scan (&frame, GCRYMPI_FMT_USG,
gcry_md_read (md, hash_algo), gcry_md_read (md, hash_algo), qbytes, &qbytes))
gcry_md_get_algo_dlen (hash_algo), &qbytes))
BUG(); BUG();
} }
else else

3
g10/sign.c
View File

@ -298,9 +298,6 @@ do_sign (PKT_public_key *pksk, PKT_signature *sig,
{ {
PKT_public_key *pk = xmalloc_clear (sizeof *pk); PKT_public_key *pk = xmalloc_clear (sizeof *pk);
log_debug ("checking created signature algo=%d\n", mdalgo);
log_printhex ("md:", dp, gcry_md_get_algo_dlen (mdalgo));
if (get_pubkey (pk, sig->keyid )) if (get_pubkey (pk, sig->keyid ))
err = gpg_error (GPG_ERR_NO_PUBKEY); err = gpg_error (GPG_ERR_NO_PUBKEY);
else else