mirror of
git://git.gnupg.org/gnupg.git
synced 2025-07-03 22:56:33 +02:00
Doc fixes, moved some fizmes to TODO, fixed minor bugs.
This commit is contained in:
parent
c6736b6435
commit
c39b866d2a
14 changed files with 208 additions and 421 deletions
|
@ -178,7 +178,7 @@ base64_reader_cb (void *cb_value, char *buffer, size_t count, size_t *nread)
|
|||
if (c == '\n')
|
||||
{
|
||||
parm->have_lf = 1;
|
||||
/* FIXME: we need to skip overlong lines while detecting
|
||||
/* Fixme: we need to skip overlong lines while detecting
|
||||
the dashed lines */
|
||||
break;
|
||||
}
|
||||
|
|
|
@ -553,7 +553,7 @@ learn_cb (void *opaque, const void *buffer, size_t length)
|
|||
}
|
||||
|
||||
|
||||
/* FIXME: this shoudl go inot import.c */
|
||||
/* FIXME: this should go into import.c */
|
||||
cert = ksba_cert_new ();
|
||||
if (!cert)
|
||||
{
|
||||
|
|
|
@ -256,10 +256,6 @@ gpgsm_create_cms_signature (KsbaCert cert, GCRY_MD_HD md, int mdalgo,
|
|||
gcry_md_get_algo_dlen (mdalgo), mdalgo,
|
||||
r_sigval, &siglen);
|
||||
xfree (grip);
|
||||
/* FIXME: we should check that the returned S-Exp is valid fits int
|
||||
siglen. It ould probably be a good idea to scan and print it
|
||||
again to make this sure and be sure that we have canoncical
|
||||
encoding */
|
||||
return rc;
|
||||
}
|
||||
|
||||
|
|
|
@ -82,7 +82,7 @@ prepare_decryption (const char *hexkeygrip, KsbaConstSexp enc_val,
|
|||
/* FIXME: Actually the leading zero is required but due to the way
|
||||
we encode the output in libgcrypt as an MPI we are not able to
|
||||
encode that leading zero. However, when using a Smartcard we are
|
||||
doing it the rightway and therefore we have skip the zero. This
|
||||
doing it the rightway and therefore we have to skip the zero. This
|
||||
should be fixed in gpg-agent of course. */
|
||||
if (!seskey[n])
|
||||
n++;
|
||||
|
|
|
@ -580,7 +580,7 @@ main ( int argc, char **argv)
|
|||
struct server_control_s ctrl;
|
||||
CERTLIST recplist = NULL;
|
||||
|
||||
/* fixme: trap_unaligned ();*/
|
||||
/* trap_unaligned ();*/
|
||||
set_strusage (my_strusage);
|
||||
gcry_control (GCRYCTL_SUSPEND_SECMEM_WARN);
|
||||
/* Please note that we may running SUID(ROOT), so be very CAREFUL
|
||||
|
@ -1048,7 +1048,7 @@ main ( int argc, char **argv)
|
|||
case aSign: /* sign the given file */
|
||||
/* FIXME: we can only do detached sigs for now and we don't
|
||||
handle --output yet. We should also allow to concatenate
|
||||
multiple files for signins because that is what gpg does.*/
|
||||
multiple files for signing because that is what gpg does.*/
|
||||
if (!argc)
|
||||
gpgsm_sign (&ctrl, 0, 1, stdout); /* create from stdin */
|
||||
else if (argc == 1)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue