From c008e8d20e12c8845403ad7dad499f6a196ecc6a Mon Sep 17 00:00:00 2001 From: Werner Koch Date: Wed, 30 Dec 2020 15:00:28 +0100 Subject: [PATCH] wkd: Minor permission fix for created files. * tools/wks-util.c (wks_cmd_install_key): Don't set u+x on the file. (ensure_policy_file): No need to make the policy file group writable. -- The policy file is rarely changed thus no need to g+w. Setting +x on a plain file does not make sense at all. GnuPG-bug-id: 5214 --- tools/wks-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/wks-util.c b/tools/wks-util.c index 7afe6c1aa..516c7fe00 100644 --- a/tools/wks-util.c +++ b/tools/wks-util.c @@ -931,7 +931,7 @@ ensure_policy_file (const char *addrspec) log_info ("policy file '%s' created\n", fname); /* Make sure the policy file world readable. */ - if (gnupg_chmod (fname, "-rw-rw-r--")) + if (gnupg_chmod (fname, "-rw-r--r--")) { err = gpg_error_from_syserror (); log_error ("can't set permissions of '%s': %s\n", @@ -1131,7 +1131,7 @@ wks_cmd_install_key (const char *fname, const char *userid) } /* Make sure it is world readable. */ - if (gnupg_chmod (huname, "-rwxr--r--")) + if (gnupg_chmod (huname, "-rw-r--r--")) log_error ("can't set permissions of '%s': %s\n", huname, gpg_strerror (gpg_err_code_from_syserror()));